From: Alan Mackenzie <acm@muc.de>
To: Juri Linkov <juri@linkov.net>
Cc: 36492-done@debbugs.gnu.org
Subject: bug#36492: c-mode fails with errors during fontification
Date: Mon, 8 Jul 2019 12:53:32 +0000 [thread overview]
Message-ID: <20190708125332.GA5244@ACM> (raw)
In-Reply-To: <871rz15xp1.fsf@mail.linkov.net>
Hello, Juri.
On Mon, Jul 08, 2019 at 00:52:02 +0300, Juri Linkov wrote:
> >>> Opening this message in Gnus fails with the following backtrace
> >>> because c-mode fails to fontify the attachment.
> >> Actually, with the attachment in this message the bug in c-mode
> >> font-lock is much easier to reproduce.
> > That is one ugly piece of erroneous C. ;-)
> > What triggers the bug is the ) without a preceding (. A variable
> > recording the position of the opening ( is still set to nil, and we
> > tried to use it in the given buffer with the unbalanced ).
> >> [-- text/x-csrc, encoding 7bit, charset: US-ASCII, 3 lines, name: test.c --]
> > The following patch fixes it, I hope. Would you please do the usual,
> > and confirm that it does indeed fix the bug (or tell me what's still
> > wrong).
> Thanks, Alan. Now there is no error anymore.
Thanks. I've committed the fix, and I'm closing the bug.
> I wonder if ignore-errors around font-lock-ensure in mm-display-inline-fontify
> is still necessary to ensure no more bugs in other modes disrupt Gnus
> by erroneous code in attachments? Or maybe raising such errors will help
> to find fontification bugs sooner?
My feeling is that it's better to let the errors happen, so that we can
debug them. But on the other hand, it's not me that gets inconvenienced
by such an error (I don't use gnus).
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2019-07-08 12:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 20:56 bug#36492: c-mode fails with errors during fontification Juri Linkov
2019-07-04 20:08 ` Juri Linkov
[not found] ` <mailman.154.1562272763.2688.bug-gnu-emacs@gnu.org>
2019-07-04 21:19 ` Alan Mackenzie
2019-07-06 14:27 ` Alan Mackenzie
2019-07-07 21:52 ` Juri Linkov
2019-07-08 12:53 ` Alan Mackenzie [this message]
2019-07-08 13:16 ` Noam Postavsky
2019-07-08 21:46 ` Juri Linkov
2019-07-08 21:58 ` Noam Postavsky
2019-07-08 13:47 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190708125332.GA5244@ACM \
--to=acm@muc.de \
--cc=36492-done@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).