From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#11865: Fwd: Re: 24.1.50; doxygen comments not highlighted in c++-mode Date: Sun, 30 Jun 2019 15:13:31 +0000 Message-ID: <20190630151331.GA5775@ACM> References: <5a95c7556a411b5988bc46867dbb99fd@tonotdo.com> <16d1f96d86592f9e5511b61a678e2f81@tonotdo.com> <87y4a8m9b2.fsf@gnus.org> <0C474D0B-86AF-4030-B4B4-87E8CBEC4A67@iotcl.com> <87d1rilrxu.fsf@gnus.org> <9D6D35E4-B589-4E47-8939-7D682F93AE74@iotcl.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="158409"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.10.1 (2018-07-13) Cc: 11865@debbugs.gnu.org To: Lars Ingebrigtsen , Toon Claes , Toon Claes Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 30 17:14:24 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hhbX6-000f5P-Fg for geb-bug-gnu-emacs@m.gmane.org; Sun, 30 Jun 2019 17:14:24 +0200 Original-Received: from localhost ([::1]:45178 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hhbX5-0000gL-FM for geb-bug-gnu-emacs@m.gmane.org; Sun, 30 Jun 2019 11:14:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33739) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hhbWm-0000X8-Pa for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2019 11:14:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hhbWk-0004Av-SK for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2019 11:14:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33576) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hhbWk-0004AP-KM; Sun, 30 Jun 2019 11:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hhbWk-0005nu-F3; Sun, 30 Jun 2019 11:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bug-cc-mode@gnu.org Resent-Date: Sun, 30 Jun 2019 15:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11865 X-GNU-PR-Package: emacs,cc-mode X-GNU-PR-Keywords: patch Original-Received: via spool by 11865-submit@debbugs.gnu.org id=B11865.156190762322276 (code B ref 11865); Sun, 30 Jun 2019 15:14:02 +0000 Original-Received: (at 11865) by debbugs.gnu.org; 30 Jun 2019 15:13:43 +0000 Original-Received: from localhost ([127.0.0.1]:47120 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hhbWQ-0005nE-LX for submit@debbugs.gnu.org; Sun, 30 Jun 2019 11:13:42 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:44080 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1hhbWO-0005n4-9K for 11865@debbugs.gnu.org; Sun, 30 Jun 2019 11:13:41 -0400 Original-Received: (qmail 21840 invoked by uid 3782); 30 Jun 2019 15:13:33 -0000 Original-Received: from acm.muc.de (p2E5D5B10.dip0.t-ipconnect.de [46.93.91.16]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 30 Jun 2019 17:13:31 +0200 Original-Received: (qmail 23386 invoked by uid 1000); 30 Jun 2019 15:13:31 -0000 Content-Disposition: inline In-Reply-To: X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161889 Archived-At: Hello, Toon and Lars. On Thu, Jun 27, 2019 at 17:10:05 +0200, Lars Ingebrigtsen wrote: > Toon Claes writes: > > Hi Lars, > > Find the patch attached. > > The regexp is written to match: > > /** gtkdoc */ > > /** > > * gtkdoc > > */ > > And to not match: > > /*******/ > Alan, can you comment on this patch? It's about not recognising gtkdoc > comments in c++-mode: I've just had a close look at this, and it's the least controversial patch I've seen in years. There is simply nothing in it which raises the slightest question as to it's being a good thing. So I've committed the change. If I don't hear anything back within a few days, I'll assume the change successful and close the bug. > > * progmodes/cc-vars.el (c-doc-comment-style): Set gtkdoc the > > default for c++-mode. > > * progmodes/cc-fonts.el (gtkdoc-font-lock-keywords): Text inside > > GtkDoc comment can be on the same line as the comment start "/**". > > --- > > ChangeLog.2 | 9 +++++++++ > > lisp/progmodes/cc-fonts.el | 2 +- > > lisp/progmodes/cc-vars.el | 5 +++-- > > 3 files changed, 13 insertions(+), 3 deletions(-) > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no -- Alan Mackenzie (Nuremberg, Germany).