From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#25111: (Inaccurate documentation of inhibit-modification-hooks) Date: Tue, 25 Jun 2019 09:17:09 +0000 Message-ID: <20190625091709.GA5471@ACM> References: <20190525134407.GA10864@ACM> <87sgt28ut4.fsf@gmail.com> <20190527143109.GA5863@ACM> <20190603191549.GA4009@ACM> <85tvd6bhch.fsf@gmail.com> <20190604093241.GA5790@ACM> <838suhto2r.fsf@gnu.org> <83muirarzj.fsf@gnu.org> <20190624125249.GB4781@ACM> <8736jytxap.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="235174"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.10.1 (2018-07-13) Cc: 25111-done@debbugs.gnu.org, phillip.lord@russet.org.uk To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 25 11:18:47 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfhbD-000z4Q-De for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2019 11:18:47 +0200 Original-Received: from localhost ([::1]:57788 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfhbB-0001n9-OW for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2019 05:18:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40352) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfhab-0001mq-8v for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 05:18:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfhaY-0007EE-IC for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 05:18:08 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45089) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hfhaV-00076w-AF for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 05:18:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hfhaV-0004Sf-3x for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 05:18:03 -0400 Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jun 2019 09:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 25111 X-GNU-PR-Package: emacs Mail-Followup-To: 25111@debbugs.gnu.org, acm@muc.de, phillip.lord@russet.org.uk Original-Received: via spool by 25111-done@debbugs.gnu.org id=D25111.156145423717093 (code D ref 25111); Tue, 25 Jun 2019 09:18:02 +0000 Original-Received: (at 25111-done) by debbugs.gnu.org; 25 Jun 2019 09:17:17 +0000 Original-Received: from localhost ([127.0.0.1]:58633 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfhZl-0004Rc-8i for submit@debbugs.gnu.org; Tue, 25 Jun 2019 05:17:17 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:61220 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1hfhZj-0004RS-3d for 25111-done@debbugs.gnu.org; Tue, 25 Jun 2019 05:17:15 -0400 Original-Received: (qmail 13062 invoked by uid 3782); 25 Jun 2019 09:17:12 -0000 Original-Received: from acm.muc.de (p4FE15DD6.dip0.t-ipconnect.de [79.225.93.214]) by colin.muc.de (tmda-ofmipd) with ESMTP; Tue, 25 Jun 2019 11:17:09 +0200 Original-Received: (qmail 5478 invoked by uid 1000); 25 Jun 2019 09:17:09 -0000 Content-Disposition: inline In-Reply-To: <8736jytxap.fsf@gmail.com> X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161329 Archived-At: Hello, Noam. On Mon, Jun 24, 2019 at 18:48:14 -0400, Noam Postavsky wrote: > Alan Mackenzie writes: [ .... ] > > I think the changes as now formulated are right. Perhaps one or > > both of you might like to give the following patch a quick review. > > Thanks! > Minor formatting nitpick: > > +++ b/doc/lispref/display.texi > > @@ -1752,9 +1752,12 @@ Overlay Properties > > +When these functions are called, @code{inhibit-modification-hooks} is > > +bound to non-@code{nil}. If the functions modify the buffer, you > > +might want to bind @code{inhibit-modification-hooks} to nil, so as to > ^^^ > > +cause the change hooks to run for these modifications. However, doing > > +this may call your own change hook recursively, so be sure to prepare > > +for that. @xref{Change Hooks}. > > +++ b/doc/lispref/text.texi > > @@ -3639,6 +3642,13 @@ Special Properties > > beginning and end of the inserted text. The functions are called > > @emph{after} the actual insertion takes place. > > +When these functions are called, @code{inhibit-modification-hooks} is > > +bound to non-@code{nil}. If the functions modify the buffer, you > > +might want to bind @code{inhibit-modification-hooks} to nil, so as to > ^^^ > @code{nil} for both of these, right? Otherwise looks good to me. Whoops! Thanks for spotting these. I've fixed them and committed the changes. I'm closing the bug with this post. -- Alan Mackenzie (Nuremberg, Germany).