From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#36328: 26.2; Args out of range on search-and-replace of *.cc file Date: Sun, 23 Jun 2019 19:32:58 +0000 Message-ID: <20190623193258.GB4736@ACM> References: <20190622132549.84518.qmail@mail.muc.de> <20190622205033.GA9167@ACM> <20190623122207.GA4736@ACM> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="8281"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.10.1 (2018-07-13) Cc: 36328@debbugs.gnu.org To: Jayden Navarro Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 23 21:34:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hf8Fe-00020h-6B for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Jun 2019 21:34:10 +0200 Original-Received: from localhost ([::1]:46550 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hf8Fd-0000HR-6O for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Jun 2019 15:34:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40401) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hf8FX-0000H5-Al for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2019 15:34:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hf8FW-0001Vd-4y for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2019 15:34:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41125) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hf8FW-0001VN-0q for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2019 15:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hf8FV-0007DH-Sg for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2019 15:34:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Jun 2019 19:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36328 X-GNU-PR-Package: emacs Original-Received: via spool by 36328-submit@debbugs.gnu.org id=B36328.156131838827648 (code B ref 36328); Sun, 23 Jun 2019 19:34:01 +0000 Original-Received: (at 36328) by debbugs.gnu.org; 23 Jun 2019 19:33:08 +0000 Original-Received: from localhost ([127.0.0.1]:54669 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hf8Ee-0007Br-AR for submit@debbugs.gnu.org; Sun, 23 Jun 2019 15:33:08 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:63247 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1hf8Ec-0007Bg-5l for 36328@debbugs.gnu.org; Sun, 23 Jun 2019 15:33:07 -0400 Original-Received: (qmail 52112 invoked by uid 3782); 23 Jun 2019 19:33:01 -0000 Original-Received: from acm.muc.de (p2E5D5B98.dip0.t-ipconnect.de [46.93.91.152]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 23 Jun 2019 21:33:00 +0200 Original-Received: (qmail 23591 invoked by uid 1000); 23 Jun 2019 19:32:58 -0000 Content-Disposition: inline In-Reply-To: X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161168 Archived-At: Hello, Jayden. On Sun, Jun 23, 2019 at 09:14:19 -0700, Jayden Navarro wrote: > Hi Alan, > Thank you for looking into this! > Until this is officially fixed I've come up with the following workaround, > going off of the details you provided: > I created a "replace_fixed.el" file in "~/.emacs.d/lisp/" that is > replace.el taken from > https://raw.githubusercontent.com/emacs-mirror/emacs/emacs-26/lisp/replace.el > with > the following diff: > diff --git a/replace.el b/replace_fixed.el > index 08feb8e..8280fdd 100644 > --- a/replace.el > +++ b/replace_fixed.el > @@ -2227,7 +2227,7 @@ It is called with three arguments, as if it were > (isearch-forward (not backward)) > (isearch-other-end match-beg) > (isearch-error nil)) > - (isearch-lazy-highlight-new-loop range-beg range-end)))) > + (save-match-data (isearch-lazy-highlight-new-loop range-beg > range-end))))) > (defun replace-dehighlight () > (when replace-overlay > Then I added the following to my "~/.emacs", restarted my emacs server, and > the issue was gone!: > (load-library "~/.emacs.d/lisp/replace_fixed.el") > This probably isn't the proper fix, but just thought I'd share in case > anyone else is experiencing this and wanted a temporary workaround. Excellent! To be honest, I was thinking of sending just that workaround to you as a temporary patch, but it seems I didn't need to. :-) That might well be the fix we end up putting into Emacs, but it might not be. Sorry we're so slow, here. Have a great afternoon! I'll be off to bed, soon. Thanks for taking the trouble to report this bug. > Best, > Jayden -- Alan Mackenzie (Nuremberg, Germany).