From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#36332: non-GUI build broken on macOS Date: Sat, 22 Jun 2019 21:19:43 +0100 Message-ID: <20190622201943.GD57900@breton.holly.idiocy.org> References: <42f1a413-c271-1f6d-07c0-aea33a7bbda9@cs.ucla.edu> <20190622193819.GB57900@breton.holly.idiocy.org> <40c3dd4f-3866-044e-0607-92bc493b0a9c@cs.ucla.edu> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="envbJBWh7q8WU6mo" Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="193837"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.12.0 (2019-05-25) Cc: 36332@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 22 22:20:20 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hemUl-000oGu-SC for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Jun 2019 22:20:20 +0200 Original-Received: from localhost ([::1]:42278 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hemUk-0000c3-Sz for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Jun 2019 16:20:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38177) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hemUY-0000ZN-BF for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2019 16:20:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hemUW-0004Sv-G5 for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2019 16:20:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39004) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hemUU-0004Rh-Bm for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2019 16:20:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hemUU-0003sJ-4r for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2019 16:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Jun 2019 20:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36332 X-GNU-PR-Package: emacs Original-Received: via spool by 36332-submit@debbugs.gnu.org id=B36332.156123479614878 (code B ref 36332); Sat, 22 Jun 2019 20:20:02 +0000 Original-Received: (at 36332) by debbugs.gnu.org; 22 Jun 2019 20:19:56 +0000 Original-Received: from localhost ([127.0.0.1]:52548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hemUO-0003ru-4F for submit@debbugs.gnu.org; Sat, 22 Jun 2019 16:19:56 -0400 Original-Received: from mail-wm1-f50.google.com ([209.85.128.50]:56310) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hemUK-0003rb-AJ for 36332@debbugs.gnu.org; Sat, 22 Jun 2019 16:19:54 -0400 Original-Received: by mail-wm1-f50.google.com with SMTP id a15so9206917wmj.5 for <36332@debbugs.gnu.org>; Sat, 22 Jun 2019 13:19:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=OFGys1WgaxZR6ZFc9EazqHXpFlSvjyhqlT2Btah0JuE=; b=ZuycB7KtvcRH/8dB8nuo5wxXj60O5zFp1hfOCpsWYBFa+5fKOTVAnASHTT80j8nyjP TikiM/tZxwiU6ZOWrxSm1MVdRzutkkGtrtQV7+aJXGOKD1sPQ06xexXueDUf1C5cOqWx 6C5YBi9+0eZrpZj3DE8jjcIFenfzfaT7O6xMdLycB3OS/thZ4OY4hRMnCinZd1rmu3QF iZjxWFIrQfbOQYXLMA4YFZG6grR5VnUUqy5yL3kBipRKAWA/HQigXXwLN1n6ovpJD2Gg ymIyGJFU3qexrLU1ODs0IXSRcCaaZgfl9mEzbCxg56FtcVsnUFaz65tM0ZhfDq1zXJHd FUkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=OFGys1WgaxZR6ZFc9EazqHXpFlSvjyhqlT2Btah0JuE=; b=hzJTUo5xO9CCneSwFdayvTVikh54BTI5VCK8rjBRTS9xPyDibNDH63Ip+7KKxe2c0v r1bKJkbeo0TuKS9j4bat7WdCCEydVwpKNmfyPf/RCikKmYXGJj2CkVePkLt4XVJ7YpUD 49EO0y07UiuWspZPyW2hCySaOpWADPzitWRMA6pnvNBDhXEKI1+GGF/by8SwZWPPgzB9 o9bLL+BOwg+veCPdcoK2l4gQn6EYCMiI6E1l8pdSrQmkk/Ag+Su6iiNDGRRoCPnoPrLK +EFg0FEpCjWAGPGN06bbPvbqTuizg/sl3K0XX3LCtYEs1elalSkpX36kHWYAYuKQhUQ9 wsPQ== X-Gm-Message-State: APjAAAWv0vlvLuTGAwOSKsH/Ok3RK60IlG2Ty3kD9eQm2fWVaf2xeWhG MMCONUo4AjgNHkYHTko7I8E= X-Google-Smtp-Source: APXvYqxYyWOyRJDvhQcO45K5JxvWgTUJu9trQY4jdKM4cXgTln3e3QptWxDw68Bf9JEBGdgrDysnlw== X-Received: by 2002:a1c:7c11:: with SMTP id x17mr8230026wmc.22.1561234786150; Sat, 22 Jun 2019 13:19:46 -0700 (PDT) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-687e-3b34-1271-b994.holly.idiocy.org. [2001:8b0:3f8:8129:687e:3b34:1271:b994]) by smtp.gmail.com with ESMTPSA id p26sm15254857wrp.58.2019.06.22.13.19.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 22 Jun 2019 13:19:45 -0700 (PDT) Content-Disposition: inline In-Reply-To: <40c3dd4f-3866-044e-0607-92bc493b0a9c@cs.ucla.edu> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161052 Archived-At: --envbJBWh7q8WU6mo Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Sat, Jun 22, 2019 at 12:44:40PM -0700, Paul Eggert wrote: > Alan Third wrote: > > It is. What doesn’t work is defining HAVE_NS but not setting the > > requirements for an NS build. > > > > './configure --without-ns' works fine as is. > > OK, thanks, in that case I guess that the problem is only that after one > does 'make extraclean' then one cannot build with the current master without > manually specifying './configure --without-ns' at some point. This makes the > bug less urgent to fix. I haven’t been following the clean build chat on emacs-devel, does make extraclean delete macuvs.h? We could try returning a useful message at configure time instead of just failing during the build. Do you think the attached patch is OK? I’d rather not just build headless as the usual build process on the Mac is to do ’make; make install’, which just builds the NS app directory. If we were to configure headless then run that same command it would attempt to install a headless Emacs to /usr or somewhere. It would probably fail due to permissions, but I’d prefer to avoid any confusion in the first place. -- Alan Third --envbJBWh7q8WU6mo Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0001-Provide-a-useful-message-if-macuvs.h-doesn-t-exist-b.patch" >From 8ece63cd67d158b0349dda83c303e1f02a947f40 Mon Sep 17 00:00:00 2001 From: Alan Third Date: Sat, 22 Jun 2019 21:13:50 +0100 Subject: [PATCH] Provide a useful message if macuvs.h doesn't exist (bug#36332) * configure.ac (with-ns): Error out if attempting to configure with Cocoa but macuvs.h doesn't exist. --- configure.ac | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 0507f58054..d7efe467fa 100644 --- a/configure.ac +++ b/configure.ac @@ -1963,7 +1963,12 @@ AC_DEFUN # macfont.o requires macuvs.h which is absent after 'make extraclean', # so avoid NS_IMPL_COCOA if macuvs.h is absent. # Even a headless Emacs can build macuvs.h, so this should let you bootstrap. - if test "${opsys}" = darwin && test -f "$srcdir/src/macuvs.h"; then + if test "${opsys}" = darwin; then + if test \! -f "$srcdir/src/macuvs.h"; then + AC_MSG_ERROR([Cocoa build requested, however macuvs.h is missing. +Rerun configure with the option '--without-ns' and run make before +configuring '--with-ns'.]) + fi NS_IMPL_COCOA=yes ns_appdir=`pwd`/nextstep/Emacs.app ns_appbindir=${ns_appdir}/Contents/MacOS -- 2.21.0 --envbJBWh7q8WU6mo--