From: Alan Mackenzie <acm@muc.de>
To: 36136@debbugs.gnu.org
Subject: bug#36136: syntax-ppss fails to invalidate its cache on changes to syntax-table text properties
Date: Sat, 8 Jun 2019 13:17:24 +0000 [thread overview]
Message-ID: <20190608131724.GA4643@ACM> (raw)
Hello, Emacs.
The syntax-ppss cache is not invalidated when syntax-table text
properties are set or cleared. This is because the invalidation
function, syntax-ppss-flush-cache is invoked only as a before-change
function, but typical (?all) syntax-table property changes happen when
before-change-functions is inactive.
This is a bug.
In my debugging of a CC Mode scenario, a buffer change causes a
syntax-table text property change at an earlier part of the buffer. This
is to do with the change making previously non-matching C++ raw string
identifiers match up. Font lock follows the syntax-ppss state, which
spuriously records that the end part of the buffer is still in a string.
Hence the non-string part of the buffer is still fontified with
font-lock-string-face.
Suggested fix: the functions set_properties, add_properties,
remove_properties in textprop.c should check for changes to,
specifically, syntax-table properties. When these changes are detected,
a hook called something like syntax-table-props-change-alert-hook should
be called (with some appropriate position parameters, tbd).
syntax-ppss-flush-cache will be added to this hook.
--
Alan Mackenzie (Nuremberg, Germany).
next reply other threads:[~2019-06-08 13:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-08 13:17 Alan Mackenzie [this message]
2019-06-08 20:36 ` bug#36136: [PATCH]: Re: bug#36136: syntax-ppss fails to invalidate its cache on changes to syntax-table text properties Alan Mackenzie
2019-06-09 5:56 ` Eli Zaretskii
2019-06-09 14:52 ` Alan Mackenzie
2019-06-09 18:39 ` Alan Mackenzie
2019-06-12 8:37 ` Stefan Monnier
2019-06-12 10:15 ` Alan Mackenzie
2019-06-12 10:54 ` Stefan Monnier
2019-06-13 12:21 ` Alan Mackenzie
2019-06-13 21:31 ` Stefan Monnier
[not found] ` <handler.36136.B.155999987226722.ack@debbugs.gnu.org>
2019-08-24 19:35 ` bug#36136: Acknowledgement (syntax-ppss fails to invalidate its cache on changes to syntax-table text properties) Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190608131724.GA4643@ACM \
--to=acm@muc.de \
--cc=36136@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).