From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#36115: 27.0.50; Git master branch compile error with --with-cairo configure flag Date: Fri, 7 Jun 2019 19:18:22 +0100 Message-ID: <20190607181822.GA48675@breton.holly.idiocy.org> References: <874l5138ip.fsf@gmail.com> <20190607164826.GA48250@breton.holly.idiocy.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="165930"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mutt/1.12.0 (2019-05-25) Cc: Eugene Mah , 36115@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 07 22:03:37 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hZL5K-000gq7-OU for geb-bug-gnu-emacs@m.gmane.org; Fri, 07 Jun 2019 22:03:34 +0200 Original-Received: from localhost ([::1]:52568 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZL50-0004Hq-Oe for geb-bug-gnu-emacs@m.gmane.org; Fri, 07 Jun 2019 16:03:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48044) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZJSE-0003Y7-30 for bug-gnu-emacs@gnu.org; Fri, 07 Jun 2019 14:19:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hZJSB-0007gc-DV for bug-gnu-emacs@gnu.org; Fri, 07 Jun 2019 14:19:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38850) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hZJSA-0007f4-2b for bug-gnu-emacs@gnu.org; Fri, 07 Jun 2019 14:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hZJS9-0002nB-Na for bug-gnu-emacs@gnu.org; Fri, 07 Jun 2019 14:19:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 Jun 2019 18:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36115 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 36115-submit@debbugs.gnu.org id=B36115.155993151610701 (code B ref 36115); Fri, 07 Jun 2019 18:19:01 +0000 Original-Received: (at 36115) by debbugs.gnu.org; 7 Jun 2019 18:18:36 +0000 Original-Received: from localhost ([127.0.0.1]:52394 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZJRi-0002mW-6K for submit@debbugs.gnu.org; Fri, 07 Jun 2019 14:18:35 -0400 Original-Received: from mail-wm1-f68.google.com ([209.85.128.68]:51219) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZJRg-0002mI-2H for 36115@debbugs.gnu.org; Fri, 07 Jun 2019 14:18:32 -0400 Original-Received: by mail-wm1-f68.google.com with SMTP id f10so2970103wmb.1 for <36115@debbugs.gnu.org>; Fri, 07 Jun 2019 11:18:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=hiWp3PMMmDm0/Ud9ljZDbmeHFJAwznG9WSh9sGucCnE=; b=Z4Nhtvf6hkYfRDR4dvBfyDCurg06103JT/czdbmWilgzlLdPWtvQEdA9ToWwrNLq5f kX9B3GmpNA2iaEsXfBT4k/N4NuUp/mQiq+3++kKbJPUTknqnH7H5bSrYYokFV+CyqxfN 38RUxYe8J1X0NuBTakXdsGDmb/iBu+4C/L/J0cto3BRcsv/3QKrY3BF6YLt/t6UQZMrA PRKiKEtnBvjNG4/8mM5LFBQBTlEEkzK4WTi96kpj7mROLe0dS2q6BNRkw72wFNsCWNxw RlBfHsX9cUIToA6WZYHrKugm+T7jgdHm/zKiTRX4jfneSkCaU0zlsJBQG98Gp63QQxbR UoyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=hiWp3PMMmDm0/Ud9ljZDbmeHFJAwznG9WSh9sGucCnE=; b=ciD2sEMa6suFx4GTQDPfvWQjVZgIRN1ZmWRe5IosuP1ZARmtEZ6MX6ePR5BMTpghap aHWE1xd40GGtvyoV8FJcVs4GsMCd9X4fccm8vZCQ07U7Dyzb4bzpiXqAOEs7KliQEluz +lb9LMqII2cvfPRW4X+5o2cJxSvjJU8C2aVGLRI4nZ7z7BA/60oFuvgYGXMJ3PMuW8dd ShujsqSIgf+ygwIeA2Y75wAFO8kdmBnwjKyKOeREasOO1hF1PdKkl7CNf9ZAbH41eIiM F/gXtSXdVNqWDPTOHA8nLhfWh5bojFjpqj2U24awg9oFYt0AcPTY7MW9NSGZK0SQI3of WT9Q== X-Gm-Message-State: APjAAAX08RQnBjpGP6x/DLfriTVMuMZpTCxy/lC8ZfflGyEKgjf55LIS UIcWhcHICSxLGb1cnyt23A0= X-Google-Smtp-Source: APXvYqxAh93Bc9u0dYo1xb4tNETBxIPkZNrA7kL8kiVh3SBXf1jwaBIoc2iFAIxdEK/ILrOAzUS8gg== X-Received: by 2002:a1c:21c4:: with SMTP id h187mr4705780wmh.27.1559931505529; Fri, 07 Jun 2019 11:18:25 -0700 (PDT) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-3545-cacb-7e82-59fb.holly.idiocy.org. [2001:8b0:3f8:8129:3545:cacb:7e82:59fb]) by smtp.gmail.com with ESMTPSA id u205sm2436435wmu.47.2019.06.07.11.18.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Jun 2019 11:18:24 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20190607164826.GA48250@breton.holly.idiocy.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160222 Archived-At: On Fri, Jun 07, 2019 at 05:48:26PM +0100, Alan Third wrote: > On Fri, Jun 07, 2019 at 08:05:50AM -0400, Noam Postavsky wrote: > > tags 36115 fixed > > close 36115 > > quit > > > > Eugene Mah writes: > > > > > When compiling the latest git master branch, the following error occurs: > > > > > > image.c: In function ‘image_set_crop’: > > > image.c:2046:16: error: ‘width’ undeclared (first use in this function); > > > did you mean ‘Qwidth’? > > > 2046 | img->width = width; > > > > > When the --with-cairo flag is omitted, master branch compiles without > > > issue. > > > > > > The error occurs in the image_set_crop() function, so perhaps related to > > > this commit > > > http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=610fb73ab6d7a22b722f523d6ebc4aa8fa1db7c9 > > > > I believe this was fixed yesterday. > > > > c8123b45f7 2019-06-06T09:07:36-04:00 "Restore height and with from that were accidentally removed" > > https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=c8123b45f7b9b660db2040ee85c3a2fd260d3f16 > > I hadn’t noticed this. I suspect a merge from master has transposed > part of image_set_size into image_set_crop in my local branch and I > failed to see it before pushing. > > I’ll sort this out asap. Never mind, Yamamoto Mitsuharu got there before me: https://git.savannah.gnu.org/cgit/emacs.git/commit/src/image.c?id=3a1f92d09bbcb4dbd2a2ebe1bee0e564e51c4615 -- Alan Third