From: Alan Mackenzie <acm@muc.de>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 35254@debbugs.gnu.org
Subject: bug#35254: 27.0.50; cc-mode/electric-pair-mode/electric-layout-mode: bad trailing whitespace behavior in cc-mode
Date: Tue, 14 May 2019 09:34:15 +0000 [thread overview]
Message-ID: <20190514093415.GC4231__8338.95857665397$1557826549$gmane$org@ACM> (raw)
In-Reply-To: <jwvimue9bzj.fsf-monnier+emacs@gnu.org>
Hello, Stefan.
On Mon, May 13, 2019 at 19:32:49 -0400, Stefan Monnier wrote:
> >> Electric indent mode's post-self-insert hook entry has 3 effects:
> >> 1. Indent the previous line.
> >> 2. Remove trailing whitespace from the previous line.
> >> 3. Indent the current line (when at beginning of line).
> Note that `newline` itself already does some subset of 2 (before running
> electric-indent's post-self-insert hook).
Speaking of `newline', there's a strange regexp around this part:
;; If the newline leaves the previous line blank, and we
;; have a left margin, delete that from the blank line.
(save-excursion
(goto-char beforepos)
(beginning-of-line)
(and (looking-at "[ \t]$") <=========================
(> (current-left-margin) 0)
(delete-region (point)
(line-end-position))))
It's trying to match a single WS character. Shouldn't this, perhaps, be
"[ \t]+$"?
[ .... ]
> Stefan
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2019-05-14 9:34 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-13 6:32 bug#35254: 27.0.50; cc-mode/electric-pair-mode/electric-layout-mode: bad trailing whitespace behavior in cc-mode Dima Kogan
2019-05-11 3:12 ` Noam Postavsky
2019-05-11 12:05 ` Alan Mackenzie
[not found] ` <20190511120524.GA15991@ACM>
2019-05-11 14:06 ` Noam Postavsky
2019-05-11 16:19 ` Alan Mackenzie
2019-05-11 19:34 ` Basil L. Contovounesios
2019-05-12 16:14 ` Alan Mackenzie
2019-05-12 21:45 ` Basil L. Contovounesios
2019-05-13 10:14 ` Alan Mackenzie
[not found] ` <20190513101448.GA5525@ACM>
2019-05-13 12:49 ` Basil L. Contovounesios
2019-05-12 15:12 ` Alan Mackenzie
2019-05-12 18:42 ` Noam Postavsky
2019-05-13 19:53 ` Alan Mackenzie
[not found] ` <20190513195323.GB5525@ACM>
2019-05-13 22:39 ` João Távora
2019-05-13 23:38 ` Noam Postavsky
2019-05-14 1:20 ` João Távora
2019-05-14 1:28 ` Stefan Monnier
2019-05-14 1:56 ` Noam Postavsky
2019-05-14 8:38 ` Alan Mackenzie
2019-05-13 23:32 ` Stefan Monnier
[not found] ` <jwvimue9bzj.fsf-monnier+emacs@gnu.org>
2019-05-13 23:45 ` Noam Postavsky
2019-05-14 1:26 ` Stefan Monnier
2019-05-14 9:27 ` Alan Mackenzie
2019-05-14 9:34 ` Alan Mackenzie [this message]
[not found] ` <20190514092735.GB4231@ACM>
2019-05-14 10:34 ` João Távora
2019-05-15 10:03 ` Alan Mackenzie
2019-05-15 11:27 ` João Távora
2019-05-15 13:19 ` Stefan Monnier
2019-05-15 13:55 ` João Távora
2019-05-15 14:03 ` João Távora
2019-07-01 12:24 ` João Távora
2019-07-01 13:34 ` Alan Mackenzie
[not found] ` <20190701133427.GA23312@ACM>
2019-07-06 16:24 ` Noam Postavsky
2019-07-06 22:24 ` João Távora
2019-07-06 22:50 ` Noam Postavsky
2019-07-06 22:33 ` João Távora
[not found] ` <20190514093415.GC4231@ACM>
2019-05-14 15:38 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20190514093415.GC4231__8338.95857665397$1557826549$gmane$org@ACM' \
--to=acm@muc.de \
--cc=35254@debbugs.gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).