From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Kahn Gillmor Newsgroups: gmane.emacs.bugs,gmane.mail.notmuch.general Subject: bug#35370: [PATCH] emacs: drop use of message-default-charset Date: Mon, 22 Apr 2019 16:51:16 -0400 Message-ID: <20190422205116.10694-1-dkg@fifthhorseman.net> References: <831s1u6ofj.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="25990"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35370@debbugs.gnu.org To: Notmuch Mail Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 22 22:52:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hIfvD-0006ah-Le for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Apr 2019 22:52:15 +0200 Original-Received: from localhost ([127.0.0.1]:44137 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIfvC-0007Px-Mv for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Apr 2019 16:52:14 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42160) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIfv2-0007O5-JA for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2019 16:52:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hIfv1-0007Vf-AZ for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2019 16:52:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38174) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hIfv0-0007UC-GF for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2019 16:52:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hIfv0-00061Y-8Q for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2019 16:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Kahn Gillmor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Apr 2019 20:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35370 X-GNU-PR-Package: emacs Original-Received: via spool by 35370-submit@debbugs.gnu.org id=B35370.155596629423116 (code B ref 35370); Mon, 22 Apr 2019 20:52:02 +0000 Original-Received: (at 35370) by debbugs.gnu.org; 22 Apr 2019 20:51:34 +0000 Original-Received: from localhost ([127.0.0.1]:51718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIfuX-00060m-Ju for submit@debbugs.gnu.org; Mon, 22 Apr 2019 16:51:33 -0400 Original-Received: from che.mayfirst.org ([162.247.75.118]:37049) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIfuT-00060b-Qp for 35370@debbugs.gnu.org; Mon, 22 Apr 2019 16:51:33 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019; t=1555966287; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding : from; bh=4cD7JryOmb71WTihr1wmk9WfpKLbU+qteRBSBl8ML2A=; b=VGp4nf8mqj2gqe35opnX7656r0cbxbNMoWiyK2stPOHR6ccQsBfLWuSq ydy8WDJ8ICqKv1uzTwgXUh8ZVB7YBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019rsa; t=1555966287; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding : from; bh=4cD7JryOmb71WTihr1wmk9WfpKLbU+qteRBSBl8ML2A=; b=fRFdRKG8JouJY3VvYaZXGoSaxwngCIciUbmNnuuPOIi8VywX4UwXXuDv BqlS2Kb9M5PTSsuVGeI9w2A3nJlBgloUvRNkA7rbyX2sBw0CyIhARa/kBD 588PT94+6YGnMUqrPqr+L08cZstJctEqRD6siaowCI57axZkDR9IpDLMsN utMkO9w+5xoJmk2pdB27z0sedju8EUIOLoiuz1N7By8h3ZAqkyogIutCtH 78XFcCOY5PvfQuk0bhY7RrFyHaIspUvbahh1azcbIcLZtqMnF0PBOsidun AjObSKlheR+7V8nZXXoUp1kaegTio6MIIH+5UNLymQhSZBmVWvL7Mg== Original-Received: from fifthhorseman.net (unknown [38.109.115.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by che.mayfirst.org (Postfix) with ESMTPSA id 625BBF99D; Mon, 22 Apr 2019 16:51:23 -0400 (EDT) Original-Received: by fifthhorseman.net (Postfix, from userid 1000) id B89CC20103; Mon, 22 Apr 2019 16:51:16 -0400 (EDT) X-Mailer: git-send-email 2.20.1 In-Reply-To: <831s1u6ofj.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158080 gmane.mail.notmuch.general:27817 Archived-At: Apparently, message-default-charset is deprecated, which causes the following warning messages during the build: In notmuch-maildir-setup-message-for-saving: emacs/notmuch-maildir-fcc.el:172:31:Warning: ‘message-default-charset’ is an obsolete variable (as of 26.1); The default charset comes from the language environment In discussion with emacs upstream over on https://debbugs.gnu.org/35370, it appears that we can just drop this entirely and things should still work with emacs 25. --- emacs/notmuch-maildir-fcc.el | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/emacs/notmuch-maildir-fcc.el b/emacs/notmuch-maildir-fcc.el index 1551e8b6..ae56bacd 100644 --- a/emacs/notmuch-maildir-fcc.el +++ b/emacs/notmuch-maildir-fcc.el @@ -169,8 +169,7 @@ This is taken from the function message-do-fcc." (message-encode-message-body) (save-restriction (message-narrow-to-headers) - (let ((mail-parse-charset message-default-charset)) - (mail-encode-encoded-word-buffer))) + (mail-encode-encoded-word-buffer)) (goto-char (point-min)) (when (re-search-forward (concat "^" (regexp-quote mail-header-separator) "$") -- 2.20.1