From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Khaled Hosny Newsgroups: gmane.emacs.bugs Subject: bug#33729: 27.0.50; Partial glyphs not rendered for Gujarati with Harfbuzz enabled (renders fine using m17n) Date: Sat, 5 Jan 2019 23:04:20 +0200 Message-ID: <20190105210420.GA31354@macbook.localdomain> References: <83bm5d9wsc.fsf@gnu.org> <20181222205948.GF2244@macbook.localdomain> <838t0gapcj.fsf@gnu.org> <20181223135109.GA6568@macbook.localdomain> <83va3k8c79.fsf@gnu.org> <20181224020847.GC6568@macbook.localdomain> <83lg4e9a7q.fsf@gnu.org> <20181224173723.GH6568@macbook.localdomain> <838t085qx8.fsf@gnu.org> <20190105205314.GA28761@macbook.localdomain> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Trace: blaine.gmane.org 1546722187 19426 195.159.176.226 (5 Jan 2019 21:03:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 5 Jan 2019 21:03:07 +0000 (UTC) User-Agent: Mutt/1.11.1 (2018-12-01) Cc: behdad@behdad.org, far.nasiri.m@gmail.com, 33729@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 05 22:03:03 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from listsout.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gft5y-0004uR-Kg for geb-bug-gnu-emacs@m.gmane.org; Sat, 05 Jan 2019 22:03:02 +0100 Original-Received: from localhost ([127.0.0.1]:59664 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gft84-0001iu-U8 for geb-bug-gnu-emacs@m.gmane.org; Sat, 05 Jan 2019 16:05:12 -0500 Original-Received: from eggsout.gnu.org ([209.51.188.92]:49386 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gft7y-0001ib-25 for bug-gnu-emacs@gnu.org; Sat, 05 Jan 2019 16:05:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gft7u-00047N-9g for bug-gnu-emacs@gnu.org; Sat, 05 Jan 2019 16:05:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:56616) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gft7u-000479-5B for bug-gnu-emacs@gnu.org; Sat, 05 Jan 2019 16:05:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gft7t-00029Q-Lz for bug-gnu-emacs@gnu.org; Sat, 05 Jan 2019 16:05:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Khaled Hosny Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Jan 2019 21:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33729 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33729-submit@debbugs.gnu.org id=B33729.15467222728224 (code B ref 33729); Sat, 05 Jan 2019 21:05:01 +0000 Original-Received: (at 33729) by debbugs.gnu.org; 5 Jan 2019 21:04:32 +0000 Original-Received: from localhost ([127.0.0.1]:48088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gft7Q-00028a-GU for submit@debbugs.gnu.org; Sat, 05 Jan 2019 16:04:32 -0500 Original-Received: from mail-ed1-f46.google.com ([209.85.208.46]:40023) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gft7O-00028M-PF for 33729@debbugs.gnu.org; Sat, 05 Jan 2019 16:04:31 -0500 Original-Received: by mail-ed1-f46.google.com with SMTP id g22so34593160edr.7 for <33729@debbugs.gnu.org>; Sat, 05 Jan 2019 13:04:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=uQBWwMNoXQXaUx2Yo2mSWIgduhZeZIo/BlHYfo7UUHs=; b=X0JTy63ZEhc+ol9dQNh0N98cZ1PGSc8AnqnaPZ0OQST5lMwqrluzyFokyfswx5t40P CE/zOKfoeYHLjIYwVtjYM3QQR0Lb1qVLX6UVM7wlWAIz/c/0eT/bsnjqdTtLU1n4QcUc gNeUQqsutK2zqv5mkbwwn1spyu7tjIT2EOsbjq9ibDYdlkdiUtRyhix/uEvIc+7BpzWh YMTu+Rlp0dxrljgmJq/RaxM06gfj6MB8igP6p0FwmENlUhyQ/Dmd7DkNQIoPjHd5442w eXihJMs/4tzwRskm1lItY9qX6p+ACAly0EdMUK8Kg1tB40xZ1sXOWy8JPecCcndlfuzX gdEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=uQBWwMNoXQXaUx2Yo2mSWIgduhZeZIo/BlHYfo7UUHs=; b=GEFbCUUHPvGlpdJTYdF7nX9msKYVAs3Wr/SrWX4pxyc1zCkD39iEmZajLJ7jfTypxZ zez4FhF/YFnkc43rFiqOGVZNj5wA+DpU3raMP8FJ5/fGtsVsHztX2mG4St5aJFplQJt9 XsOMc+PsL606y8DyXWPqJOQEVb46K6/pDjiGfNDjgawj4VO8oOj3nwxvGkcq2YfYSWue buf7Pn+wGmbSl1pl/t8TN9PTLkPIEhExYBeX+ux4PfoLHTnsxTROpmK+gIuIoYl/x9z1 30AO96b6ziOizyYyKceAM2sovMP3A2bgZ5joOoerPC8hrb2FNfVPuB9tGGvFJHuhEM/d +Pww== X-Gm-Message-State: AA+aEWZJret9jXoWhmy83ESnl9JMu+3Z5yFu6gBdypxbk24xkiYkrt19 l280pGDTNisysEh67MdxaD8= X-Google-Smtp-Source: AFSGD/WiVnPPvmZz2xj0uw0DCoVmVI88vlAh+L9uG30s2MLNHhjtCbzbtdXj7PulIZQOHC0W3OBVZA== X-Received: by 2002:a50:880d:: with SMTP id b13mr49717222edb.68.1546722264968; Sat, 05 Jan 2019 13:04:24 -0800 (PST) Original-Received: from macbook.localdomain ([41.237.67.158]) by smtp.gmail.com with ESMTPSA id c23-v6sm16886587ejb.62.2019.01.05.13.04.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 05 Jan 2019 13:04:24 -0800 (PST) Content-Disposition: inline In-Reply-To: <20190105205314.GA28761@macbook.localdomain> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:154171 Archived-At: On Sat, Jan 05, 2019 at 10:53:14PM +0200, Khaled Hosny wrote: > On Sat, Dec 29, 2018 at 04:49:23PM +0200, Eli Zaretskii wrote: > > > Date: Mon, 24 Dec 2018 19:37:23 +0200 > > > From: Khaled Hosny > > > Cc: rgm@gnu.org, far.nasiri.m@gmail.com, behdad@behdad.org, > > > 33729@debbugs.gnu.org, kaushal.modi@gmail.com > > > > > > > > We need to know, for a given lgstring we are shaping: > > > > > * Its direction (from applying bidi algorithm). Each lgstring we are > > > > > shaping must be of a single direction. > > > > > > > > Communicating this to ftfont_shape_by_hb will need changes in a couple > > > > of interfaces (the existing shaping engines didn't need this > > > > information). I will work on this soon. > > > > > > Great. > > > > Done. Please test. I made sure it compiles, but I couldn't actually > > test the results, as I don't have access to a GNU/Linux system with > > GUI display. So it could be that I misunderstood the Harfbuzz APIs, > > as I was essentially flying blind, guided only by the Harfbuzz docs. > > It seems to work, but still not quite right. You seem to be passing the > paragraph direction, but what HarfBuzz needs is resolved direction of > the text (i.e. the bidi embedding level of the run). In other words, if > Emacs is going to draw this text from right to left, then HarfBuzz must > shape it in right to left direction. Both should use the same direction > all the time and HarfBuzz direction guessing should never be used (i.e. > always pass to it an explicit direction). I pushed a couple of commits that does this based on my limited understanding of Emacs code, please check. Regards, Khaled