From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Khaled Hosny Newsgroups: gmane.emacs.bugs Subject: bug#33729: 27.0.50; Partial glyphs not rendered for Gujarati with Harfbuzz enabled (renders fine using m17n) Date: Sat, 5 Jan 2019 22:53:14 +0200 Message-ID: <20190105205314.GA28761@macbook.localdomain> References: <20181222154945.GE2244@macbook.localdomain> <83bm5d9wsc.fsf@gnu.org> <20181222205948.GF2244@macbook.localdomain> <838t0gapcj.fsf@gnu.org> <20181223135109.GA6568@macbook.localdomain> <83va3k8c79.fsf@gnu.org> <20181224020847.GC6568@macbook.localdomain> <83lg4e9a7q.fsf@gnu.org> <20181224173723.GH6568@macbook.localdomain> <838t085qx8.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Trace: blaine.gmane.org 1546721529 32713 195.159.176.226 (5 Jan 2019 20:52:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 5 Jan 2019 20:52:09 +0000 (UTC) User-Agent: Mutt/1.11.1 (2018-12-01) Cc: behdad@behdad.org, far.nasiri.m@gmail.com, 33729@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 05 21:52:05 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gfsvM-0008M1-0p for geb-bug-gnu-emacs@m.gmane.org; Sat, 05 Jan 2019 21:52:04 +0100 Original-Received: from localhost ([127.0.0.1]:56330 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gfsxS-0007GI-Fc for geb-bug-gnu-emacs@m.gmane.org; Sat, 05 Jan 2019 15:54:14 -0500 Original-Received: from eggsout.gnu.org ([209.51.188.92]:44703 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gfsxK-0007G9-AQ for bug-gnu-emacs@gnu.org; Sat, 05 Jan 2019 15:54:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gfsxH-0002C4-4b for bug-gnu-emacs@gnu.org; Sat, 05 Jan 2019 15:54:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54119) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gfsxG-0002BY-9M for bug-gnu-emacs@gnu.org; Sat, 05 Jan 2019 15:54:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gfsxG-0001rN-6I for bug-gnu-emacs@gnu.org; Sat, 05 Jan 2019 15:54:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Khaled Hosny Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Jan 2019 20:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33729 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33729-submit@debbugs.gnu.org id=B33729.15467216077098 (code B ref 33729); Sat, 05 Jan 2019 20:54:02 +0000 Original-Received: (at 33729) by debbugs.gnu.org; 5 Jan 2019 20:53:27 +0000 Original-Received: from localhost ([127.0.0.1]:48085 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gfswh-0001qQ-D8 for submit@debbugs.gnu.org; Sat, 05 Jan 2019 15:53:27 -0500 Original-Received: from mail-ed1-f51.google.com ([209.85.208.51]:34022) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gfswe-0001qB-QB for 33729@debbugs.gnu.org; Sat, 05 Jan 2019 15:53:25 -0500 Original-Received: by mail-ed1-f51.google.com with SMTP id b3so34717762ede.1 for <33729@debbugs.gnu.org>; Sat, 05 Jan 2019 12:53:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=1mAV/ZoaEMJ5L5q3DxakmcuPtg7cHPy33uxHU0PLEqM=; b=HmkiNK8oLQtzsbO/8SaPbikTuLxWNaZZhYPQNShqBm8wHGQ+ruQ1rwHAYVH9+fSsvh koMXWMPGRGEd6a2FeaL9G3TC2rmeO56pYVoubqmPSIFHdRxmZhewEJU3JxDs5onYFhod JBoolcBYaB0+RbOWTssRG5Gh9WNtAue4/SglPnSF0tNhrXHApNNgPAYqE7fM1VimvxuG WlJxCadj5k3FH0sYnQRQbXvxDkJo7X4CPSiQz0m+SgrkSZWSkxYRInY14R6rtys/RZHm 1rLxEVsSl8+NCdNwcstVJUms6H/nxJjggDH89o3Wsow8aX4V9xvvITNTjNA+NvqRW+ax Y3MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=1mAV/ZoaEMJ5L5q3DxakmcuPtg7cHPy33uxHU0PLEqM=; b=FI8zUxt8OimVFsZesPVvPnH7k0tQhZ5ZGub+GM/SrNJ9roZSiIJaYi27rZ21PAYmBS z2c5sK1bnZ60/d6MKh53xnbPcERmHYmrzT7cfNJcJ/XZ7v/DoPbOgUobnY/mgcAAHVjC 3a8NvGF1qteQINY0gHI8oUAygwU1U4ummjxyY8qOUixmfn/fxpsksACrtCQCRpwAhxKk wKD0muATLqGkOgX597T8WzFPjR0jlxSLlzOHMugd+igUGOpFJuozDCBw2QcKg8oZeo0t HOF+jPwxKSwaBotlh/Kiy4NgfOsGWQr7gX/HXw5BmgQWlYnV3i2X2ko3RHvoR6vij+m2 crCw== X-Gm-Message-State: AA+aEWYFfgqnBP/Bj95f50mw8AiZ1yoGm50vgpgzEPYxvXIeAzgawdWg PAsWbSmp9FyuKRgmh2yLbRM= X-Google-Smtp-Source: AFSGD/XS++ozfv2IhzaKjP1fd76uFuf4Yem8uSNN81caLgd8wn64hfgBAALgGCK1fv/qn4QmG6VZ9g== X-Received: by 2002:aa7:d684:: with SMTP id d4mr48434493edr.59.1546721598952; Sat, 05 Jan 2019 12:53:18 -0800 (PST) Original-Received: from macbook.localdomain ([41.237.67.158]) by smtp.gmail.com with ESMTPSA id j31sm27098306eda.46.2019.01.05.12.53.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 05 Jan 2019 12:53:17 -0800 (PST) Content-Disposition: inline In-Reply-To: <838t085qx8.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:154170 Archived-At: On Sat, Dec 29, 2018 at 04:49:23PM +0200, Eli Zaretskii wrote: > > Date: Mon, 24 Dec 2018 19:37:23 +0200 > > From: Khaled Hosny > > Cc: rgm@gnu.org, far.nasiri.m@gmail.com, behdad@behdad.org, > > 33729@debbugs.gnu.org, kaushal.modi@gmail.com > > > > > > We need to know, for a given lgstring we are shaping: > > > > * Its direction (from applying bidi algorithm). Each lgstring we are > > > > shaping must be of a single direction. > > > > > > Communicating this to ftfont_shape_by_hb will need changes in a couple > > > of interfaces (the existing shaping engines didn't need this > > > information). I will work on this soon. > > > > Great. > > Done. Please test. I made sure it compiles, but I couldn't actually > test the results, as I don't have access to a GNU/Linux system with > GUI display. So it could be that I misunderstood the Harfbuzz APIs, > as I was essentially flying blind, guided only by the Harfbuzz docs. It seems to work, but still not quite right. You seem to be passing the paragraph direction, but what HarfBuzz needs is resolved direction of the text (i.e. the bidi embedding level of the run). In other words, if Emacs is going to draw this text from right to left, then HarfBuzz must shape it in right to left direction. Both should use the same direction all the time and HarfBuzz direction guessing should never be used (i.e. always pass to it an explicit direction). Regards, Khaled