unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: "João Távora" <joaotavora@gmail.com>
Cc: Beatrix Klebe <beeuhtricks@gmail.com>,
	bea@klebe.blog, Stefan Monnier <monnier@iro.umontreal.ca>,
	33794@debbugs.gnu.org
Subject: bug#33794: 26.1; electric-pair-mode breaks auto-newline minor mode of cc-mode
Date: Fri, 28 Dec 2018 12:44:18 +0000	[thread overview]
Message-ID: <20181228124418.GA5845__26396.3042911657$1546001694$gmane$org@ACM> (raw)
In-Reply-To: <87lg4fnctm.fsf@gmail.com>

Hello, João.

On Sun, Dec 23, 2018 at 21:38:29 +0000, João Távora wrote:
> Alan Mackenzie <acm@muc.de> writes:

> > If I were to dig in to e-p-m, make fixes, and commit them, I suspect
> > you would be somewhat annoyed.

> If you propose changes to e-p-m that:

> * don't break any (more) unit tests;

> * don't introduce new interfaces to special case cc-mode;

> * Stefan accepts, since the self-insert-command-hook part was his
>   responsibility entirely, (as I have tried to explain a million times.)

> Then I don't see why I would be annoyed.

> (You could of course come to the faint realization that maybe there is
> the off-chance that there exists a glimmer of possibility that in a
> remote part of the multiverse it is quite possible that a minute part
> the problem lies in cc-mode.  But no, that is preposterous! let us not
> even consider that heresy!  It's decades old after all, it MUST be
> correct, forever and absolutely!)

The problem we're dealing with is in the interface between CC Mode and
electric-pair-mode.  Naturally, both sides of this putative interface
will need adapting.

From my point of view, what is missing from e-p-m is an interface usable
by functions which call self-insert-command programmatically, as CC Mode
does.  A function to insert the matching character and otherwise process
it.  Or something like that, I haven't fully worked it out.

Sadly, at the moment it's looking like the easiest way to fix bug #33794
would be to duplicate the functionality of electric-pair-mode inside CC
Mode, as I've already done partially.  I really don't want to do that,
and you probably don't want me to do that either.

[ .... ]

> João

-- 
Alan Mackenzie (Nuremberg, Germany).





  parent reply	other threads:[~2018-12-28 12:44 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-18 17:38 bug#33794: 26.1; electric-pair-mode breaks auto-newline minor mode of cc-mode Beatrix Klebe
     [not found] ` <mailman.5894.1545155289.1284.bug-gnu-emacs@gnu.org>
2018-12-21 13:48   ` Alan Mackenzie
2018-12-21 13:57     ` João Távora
2018-12-21 14:12       ` Stefan Monnier
2018-12-21 16:00         ` Beatrix Klebe
2018-12-21 18:49           ` João Távora
2018-12-21 19:06             ` Beatrix Klebe
2018-12-21 19:20               ` João Távora
2018-12-21 19:24                 ` João Távora
2018-12-21 19:43                 ` Beatrix Klebe
2018-12-22  1:08                   ` João Távora
2018-12-22  2:16                     ` João Távora
2018-12-22  2:41                       ` Alan Mackenzie
2018-12-22  3:22                         ` João Távora
2018-12-22  4:41                           ` Beatrix Klebe
2018-12-22 10:02                             ` João Távora
2018-12-22 12:33                           ` Alan Mackenzie
2019-01-01 19:27           ` Alan Mackenzie
2019-01-15 16:10             ` Alan Mackenzie
2018-12-21 20:11         ` Alan Mackenzie
2018-12-22  0:45           ` João Távora
2018-12-22 10:20             ` Alan Mackenzie
2018-12-22 13:47               ` João Távora
2018-12-21 21:50       ` Alan Mackenzie
2018-12-22 16:22         ` Stefan Monnier
2018-12-22 16:34           ` Beatrix Klebe
2018-12-22 17:12             ` Stefan Monnier
2018-12-22 17:34               ` Beatrix Klebe
2018-12-22 21:19                 ` João Távora
2018-12-22 22:15                   ` Alan Mackenzie
2018-12-22 22:55                     ` João Távora
2018-12-23 20:21                       ` Alan Mackenzie
     [not found]                       ` <20181223202143.GA6658@ACM>
2018-12-23 21:38                         ` João Távora
2018-12-23 21:46                           ` Alan Mackenzie
2018-12-28 12:44                           ` Alan Mackenzie [this message]
2018-12-23 14:43                     ` Stefan Monnier
2018-12-23 14:48   ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='20181228124418.GA5845__26396.3042911657$1546001694$gmane$org@ACM' \
    --to=acm@muc.de \
    --cc=33794@debbugs.gnu.org \
    --cc=bea@klebe.blog \
    --cc=beeuhtricks@gmail.com \
    --cc=joaotavora@gmail.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).