From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Khaled Hosny Newsgroups: gmane.emacs.bugs Subject: bug#33729: 27.0.50; Partial glyphs not rendered for Gujarati with Harfbuzz enabled (renders fine using m17n) Date: Sat, 22 Dec 2018 17:42:47 +0200 Message-ID: <20181222154247.GD2244@macbook.localdomain> References: <20181214110316.GK2244@macbook.localdomain> <83y38sfcme.fsf@gnu.org> <83tvjgf7ux.fsf@gnu.org> <83mup4du5z.fsf@gnu.org> <20181222085448.GA2244@macbook.localdomain> <20181222090644.GB2244@macbook.localdomain> <83va3lan24.fsf@gnu.org> <20181222151509.GC2244@macbook.localdomain> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1545493330 25975 195.159.176.226 (22 Dec 2018 15:42:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 22 Dec 2018 15:42:10 +0000 (UTC) User-Agent: Mutt/1.11.1 (2018-12-01) Cc: 33729@debbugs.gnu.org, Mohammad Nasirifar , Kaushal Modi To: Behdad Esfahbod Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 22 16:42:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gajPh-0006cx-Ay for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Dec 2018 16:42:05 +0100 Original-Received: from localhost ([::1]:52345 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gajRo-0001KG-3o for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Dec 2018 10:44:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48165) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gajRd-0001Js-Bv for bug-gnu-emacs@gnu.org; Sat, 22 Dec 2018 10:44:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gajRa-0008Jf-NS for bug-gnu-emacs@gnu.org; Sat, 22 Dec 2018 10:44:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55887) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gajRa-0008JU-Jk for bug-gnu-emacs@gnu.org; Sat, 22 Dec 2018 10:44:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gajRa-0000Gh-Fd for bug-gnu-emacs@gnu.org; Sat, 22 Dec 2018 10:44:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Khaled Hosny Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Dec 2018 15:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33729 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33729-submit@debbugs.gnu.org id=B33729.1545493382934 (code B ref 33729); Sat, 22 Dec 2018 15:44:02 +0000 Original-Received: (at 33729) by debbugs.gnu.org; 22 Dec 2018 15:43:02 +0000 Original-Received: from localhost ([127.0.0.1]:60142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gajQa-0000Eg-E6 for submit@debbugs.gnu.org; Sat, 22 Dec 2018 10:43:02 -0500 Original-Received: from mail-wm1-f54.google.com ([209.85.128.54]:33402) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gajQY-0000ER-1n for 33729@debbugs.gnu.org; Sat, 22 Dec 2018 10:42:58 -0500 Original-Received: by mail-wm1-f54.google.com with SMTP id r24so16261713wmh.0 for <33729@debbugs.gnu.org>; Sat, 22 Dec 2018 07:42:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=nJnHhLFuY382kjGKA/qEXxBl/HR+fJyjYgQk1K1NYDM=; b=AAGZnlh6xYpwoTyIYZxSQvqC0RFMRzYRAWccz4HwCeQVchCoA19GNyoeUjRGTqgfhF TYV3fNxnE1T4g0EMs1e7Dt/82EA3fPW6TBQGCXZPouvQ97QthBJBrt5xcMdBfu15DeSk go3Vno8v3xAAIHolH5yXnbjgTjKrNP/hCEFSE5RQuANuEqAKJJN02Jd9hwdZp1l6CLWB nbykLnLcTjaxFpRMOQ6ahA3H7vIYTMLkpvx+AR6CR+w6Wt/uhJurvqJmKNIZeLB8dp6o cwnn4VufxDbiaTk3jkGdT78bwZHS7L4qsM4AdkrjXUoe6W2jhmerJcKxFg/gxMA1k4dL ZusA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=nJnHhLFuY382kjGKA/qEXxBl/HR+fJyjYgQk1K1NYDM=; b=BCWDoDYLUe9vDme/N0PR8E0ZCYnbMovlod3yMPnN4Z4WNzdXP3w+VI+jK//MeiApGZ Sklaqlf5Gtgi0V+GDjbeFwJ+kuOYBeSV0jUK7J8dFnrEtB/NQg1FVjDZ8Rz4BYqDIhTT ka1yT/ZG2gTHvjG8cWDKrzuDWxXgoxYeYhDdw1CMAGO1F/t3h406oPlJOGAAOwZicnro rNpmSKU1eA0WLQGi9RBfnXCdzwnxsyQQ5qwIVdaH9LqqiD/LyPeltWDnDAzPwPoAVhqU MiBwTNFpatARTmbOp8zCUsR73DEh6CyEnmrqPl2cCsRU8efFfRH5TXyZZARMKUDnvEnl qWQQ== X-Gm-Message-State: AJcUukf4dWlIWPK93BogbQMPIox1NKnZxMLnAJrxZ0Ti1ierSk/Txtd1 zNeBmrZ5Fya9/cIc+5F2zSY= X-Google-Smtp-Source: ALg8bN5N2+RsLJH7rj/jK/z6DM/PBYiFt/FInkHcaIxFW7tiYmF/QKPHJcbMdpCANpCEbGCA4J9nvA== X-Received: by 2002:a1c:5dce:: with SMTP id r197mr6363901wmb.130.1545493372134; Sat, 22 Dec 2018 07:42:52 -0800 (PST) Original-Received: from macbook.localdomain ([41.237.113.27]) by smtp.gmail.com with ESMTPSA id t5sm13026704wmg.43.2018.12.22.07.42.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 22 Dec 2018 07:42:51 -0800 (PST) Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153740 Archived-At: I’m sub-classing the default Unicode functions, so for the callback we don’t implement the default implementation will be used already. On Sat, Dec 22, 2018 at 10:27:06AM -0500, Behdad Esfahbod wrote: > I suggest you enabled UCDN. > > On Sat, Dec 22, 2018 at 10:15 AM Khaled Hosny > wrote: > > > On Sat, Dec 22, 2018 at 12:11:15PM +0200, Eli Zaretskii wrote: > > > > Date: Sat, 22 Dec 2018 11:06:44 +0200 > > > > From: Khaled Hosny > > > > Cc: Glenn Morris , far.nasiri.m@gmail.com, > > behdad@behdad.org, > > > > 33729@debbugs.gnu.org, kaushal.modi@gmail.com > > > > > > > > > Alternatively, we could just use HarfBuzz’s own built in ucdn-based > > > > > Unicode function for this. The only reason for overriding this in > > Emacs > > > > > was to keep HarfBuzz and Emacs Unicode support in sync, but if we are > > > > > going to duplicate the Unicode script data then better use what > > HarfBuzz > > > > > has. > > > > > > > > > > I’m going to try this now. > > > > > > > > I pushed a commit to harfbuzz branch that I think fixes this issue now. > > > > > > Thanks. > > > > > > There's a FIXME in the change you pushed (which I believe just > > > repeats what was already in the previous version). Ca you tell more > > > about the problem we need to fix there? > > > > We need a way to get Unicode composition and decomposition for the > > a given character (implementing the uni_compose and uni_decompose > > functions I deleted). I recall you suggested something earlier that I > > tried but couldn’t get to work, the exact detail escapes me. > > > > > -- > behdad > http://behdad.org/