From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Khaled Hosny Newsgroups: gmane.emacs.bugs Subject: bug#33748: 27.0.50; harfbuzz branch fails to compile Date: Sat, 15 Dec 2018 00:52:53 +0200 Message-ID: <20181214225253.GM2244@macbook.localdomain> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1544827933 18546 195.159.176.226 (14 Dec 2018 22:52:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 14 Dec 2018 22:52:13 +0000 (UTC) User-Agent: Mutt/1.11.1 (2018-12-01) Cc: behdad@behdad.org, 33748@debbugs.gnu.org, far.nasiri.m@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 14 23:52:08 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXwJS-0004hL-I9 for geb-bug-gnu-emacs@m.gmane.org; Fri, 14 Dec 2018 23:52:06 +0100 Original-Received: from localhost ([::1]:35856 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXwLZ-0001UL-Dl for geb-bug-gnu-emacs@m.gmane.org; Fri, 14 Dec 2018 17:54:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34928) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXwLQ-0001U5-Ff for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2018 17:54:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXwLK-00015j-80 for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2018 17:54:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44396) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gXwLK-00015J-0X for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2018 17:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gXwLJ-0004R0-OO for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2018 17:54:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Khaled Hosny Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Dec 2018 22:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33748 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-Cc: behdad@behdad.org, bug-gnu-emacs@gnu.org, far.nasiri.m@gmail.com Original-Received: via spool by submit@debbugs.gnu.org id=B.154482799416993 (code B ref -1); Fri, 14 Dec 2018 22:54:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 14 Dec 2018 22:53:14 +0000 Original-Received: from localhost ([127.0.0.1]:48654 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXwKX-0004Q0-Ld for submit@debbugs.gnu.org; Fri, 14 Dec 2018 17:53:13 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:53193) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXwKV-0004Pn-UZ for submit@debbugs.gnu.org; Fri, 14 Dec 2018 17:53:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXwKP-0007zl-HX for submit@debbugs.gnu.org; Fri, 14 Dec 2018 17:53:06 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:39551) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gXwKP-0007zO-Ds for submit@debbugs.gnu.org; Fri, 14 Dec 2018 17:53:05 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34560) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXwKO-0000bb-MY for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2018 17:53:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXwKN-0007wt-Sv for bug-gnu-emacs@gnu.org; Fri, 14 Dec 2018 17:53:04 -0500 Original-Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]:35558) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gXwKJ-0007nD-Uk; Fri, 14 Dec 2018 17:53:00 -0500 Original-Received: by mail-wm1-x32f.google.com with SMTP id c126so7250212wmh.0; Fri, 14 Dec 2018 14:52:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=B6mWa2a7fKnoWrmWgSV7tY3qZFJgahbu2gGaLMtrF98=; b=YkeJ+7wpI3MfiYpdewqnMoSNpd6sSUhduoTIK3hXr7WK3Fqz7KdOYN7z04lydpRHm+ opOdUPi+Y4f/A6PohNN6nve9kU9S4cgH0iqkCjVhtAx6JnC8ZItcoz1ggVJKLmzxVSD0 MutznVBYBhBWO7wU+WlaThU5WuS918JtuREBu57itYhdzfTXfScbIsqeIouI23Y9y6AU jK5C0HOngqhYr7Ioph+dvzaJh8tAV9UqNa3/S4mqKiR5Mo4oVGPlmWseSBX4mLKbNnfy H01oCLmpMm3B9ud1pymQMk2+6T0SXmR2OWm22HEDTVuFwopDL5fQOzCuuqG+QNzMKH6P Ztxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=B6mWa2a7fKnoWrmWgSV7tY3qZFJgahbu2gGaLMtrF98=; b=HP9gAG07ZtQ0B+hm/qZ8YY+NTK9I5OR27FHAbiA317FzLEcudBfwiuU99OsUG1ioUK Eq6ZsQTwgrkzo64ODl2SlH6/n2BwnCaiFDoPRAHMrC/TXFIxXkw8vR5mpjtUAY3LuQe7 VE7GSBLIVWo4FHgZZHsZlKvnIEwvB6eY8qqJpdU3HQdanizk9s5khnx4E2aGhKn6117Q ToqCmJ5C3hJPn/3AQnqLDSNFxvtSe5wBGoZSvjB37san9+8RHA9v3RnrNf9C/pLTzbsX +uPOXosCB3egAbyVx06ooIHlA2BwwwqkX8TLptCpV4OLG+TySBuAV7O3vRZyUcI4Tjxr LXYw== X-Gm-Message-State: AA+aEWYGEkgGQW/22wem42BQB9cifMNAZ38yQEWSas0vUCJVhugw71Uk 6rWbNyiaqEixpHkiUdZhuJenpPK+ X-Google-Smtp-Source: AFSGD/XHUU1oaOOz9XGh86VfOf7rWI/oon8nSaMTDvUP1ea3sHaT5HuEbC8uxAxsd3shYLN2hiYUng== X-Received: by 2002:a1c:cbc7:: with SMTP id b190mr4952251wmg.13.1544827978665; Fri, 14 Dec 2018 14:52:58 -0800 (PST) Original-Received: from macbook.localdomain ([197.58.120.254]) by smtp.gmail.com with ESMTPSA id y13sm7861095wrw.85.2018.12.14.14.52.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 14 Dec 2018 14:52:58 -0800 (PST) Content-Disposition: inline In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153468 Archived-At: On Fri, Dec 14, 2018 at 03:27:37PM -0500, Eli Zaretskii wrote: > > The compilation fails with this error: > > CC ftfont.o > ftfont.c: In function ‘ftfont_shape_by_hb’: > ftfont.c:2866:3: warning: implicit declaration of function ‘hb_buffer_set_cluster_level’ [-Wimplicit-function-declaration] > hb_buffer_set_cluster_level (hb_buffer, HB_BUFFER_CLUSTER_LEVEL_MONOTONE_CHARACTERS); > ^ > ftfont.c:2866:43: error: ‘HB_BUFFER_CLUSTER_LEVEL_MONOTONE_CHARACTERS’ undeclared (first use in this function) > hb_buffer_set_cluster_level (hb_buffer, HB_BUFFER_CLUSTER_LEVEL_MONOTONE_CHARACTERS); > ^ > ftfont.c:2866:43: note: each undeclared identifier is reported only once for each function it appears in > make[1]: *** [ftfont.o] Error 1 > > The version of Harfbuzz I have on this machine is 0.9.27. If this too old? If so, what minimum version do I need to successfully build the branch? Seems so. You can add configure.ac checks for hb_buffer_set_cluster_level and use it conditionally, or require a newer HarfBuzz version. I prefer the later, since the behaviour of cluster level 1 is assumed elsewhere in the code (I don’t recall what exactly). Regards, Khaled