unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Khaled Hosny <dr.khaled.hosny@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: behdad@behdad.org, 33748@debbugs.gnu.org, far.nasiri.m@gmail.com
Subject: bug#33748: 27.0.50; harfbuzz branch fails to compile
Date: Sat, 15 Dec 2018 00:52:53 +0200	[thread overview]
Message-ID: <20181214225253.GM2244@macbook.localdomain> (raw)
In-Reply-To: <E1gXu3d-0002uf-IQ@fencepost.gnu.org>

On Fri, Dec 14, 2018 at 03:27:37PM -0500, Eli Zaretskii wrote:
> 
> The compilation fails with this error:
> 
>     CC       ftfont.o
>   ftfont.c: In function ‘ftfont_shape_by_hb’:
>   ftfont.c:2866:3: warning: implicit declaration of function ‘hb_buffer_set_cluster_level’ [-Wimplicit-function-declaration]
>      hb_buffer_set_cluster_level (hb_buffer, HB_BUFFER_CLUSTER_LEVEL_MONOTONE_CHARACTERS);
>      ^
>   ftfont.c:2866:43: error: ‘HB_BUFFER_CLUSTER_LEVEL_MONOTONE_CHARACTERS’ undeclared (first use in this function)
>      hb_buffer_set_cluster_level (hb_buffer, HB_BUFFER_CLUSTER_LEVEL_MONOTONE_CHARACTERS);
> 					     ^
>   ftfont.c:2866:43: note: each undeclared identifier is reported only once for each function it appears in
>   make[1]: *** [ftfont.o] Error 1
> 
> The version of Harfbuzz I have on this machine is 0.9.27.  If this too old?  If so, what minimum version do I need to successfully build the branch?

Seems so. You can add configure.ac checks for hb_buffer_set_cluster_level
and use it conditionally, or require a newer HarfBuzz version. I prefer
the later, since the behaviour of cluster level 1 is assumed elsewhere
in the code (I don’t recall what exactly).

Regards,
Khaled





  parent reply	other threads:[~2018-12-14 22:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-14 20:27 bug#33748: 27.0.50; harfbuzz branch fails to compile Eli Zaretskii
2018-12-14 20:44 ` Glenn Morris
2018-12-15  6:44   ` Eli Zaretskii
2018-12-15  7:34     ` Colin Baxter
2018-12-15 11:24       ` Colin Baxter
2018-12-15 12:05         ` Eli Zaretskii
2018-12-14 22:52 ` Khaled Hosny [this message]
2018-12-15  6:59   ` Eli Zaretskii
2018-12-15  7:13     ` Eli Zaretskii
2018-12-15 10:32       ` Khaled Hosny
2018-12-15 10:37         ` Eli Zaretskii
2018-12-15 10:32     ` Khaled Hosny
2018-12-15 17:50       ` Glenn Morris
2018-12-15 19:10         ` Eli Zaretskii
2018-12-17 19:13           ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181214225253.GM2244@macbook.localdomain \
    --to=dr.khaled.hosny@gmail.com \
    --cc=33748@debbugs.gnu.org \
    --cc=behdad@behdad.org \
    --cc=eliz@gnu.org \
    --cc=far.nasiri.m@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).