From: Alan Mackenzie <acm@muc.de>
To: Drew Adams <drew.adams@oracle.com>
Cc: 33601@debbugs.gnu.org
Subject: bug#33601: 26; Add macro `with-hook-added'
Date: 4 Dec 2018 18:46:14 -0000 [thread overview]
Message-ID: <20181204184614.2049.qmail@mail.muc.de> (raw)
In-Reply-To: <mailman.5097.1543862895.1284.bug-gnu-emacs@gnu.org>
Hello, Drew.
In article <mailman.5097.1543862895.1284.bug-gnu-emacs@gnu.org> you wrote:
> Enhancement request: Please consider adding a macro such as this, to
> facilitate temporary use of a hook function.
> (defmacro with-hook-added (hook function &rest body)
> "Evaluate forms in BODY with FUNCTION added to HOOK, then remove FUNCTION."
> (declare (indent 1) (debug t))
> `(unwind-protect (progn (add-hook ',hook ',function) ,@body)
> (remove-hook ',hook ',function)))
Just a big point: you need to test whether FUNCTION is already on HOOK
at the start, and if so, not remove it at the end.
Apologies if somebody else has already pointed this out.
> In GNU Emacs 26.1 (build 1, x86_64-w64-mingw32)
> of 2018-05-30
> Repository revision: 07f8f9bc5a51f5aa94eb099f3e15fbe0c20ea1ea
> Windowing system distributor `Microsoft Corp.', version 10.0.16299
> Configured using:
> `configure --without-dbus --host=x86_64-w64-mingw32
> --without-compress-install 'CFLAGS=-O2 -static -g3''
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2018-12-04 18:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 18:47 bug#33601: 26; Add macro `with-hook-added' Drew Adams
2018-12-03 19:01 ` Glenn Morris
2018-12-03 20:58 ` Drew Adams
2018-12-03 19:03 ` Drew Adams
2018-12-03 22:37 ` Phil Sainty
2018-12-03 22:50 ` Drew Adams
2018-12-03 23:13 ` Phil Sainty
2018-12-03 23:51 ` Drew Adams
[not found] ` <mailman.5097.1543862895.1284.bug-gnu-emacs@gnu.org>
2018-12-04 18:46 ` Alan Mackenzie [this message]
2022-02-12 8:46 ` Lars Ingebrigtsen
[not found] <<mailman.5097.1543862895.1284.bug-gnu-emacs@gnu.org>
[not found] ` <<20181204184614.2049.qmail@mail.muc.de>
2018-12-04 19:18 ` Drew Adams
2018-12-04 20:10 ` Alan Mackenzie
2018-12-04 21:22 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181204184614.2049.qmail@mail.muc.de \
--to=acm@muc.de \
--cc=33601@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).