From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#33587: [PROPOSED] Default to disabling ImageMagick Date: Sun, 2 Dec 2018 10:09:19 -0800 Message-ID: <20181202180919.32270-1-eggert@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1543774103 18097 195.159.176.226 (2 Dec 2018 18:08:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 2 Dec 2018 18:08:23 +0000 (UTC) Cc: Paul Eggert To: 33587@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 02 19:08:19 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTWAE-0004ZJ-TB for geb-bug-gnu-emacs@m.gmane.org; Sun, 02 Dec 2018 19:08:19 +0100 Original-Received: from localhost ([::1]:45407 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gTWCL-0007yz-87 for geb-bug-gnu-emacs@m.gmane.org; Sun, 02 Dec 2018 13:10:29 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36604) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gTWCD-0007ur-V9 for bug-gnu-emacs@gnu.org; Sun, 02 Dec 2018 13:10:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gTWC4-0000pV-OG for bug-gnu-emacs@gnu.org; Sun, 02 Dec 2018 13:10:19 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54078) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gTWBu-0000kL-Me for bug-gnu-emacs@gnu.org; Sun, 02 Dec 2018 13:10:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gTWBu-0006WZ-E6 for bug-gnu-emacs@gnu.org; Sun, 02 Dec 2018 13:10:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Dec 2018 18:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 33587 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.154377418425047 (code B ref -1); Sun, 02 Dec 2018 18:10:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 2 Dec 2018 18:09:44 +0000 Original-Received: from localhost ([127.0.0.1]:58336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTWBb-0006Vt-7m for submit@debbugs.gnu.org; Sun, 02 Dec 2018 13:09:43 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:54870) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTWBZ-0006Ve-5U for submit@debbugs.gnu.org; Sun, 02 Dec 2018 13:09:41 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gTWBT-0000TS-7f for submit@debbugs.gnu.org; Sun, 02 Dec 2018 13:09:36 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:56357) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gTWBT-0000TN-3C for submit@debbugs.gnu.org; Sun, 02 Dec 2018 13:09:35 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36231) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gTWBQ-0007Qn-RA for bug-gnu-emacs@gnu.org; Sun, 02 Dec 2018 13:09:34 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gTWBM-0000R8-0V for bug-gnu-emacs@gnu.org; Sun, 02 Dec 2018 13:09:32 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:45038) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gTWBL-0000QT-RC for bug-gnu-emacs@gnu.org; Sun, 02 Dec 2018 13:09:27 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 312201600A9 for ; Sun, 2 Dec 2018 10:09:26 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id ufVCTaJw-_NF; Sun, 2 Dec 2018 10:09:23 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 9C8F4160260; Sun, 2 Dec 2018 10:09:23 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id cXkClDPIg1os; Sun, 2 Dec 2018 10:09:23 -0800 (PST) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 79EE01600A9; Sun, 2 Dec 2018 10:09:23 -0800 (PST) X-Mailer: git-send-email 2.19.2 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153004 Archived-At: From: Paul Eggert ImageMagick has continuing stability and security problems, suggesting that 'configure' should disable it by default. See Glenn Morris's notes at: https://lists.gnu.org/r/emacs-devel/2018-12/msg00036.html * INSTALL, etc/NEWS: Mention this. * configure.ac (imagemagick): Default to off. --- INSTALL | 4 +++- configure.ac | 2 +- etc/NEWS | 4 ++++ 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/INSTALL b/INSTALL index 0c56fff6d4..9696904dce 100644 --- a/INSTALL +++ b/INSTALL @@ -294,7 +294,9 @@ or more of these options: --without-gif for GIF image support --without-png for PNG image support --without-rsvg for SVG image support - --without-imagemagick for Imagemagick support + +Although ImageMagick support is disabled by default due to security +and stability concerns, you can enable it with --with-imagemagick. =20 Use --without-toolkit-scroll-bars to disable Motif or Xaw3d scroll bars. =20 diff --git a/configure.ac b/configure.ac index 8b34c3b658..b70393925a 100644 --- a/configure.ac +++ b/configure.ac @@ -354,7 +354,7 @@ AC_DEFUN OPTION_DEFAULT_ON([libsystemd],[don't compile with libsystemd support]) OPTION_DEFAULT_OFF([cairo],[compile with Cairo drawing (experimental)]) OPTION_DEFAULT_ON([xml2],[don't compile with XML parsing support]) -OPTION_DEFAULT_ON([imagemagick],[don't compile with ImageMagick image su= pport]) +OPTION_DEFAULT_OFF([imagemagick],[compile with ImageMagick image support= ]) OPTION_DEFAULT_ON([json], [don't compile with native JSON support]) =20 OPTION_DEFAULT_ON([xft],[don't use XFT for anti aliased fonts]) diff --git a/etc/NEWS b/etc/NEWS index 6297d07879..07c6f74c44 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -37,6 +37,10 @@ functions 'json-serialize', 'json-insert', 'json-parse= -string', and 'json-parse-buffer' are typically much faster than their Lisp counterparts from json.el. =20 +** Emacs no longer defaults to using ImageMagick to display images, +due to security and stability concerns. To override the default, use +'configure --with-imagemagick'. + ** The etags program now uses the C library's regular expression matcher when possible, and a compatible regex substitute otherwise. This will let developers maintain Emacs's own regex code without having to also --=20 2.19.2