From: Paul Eggert <eggert@cs.ucla.edu>
To: 33587@debbugs.gnu.org
Cc: Paul Eggert <eggert@Penguin.CS.UCLA.EDU>
Subject: bug#33587: [PROPOSED] Default to disabling ImageMagick
Date: Sun, 2 Dec 2018 10:09:19 -0800 [thread overview]
Message-ID: <20181202180919.32270-1-eggert@cs.ucla.edu> (raw)
From: Paul Eggert <eggert@Penguin.CS.UCLA.EDU>
ImageMagick has continuing stability and security problems, suggesting
that 'configure' should disable it by default. See Glenn Morris's notes
at: https://lists.gnu.org/r/emacs-devel/2018-12/msg00036.html
* INSTALL, etc/NEWS: Mention this.
* configure.ac (imagemagick): Default to off.
---
INSTALL | 4 +++-
configure.ac | 2 +-
etc/NEWS | 4 ++++
3 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/INSTALL b/INSTALL
index 0c56fff6d4..9696904dce 100644
--- a/INSTALL
+++ b/INSTALL
@@ -294,7 +294,9 @@ or more of these options:
--without-gif for GIF image support
--without-png for PNG image support
--without-rsvg for SVG image support
- --without-imagemagick for Imagemagick support
+
+Although ImageMagick support is disabled by default due to security
+and stability concerns, you can enable it with --with-imagemagick.
Use --without-toolkit-scroll-bars to disable Motif or Xaw3d scroll bars.
diff --git a/configure.ac b/configure.ac
index 8b34c3b658..b70393925a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -354,7 +354,7 @@ AC_DEFUN
OPTION_DEFAULT_ON([libsystemd],[don't compile with libsystemd support])
OPTION_DEFAULT_OFF([cairo],[compile with Cairo drawing (experimental)])
OPTION_DEFAULT_ON([xml2],[don't compile with XML parsing support])
-OPTION_DEFAULT_ON([imagemagick],[don't compile with ImageMagick image support])
+OPTION_DEFAULT_OFF([imagemagick],[compile with ImageMagick image support])
OPTION_DEFAULT_ON([json], [don't compile with native JSON support])
OPTION_DEFAULT_ON([xft],[don't use XFT for anti aliased fonts])
diff --git a/etc/NEWS b/etc/NEWS
index 6297d07879..07c6f74c44 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -37,6 +37,10 @@ functions 'json-serialize', 'json-insert', 'json-parse-string', and
'json-parse-buffer' are typically much faster than their Lisp
counterparts from json.el.
+** Emacs no longer defaults to using ImageMagick to display images,
+due to security and stability concerns. To override the default, use
+'configure --with-imagemagick'.
+
** The etags program now uses the C library's regular expression matcher
when possible, and a compatible regex substitute otherwise. This will
let developers maintain Emacs's own regex code without having to also
--
2.19.2
next reply other threads:[~2018-12-02 18:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-02 18:09 Paul Eggert [this message]
2018-12-02 18:15 ` bug#33587: [PROPOSED] Default to disabling ImageMagick Eli Zaretskii
2018-12-02 19:13 ` Andreas Schwab
2018-12-02 23:51 ` Paul Eggert
2018-12-03 21:09 ` Alan Third
2018-12-03 19:08 ` Glenn Morris
2018-12-03 19:35 ` Paul Eggert
2018-12-03 19:40 ` Glenn Morris
2018-12-04 16:51 ` David Engster
2018-12-04 17:00 ` Glenn Morris
2018-12-04 17:38 ` David Engster
2018-12-04 18:16 ` Glenn Morris
2018-12-10 17:49 ` Paul Eggert
[not found] <8336qb3upt.fsf@gnu.org>
[not found] ` <20190102211241.GA53734@breton.holly.idiocy.org>
[not found] ` <837efk335e.fsf@gnu.org>
[not found] ` <20190104190914.GA61852@breton.holly.idiocy.org>
[not found] ` <8336q82myq.fsf@gnu.org>
[not found] ` <20190104224558.GA63257@breton.holly.idiocy.org>
[not found] ` <20190110194250.GA22478@breton.holly.idiocy.org>
[not found] ` <cda98d78-268c-2464-36d3-cc03a4db97ef@cs.ucla.edu>
2019-05-14 6:15 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181202180919.32270-1-eggert@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=33587@debbugs.gnu.org \
--cc=eggert@Penguin.CS.UCLA.EDU \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).