From: Alan Mackenzie <acm@muc.de>
To: 33475-done@debbugs.gnu.org
Subject: bug#33475: [Wish list]: Display line and column numbers in warnings with `compile-defun'
Date: Wed, 28 Nov 2018 13:34:12 +0000 [thread overview]
Message-ID: <20181128133412.GA18476@ACM> (raw)
In-Reply-To: <20181127071531.GA5093@ACM>
On Tue, Nov 27, 2018 at 07:15:31 +0000, Alan Mackenzie wrote:
> On Fri, Nov 23, 2018 at 17:58:39 +0000, Alan Mackenzie wrote:
> > Hello, Emacs.
> > At the moment, if a warning is displayed for a compilation started by
> > `compile-defun', it appears something like:
> > Warning: assignment to free variable `foo'
> > . This is all very well, but it lacks the line and column number of the
> > place of the warning, meaning one must search through the source and
> > guess where the warning is.
> > Why not output this information, much like is done in a batch
> > compilation? It would then look like:
> > Buffer winkler2.el:3:14:Warning: assignment to free variable `foo'
> > . This would save guessing and irritation.
> > Here is a patch which achieves this:
> [ .... ]
> This patch was all very well, but was incomplete: hitting CR on such a
> warning message in *Compile-Log* failed to move to the position in the
> .el buffer, instead spuriously prompting for a file.
> The following patch, incorporating the patch from my original post,
> fixes this by amending compile.el to handle buffers as an alternative to
> file names, creating emacs-lisp-compilation-mode, which extracts the
> buffer from one of these warning messages, and calling this new mode
> from byte-compile-log-file in place of compilation-mode.
Committed to the master branch.
Closing the bug.
--
Alan Mackenzie (Nuremberg, Germany).
prev parent reply other threads:[~2018-11-28 13:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-23 17:58 bug#33475: [Wish list]: Display line and column numbers in warnings with `compile-defun' Alan Mackenzie
2018-11-27 7:15 ` Alan Mackenzie
2018-11-28 13:34 ` Alan Mackenzie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181128133412.GA18476@ACM \
--to=acm@muc.de \
--cc=33475-done@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).