unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Third <alan@idiocy.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: tkk@misasa.okayama-u.ac.jp, 33452@debbugs.gnu.org
Subject: bug#33452: Color of tooltip text on macOS with dark mode
Date: Fri, 23 Nov 2018 18:10:49 +0000	[thread overview]
Message-ID: <20181123181049.GA24527@breton.holly.idiocy.org> (raw)
In-Reply-To: <83va4of5ni.fsf@gnu.org>

On Fri, Nov 23, 2018 at 12:29:53PM +0200, Eli Zaretskii wrote:
> > Date: Wed, 21 Nov 2018 19:44:58 +0000
> > From: Alan Third <alan@idiocy.org>
> > Cc: Tak Kunihiro <tkk@misasa.okayama-u.ac.jp>, 33452@debbugs.gnu.org
> > 
> > I expect it was commit 15cd18991c1d9a9bafeef7bf9b4dad91ecc0332a.
> 
> Are you saying that tooltips on NS couldn't use colors before that
> change?  Or was that color support broken at some point?  If the
> latter, when was it broken and by what changeset?

Tooltips on NS couldn’t use colours before that change.

What happened is that tooltips set the background to yellow and left
the foreground (text) to be the system default (black).

MacOS Mojave has introduced ‘dark mode’, which makes the foreground
colour light, and therefore we’re seeing light text on a yellow
background.

If you don’t want to apply the above commit the absolute minimum fix
for emacs-26 would be to explicitly set a foreground colour for
tooltips, or not set the background, therefore reverting to the system
default.

-- 
Alan Third





  reply	other threads:[~2018-11-23 18:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-21  7:30 bug#33452: Color of tooltip text on macOS with mark mode Tak Kunihiro
2018-11-21  9:30 ` Eli Zaretskii
2018-11-21 10:14   ` bug#33452: Color of tooltip text on macOS with dark mode Tak Kunihiro
2018-11-21 10:32     ` Eli Zaretskii
2018-11-21 19:44       ` Alan Third
2018-11-22 12:44         ` Tak Kunihiro
2018-11-23 10:29         ` Eli Zaretskii
2018-11-23 18:10           ` Alan Third [this message]
2018-11-23 20:13             ` Eli Zaretskii
2018-11-23 20:38               ` Alan Third
2018-11-23 21:08                 ` Eli Zaretskii
2018-11-24  9:35                   ` Alan Third
2018-11-24  9:44                     ` Eli Zaretskii
2018-11-25 11:36                     ` Alan Third

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181123181049.GA24527@breton.holly.idiocy.org \
    --to=alan@idiocy.org \
    --cc=33452@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=tkk@misasa.okayama-u.ac.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).