From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#33201: 26.1; Edebug doesn't work on closures with edebug-unwrap-results Date: Thu, 1 Nov 2018 19:59:18 +0000 Message-ID: <20181101195918.GD4504@ACM> References: <20181031150627.67149.qmail@mail.muc.de> <20181101100056.GA4504@ACM> <83sh0khdf6.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1541102296 26707 195.159.176.226 (1 Nov 2018 19:58:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 1 Nov 2018 19:58:16 +0000 (UTC) User-Agent: Mutt/1.10.1 (2018-07-13) Cc: gazally@runbox.com, 33201@debbugs.gnu.org, darkfeline@felesatra.moe To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 01 20:58:11 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gIJ6Z-0006qo-5o for geb-bug-gnu-emacs@m.gmane.org; Thu, 01 Nov 2018 20:58:11 +0100 Original-Received: from localhost ([::1]:43812 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gIJ8f-0003UT-6S for geb-bug-gnu-emacs@m.gmane.org; Thu, 01 Nov 2018 16:00:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37372) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gIJ8Y-0003UC-RR for bug-gnu-emacs@gnu.org; Thu, 01 Nov 2018 16:00:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gIJ8S-0008KR-IR for bug-gnu-emacs@gnu.org; Thu, 01 Nov 2018 16:00:12 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54566) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gIJ8M-0008H2-H1 for bug-gnu-emacs@gnu.org; Thu, 01 Nov 2018 16:00:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gIJ8M-0002Fq-Aj for bug-gnu-emacs@gnu.org; Thu, 01 Nov 2018 16:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Nov 2018 20:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33201 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33201-submit@debbugs.gnu.org id=B33201.15411023728598 (code B ref 33201); Thu, 01 Nov 2018 20:00:02 +0000 Original-Received: (at 33201) by debbugs.gnu.org; 1 Nov 2018 19:59:32 +0000 Original-Received: from localhost ([127.0.0.1]:58824 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gIJ7s-0002Ea-CB for submit@debbugs.gnu.org; Thu, 01 Nov 2018 15:59:32 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:56364 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1gIJ7q-0002EQ-D2 for 33201@debbugs.gnu.org; Thu, 01 Nov 2018 15:59:30 -0400 Original-Received: (qmail 55039 invoked by uid 3782); 1 Nov 2018 19:59:28 -0000 Original-Received: from acm.muc.de (p5B1479F1.dip0.t-ipconnect.de [91.20.121.241]) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 01 Nov 2018 20:59:28 +0100 Original-Received: (qmail 6581 invoked by uid 1000); 1 Nov 2018 19:59:18 -0000 Content-Disposition: inline In-Reply-To: <83sh0khdf6.fsf@gnu.org> X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:151914 Archived-At: Hello, Eli. On Thu, Nov 01, 2018 at 20:15:41 +0200, Eli Zaretskii wrote: > > Date: Thu, 1 Nov 2018 10:00:56 +0000 > > From: Alan Mackenzie > > Cc: 33201@debbugs.gnu.org > > > > This fix could probably be backported to the emacs-26 branch, but how > > > > important is it? What were you actually trying to do when you uncovered > > > > this bug? > > > I don't remember. I have encountered this error multiple times before > > > and given up debugging something. Since one generally runs into bugs > > > when doing work (that is not hacking on Emacs itself), it's helpful to > > > be able to debug with minimal obstruction, otherwise it becomes an > > > unjustifiable distraction from the main task. > > OK, it sounds like it's a major problem. > It does? Why? Well, it's a major problem for the OP, at the very least. ;-) It seems like in Emacs 26.1 edebug can't be reliably used with edebug-unwrap-results non-nil because there's always a chance it will encounter the symbol `closure', at which point it errors out. [`closure' is wierd, because it has a meaning, yet has none of a function, a value, a property list.] > > @Gemini: The patch below is a (small) portion of > > e09120d68694272ea5efbe13b16936b4382389d8 from 2018-06-19, the commit that > > introduced Backtrace Mode. Can you see anything against applying this > > commit to the emacs-26 branch to fix this bug? > I can: it's quite complex, and even includes gratuitous refactoring of > 'cond' as 'pcase'. OK. How about me doing a simpler, but less lazy fix which would just add handling of `closure' into the existing cond form? -- Alan Mackenzie (Nuremberg, Germany).