From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#32932: 27.0.50; render bugs on macOS Mojave Date: Sat, 20 Oct 2018 21:04:44 +0100 Message-ID: <20181020200444.GA2501@breton.holly.idiocy.org> References: <20181010182750.GB18177@breton.holly.idiocy.org> <20181014182012.GD87313@breton.holly.idiocy.org> <7BCD942D-621D-4C91-AA8E-6C38908C03EE@d12frosted.io> <20181019184828.GA2041@breton.holly.idiocy.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1540065789 11051 195.159.176.226 (20 Oct 2018 20:03:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 20 Oct 2018 20:03:09 +0000 (UTC) User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Boris Buliga , 32932@debbugs.gnu.org To: Aaron Jensen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 20 22:03:05 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gDxSi-0002mt-GJ for geb-bug-gnu-emacs@m.gmane.org; Sat, 20 Oct 2018 22:03:04 +0200 Original-Received: from localhost ([::1]:56423 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gDxUp-0005sa-1X for geb-bug-gnu-emacs@m.gmane.org; Sat, 20 Oct 2018 16:05:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54222) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gDxUf-0005sK-Sr for bug-gnu-emacs@gnu.org; Sat, 20 Oct 2018 16:05:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gDxUc-00056c-NG for bug-gnu-emacs@gnu.org; Sat, 20 Oct 2018 16:05:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57456) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gDxUc-00056W-Hg for bug-gnu-emacs@gnu.org; Sat, 20 Oct 2018 16:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gDxUc-0004YA-9H for bug-gnu-emacs@gnu.org; Sat, 20 Oct 2018 16:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 20 Oct 2018 20:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32932 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32932-submit@debbugs.gnu.org id=B32932.154006589517475 (code B ref 32932); Sat, 20 Oct 2018 20:05:02 +0000 Original-Received: (at 32932) by debbugs.gnu.org; 20 Oct 2018 20:04:55 +0000 Original-Received: from localhost ([127.0.0.1]:33481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gDxUU-0004Xm-FP for submit@debbugs.gnu.org; Sat, 20 Oct 2018 16:04:54 -0400 Original-Received: from mail-wr1-f49.google.com ([209.85.221.49]:33549) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gDxUS-0004XZ-SH for 32932@debbugs.gnu.org; Sat, 20 Oct 2018 16:04:53 -0400 Original-Received: by mail-wr1-f49.google.com with SMTP id u1-v6so4989621wrn.0 for <32932@debbugs.gnu.org>; Sat, 20 Oct 2018 13:04:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=qs9bB2bWk5X2O8gSP/p5QN8kvf/Nbckvw8iL8gqYCZU=; b=IE+uvSsXh+GWZAgE7l/oVBr5upe7pvwdnmYgeUE7u2t7vF+Np89V7+bfLfJEgwUJE3 M6LLRmCEmM/ZWL/mXlIVwwfHn2JZnLpG5U/DpQjQNagvWmp+WiR00SaoRTdLJQzeQF/3 cIw3vfzotdGACL0F4/+HQKGS/Z0lvbnOiZcCogGE++5S50IMSIKtoiGyIELrBnGnoZag h7J3nf05SxMK7Fr+5tytFi9nQTJkwYU3PwMzihaXEEZleIfGi+01HTmlwxd1koK+mEN1 V7rb08TVxnx4Lwucq+pfncG0OnrJl6FeumsDN3NNW+sbJyBUe6SWeCKT49RkM2wtIM+i MEig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=qs9bB2bWk5X2O8gSP/p5QN8kvf/Nbckvw8iL8gqYCZU=; b=TFRBXH1OnvYexZMZ4wsQF4N3X2Q3mW0On3h/0PcUfqrl78+F/5ZLwqKddWA2OD9p79 zH5jUyIQ+XHchrIG/J8EPBHp/RrDqb2ctHeERcs4XLyBaTyG83AV21ZSyYYODDDTfQP1 ONdkL52NWQpg5RiQZ7XSdhFNPfYC3yO5yXfFSQpEzrzrEMntzuaqiIYx7nu4HL1+Pz6Z yOru1cB3mMhnI580qHIyk7GTdEtRIUk39pntrmdMxdg78BHnzCLtlFmGhe41bgLXfctI V2eFv5SOiEkr/LvrIuF26i7HlzGl6pbSswBaC2PgEG/a6VPQcGrEGmDYOME97d9+O2X5 C7Mg== X-Gm-Message-State: ABuFfoh+Hh0kKOHziApKV8nNXLXS2iAho4N/jCBUwiEEPj+DQORNWzJD +hAE+0eMkaFsOeMlJFnukm4= X-Google-Smtp-Source: ACcGV61DbNyC+PGFLQ8jjmbN63wF05FtPxtJuQlWS/Zr2ZKngY/M02NGn/HGX5eEUlJ2ZcreuSedfw== X-Received: by 2002:a5d:628c:: with SMTP id k12-v6mr37327073wru.83.1540065886704; Sat, 20 Oct 2018 13:04:46 -0700 (PDT) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-a82d-514e-f600-d441.holly.idiocy.org. [2001:8b0:3f8:8129:a82d:514e:f600:d441]) by smtp.gmail.com with ESMTPSA id r134-v6sm5415027wmg.9.2018.10.20.13.04.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 20 Oct 2018 13:04:45 -0700 (PDT) Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:151468 Archived-At: On Fri, Oct 19, 2018 at 12:24:33PM -0700, Aaron Jensen wrote: > On Fri, Oct 19, 2018 at 11:48 AM Alan Third wrote: > > > https://cl.ly/9065281385cf/Image%202018-10-19%20at%209.20.34%20AM.png > > > > Does it actually look like that? With the strange blocks? It looks > > like there’s some weird resizing/resampling thing going on... > > No, that's me anonymizing source I can't share :) Oh, thank goodness! :) > > That makes sense because of how the cursor code marks entire lines as > > dirty. If it was drawing correctly then I’d fix it, but there’s no > > point just now. > > Sorry, fix which, and what drawing correctly? I didn't think it > repainting the cursor line is a problem (especially since I use > global-hl-line-mode). But maybe you meant something else. Sorry, I’m just confusing things. We’re redrawing more than we need to at the moment. It’s not really a problem. Can you try removing ns_clear_frame_area (emacsframe, x, y, width, height); from drawRect: in nsterm.m? It may result in the background not being redrawn correctly in some places, but I *think* it’s redundant, and it’s possible for it to clear a section of screen and then expose_frame to decide not to redraw anything. This shouldn’t happen as the only reason I know for expose_frame to not redraw is if there’s a redisplay coming up, in which case redisplay should mark the whole frame as needing redrawn anyway. But perhaps there’s some situation where it doesn’t draw and there’s no immediate redisplay. -- Alan Third