From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: David Edmondson Newsgroups: gmane.emacs.bugs Subject: bug#33043: [PATCH v1 1/1] Support for the truncation of displayed URLs Date: Mon, 15 Oct 2018 11:06:26 +0100 Message-ID: <20181015100626.2344-1-dme@dme.org> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1539597914 14217 195.159.176.226 (15 Oct 2018 10:05:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 15 Oct 2018 10:05:14 +0000 (UTC) To: 33043@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 15 12:05:09 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gBzkK-0003aD-W8 for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Oct 2018 12:05:09 +0200 Original-Received: from localhost ([::1]:51446 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gBzmR-000521-KB for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Oct 2018 06:07:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39130) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gBzmD-0004xW-TS for bug-gnu-emacs@gnu.org; Mon, 15 Oct 2018 06:07:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gBzmA-0000YI-Qr for bug-gnu-emacs@gnu.org; Mon, 15 Oct 2018 06:07:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45564) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gBzmA-0000Y4-LA for bug-gnu-emacs@gnu.org; Mon, 15 Oct 2018 06:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gBzmA-0007LM-Dr for bug-gnu-emacs@gnu.org; Mon, 15 Oct 2018 06:07:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: David Edmondson Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Oct 2018 10:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33043 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33043-submit@debbugs.gnu.org id=B33043.153959799628195 (code B ref 33043); Mon, 15 Oct 2018 10:07:02 +0000 Original-Received: (at 33043) by debbugs.gnu.org; 15 Oct 2018 10:06:36 +0000 Original-Received: from localhost ([127.0.0.1]:49822 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gBzlk-0007Kh-K5 for submit@debbugs.gnu.org; Mon, 15 Oct 2018 06:06:36 -0400 Original-Received: from mail-wm1-f49.google.com ([209.85.128.49]:54239) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gBzli-0007KR-R3 for 33043@debbugs.gnu.org; Mon, 15 Oct 2018 06:06:35 -0400 Original-Received: by mail-wm1-f49.google.com with SMTP id y11-v6so18221606wma.3 for <33043@debbugs.gnu.org>; Mon, 15 Oct 2018 03:06:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dme-org.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=wBxxlUQ516J7xbLXO811C33JEs5ctkohN5srJZiRMJ4=; b=xuG83aPHI7/IgTTOj3HlyUu5ae9xrVlfd2tZyo4Woa+2M+qEIDWTVPyIGedd5JTDeC hfHLg2XmgYRp/WtwwZEbHU62gCtwSPsQ/2ADXnL2ON8PT5YXUSu0yum7qoyQ1hFAeYTH c3wNSeK0kJCJgrPYycUareYbCrETpt/d1aQ0mB8P/e7k5SBUIMmRiHZB0QdyzRcMeZ/o s1lCSNUX4tImecTISwbMUG5dS9a6MWEPIadnM18DOzDCPbkdKqQ7LZMP+zJRP5cdxaCJ 8C4Uuda1Qesv08h5f/adCZ9DwtlOlmpWktDMsHMXKD5+Eie1ArMD0a1Y8jeLHYTXAfDm y43w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=wBxxlUQ516J7xbLXO811C33JEs5ctkohN5srJZiRMJ4=; b=Y1EXFiuAqzfDi8Dav2VEqM0hyhBacp0XILeoZ18m2JtyGEsmS8mTX2Ez4s1a2gzaXI 5IA2O8WOR+6TNpotVKg1wci1puaLoLbr6wa4zPJ6Ouh5PgGtQhipB/u0I9UC4+f+jtF2 tzUkVXbdHYas3q+0yOQnMmftyGRer2L/NokVlwmauzmEGcK2kmEBMffOH6S2o1Yf6vXo vNZHTVMS3T9MBrDfgntrUa7WOa4xY4UetI3i01ccTQSWFTaeazMaZuhZy7oBZnrPL4Qw D+mn+0GkJZoAgXDmtOIzaNrvxcdy7EYM7p46JU0VvQrmoY++bGo5+YKIUpdjNOdZCmBW hl+w== X-Gm-Message-State: ABuFfohBM+q+RiypYb/esLYUOyvv/ux1V4VWAL7S6EBxujXG7uyovd8E QGg7hrFtj6BA1OHGdFGKkWKWgXbjW2M= X-Google-Smtp-Source: ACcGV62F9isT1mzUrU0RxL/gXeKYW3cvS0xMqS+6/iwoH9utFTTbVJbrtt9s8liOnI0cT+X3u6aWSA== X-Received: by 2002:a1c:1812:: with SMTP id 18-v6mr12950917wmy.34.1539597988724; Mon, 15 Oct 2018 03:06:28 -0700 (PDT) Original-Received: from disaster-area.hh.sledj.net (disaster-area.hh.sledj.net. [81.149.164.25]) by smtp.gmail.com with ESMTPSA id a1-v6sm8024978wrt.79.2018.10.15.03.06.27 for <33043@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Oct 2018 03:06:27 -0700 (PDT) Original-Received: from localhost (disaster-area.hh.sledj.net [local]) by disaster-area.hh.sledj.net (OpenSMTPD) with ESMTPA id 1badbadf for <33043@debbugs.gnu.org>; Mon, 15 Oct 2018 10:06:27 +0000 (UTC) X-Mailer: git-send-email 2.19.1 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:151261 Archived-At: When applying markup to URLs in the buffer, truncate the visible portion to `rcirc-url-max-length' characters. By default no truncation is done. --- lisp/net/rcirc.el | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el index fe9c71a21c..1c0b540563 100644 --- a/lisp/net/rcirc.el +++ b/lisp/net/rcirc.el @@ -168,6 +168,13 @@ rcirc-fill-prefix (string :tag "Prefix text")) :group 'rcirc) +(defcustom rcirc-url-max-length nil + "Maximum number of characters in displayed URLs. +If nil, no maximum is applied." + :type '(choice (const :tag "No maximum" nil) + (integer :tag "Number of characters")) + :group 'rcirc) + (defvar rcirc-ignore-buffer-activity-flag nil "If non-nil, ignore activity in this buffer.") (make-variable-buffer-local 'rcirc-ignore-buffer-activity-flag) @@ -2491,6 +2498,16 @@ rcirc-markup-urls (end (match-end 0)) (url (match-string-no-properties 0)) (link-text (buffer-substring-no-properties start end))) + ;; Truncate the visible part of URLs if required and necessary. + (when (and rcirc-url-max-length + (> (- end start) rcirc-url-max-length)) + (let* ((ellipsis "...") + (new-end (- (+ start rcirc-url-max-length) + (length ellipsis)))) + (delete-region new-end end) + (goto-char new-end) + (insert ellipsis) + (setq end (point)))) ;; Add a button for the URL. Note that we use `make-text-button', ;; rather than `make-button', as text-buttons are much faster in ;; large buffers. -- 2.19.1