From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#32848: 26.1; follow-mode cursor move breaks with frame-resize-pixelwise Date: Mon, 1 Oct 2018 12:33:36 +0000 Message-ID: <20181001123336.GB5947@ACM> References: <83r2hc5sbf.fsf@gnu.org> <20180929144846.GC5008@ACM> <83k1n45onn.fsf@gnu.org> <20180929202545.GE5008@ACM> <83efdb5z73.fsf@gnu.org> <8336tr5j6j.fsf@gnu.org> <20180930121618.GB6305@ACM> <83sh1r3zz9.fsf@gnu.org> <20180930140921.GD6305@ACM> <83mury53a9.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1538397486 4249 195.159.176.226 (1 Oct 2018 12:38:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 1 Oct 2018 12:38:06 +0000 (UTC) User-Agent: Mutt/1.10.1 (2018-07-13) Cc: 32848@debbugs.gnu.org, andlind@gmail.com, darkfeline@felesatra.moe To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 01 14:38:02 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6xSa-0000u5-0G for geb-bug-gnu-emacs@m.gmane.org; Mon, 01 Oct 2018 14:38:00 +0200 Original-Received: from localhost ([::1]:38374 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g6xUg-0007w7-8V for geb-bug-gnu-emacs@m.gmane.org; Mon, 01 Oct 2018 08:40:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46046) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g6xUa-0007vr-P9 for bug-gnu-emacs@gnu.org; Mon, 01 Oct 2018 08:40:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g6xUY-0005dB-2j for bug-gnu-emacs@gnu.org; Mon, 01 Oct 2018 08:40:04 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:56560) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g6xUX-0005d5-Ug for bug-gnu-emacs@gnu.org; Mon, 01 Oct 2018 08:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1g6xUX-0006sY-R2 for bug-gnu-emacs@gnu.org; Mon, 01 Oct 2018 08:40:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Oct 2018 12:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32848 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32848-submit@debbugs.gnu.org id=B32848.153839756526380 (code B ref 32848); Mon, 01 Oct 2018 12:40:01 +0000 Original-Received: (at 32848) by debbugs.gnu.org; 1 Oct 2018 12:39:25 +0000 Original-Received: from localhost ([127.0.0.1]:60818 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g6xTw-0006rQ-Q4 for submit@debbugs.gnu.org; Mon, 01 Oct 2018 08:39:25 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:28905 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1g6xTv-0006rF-85 for 32848@debbugs.gnu.org; Mon, 01 Oct 2018 08:39:23 -0400 Original-Received: (qmail 66403 invoked by uid 3782); 1 Oct 2018 12:39:21 -0000 Original-Received: from acm.muc.de (p5B1474A3.dip0.t-ipconnect.de [91.20.116.163]) by colin.muc.de (tmda-ofmipd) with ESMTP; Mon, 01 Oct 2018 14:39:20 +0200 Original-Received: (qmail 6446 invoked by uid 1000); 1 Oct 2018 12:33:36 -0000 Content-Disposition: inline In-Reply-To: <83mury53a9.fsf@gnu.org> X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:150866 Archived-At: Hello, Eli. On Sun, Sep 30, 2018 at 20:00:14 +0300, Eli Zaretskii wrote: > > Date: Sun, 30 Sep 2018 14:09:21 +0000 > > Cc: 32848@debbugs.gnu.org, andlind@gmail.com, darkfeline@felesatra.moe > > From: Alan Mackenzie > > The problem was that LH point was "straddling" the window "edge". The > > solution appears to be to copy what happens when LH point is outside the > > window, i.e. allow redisplay to move it back to the centre of the window. > > For this, a simple (forward-line) suffices. > > The trouble is, all the make-cursor-line-fully-visible stuff we've done > > then becomes redundant, since point will never be left inside a partially > > displayed line, except possibly at EOB. > > Here's my current patch. What do you think? > I think we should revert the change to set > make-cursor-line-fully-visible locally on the emacs-26 branch, and > install this patch instead. I can agree with this. > But on master, I think we need both this patch and a special function > that sets make-cursor-line-fully-visible nil in non-last windows under > follow-mode, because that's definitely what follow-mode wants. I don't understand what this would be for. With my patch from the last post, I don't think any window's point would ever be left by follow-mode in a partially displayed line. Maybe the function I've written (follow-make-cursor-line-fully-visible-p) might be useful sometime in the future. -- Alan Mackenzie (Nuremberg, Germany).