unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Third <alan@idiocy.org>
To: Zack Piper <zack@apertron.com>
Cc: 32812@debbugs.gnu.org
Subject: bug#32812: 27.0.50; macOS Mojave GNU Emacs crash after 5-10 minutes or so
Date: Mon, 24 Sep 2018 14:11:33 +0100	[thread overview]
Message-ID: <20180924131133.GA26922@breton.holly.idiocy.org> (raw)
In-Reply-To: <44769E5D-B37C-48AF-9C17-38264CE6224A@apertron.com>

[-- Attachment #1: Type: text/plain, Size: 604 bytes --]

On Mon, Sep 24, 2018 at 12:39:22PM +0100, Zack Piper wrote:
> (Final attempt at sending, TLS was being enforced for my outgoing emails,
> sorry Alan for the spam!)

I think I actually did receive all the emails. No big deal, though.

> > This patch doesn’t help, I finally reproduced the crash with it in
> > place.
> 
> Oh, damn.

I think I’ve got it this time. I haven’t managed to reproduce the
crash, but I may just have been lucky.

> I truly wish I could help somewhat, if you need anything additional from me
> let me know.

That’s OK, just testing the patches is helpful.

-- 
Alan Third

[-- Attachment #2: 0001-Fix-crash-on-flush-to-display-bug-32812.patch --]
[-- Type: text/plain, Size: 794 bytes --]

From 356f20b5d8b5809100102797c51f1b54cc8a908e Mon Sep 17 00:00:00 2001
From: Alan Third <alan@idiocy.org>
Date: Mon, 24 Sep 2018 14:04:54 +0100
Subject: [PATCH] Fix crash on flush to display (bug#32812)

* src/nsterm.m (ns_flush_display): Block input to prevent Emacs IO
processing inside AppKit code.
---
 src/nsterm.m | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/nsterm.m b/src/nsterm.m
index b36d847eb3..4c03d35c69 100644
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -1252,7 +1252,9 @@ static NSRect constrain_frame_rect(NSRect frameRect, bool isFullscreen)
    dirty by setNeedsDisplayInRect (in ns_focus), then this will call
    draw_rect: which will "expose" those areas.  */
 {
+  block_input ();
   [FRAME_NS_VIEW (f) displayIfNeeded];
+  unblock_input ();
 }
 
 
-- 
2.18.0


  reply	other threads:[~2018-09-24 13:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-23 15:21 bug#32812: 27.0.50; macOS Mojave GNU Emacs crash after 5-10 minutes or so Zack Piper
2018-09-24 10:17 ` Alan Third
2018-09-24 10:24   ` Alan Third
2018-09-24 11:39   ` Zack Piper
2018-09-24 13:11     ` Alan Third [this message]
2018-09-24 14:16       ` Zack Piper
2018-11-30 10:17       ` Alan Third

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180924131133.GA26922@breton.holly.idiocy.org \
    --to=alan@idiocy.org \
    --cc=32812@debbugs.gnu.org \
    --cc=zack@apertron.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).