unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Boruch Baum <boruch_baum@gmx.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 31094@debbugs.gnu.org
Subject: bug#31094: Code for second solution
Date: Sun, 8 Apr 2018 10:13:30 -0400	[thread overview]
Message-ID: <20180408141330.qzrustisiaea7ozg@E15-2016.optimum.net> (raw)
In-Reply-To: <83fu45ztuc.fsf@gnu.org>

On 2018-04-08 16:54, Eli Zaretskii wrote:
> > Date: Sun, 8 Apr 2018 09:17:01 -0400
> > From: Boruch Baum <boruch_baum@gmx.com>
> > Cc: 31094@debbugs.gnu.org
> >
> > The first code snippet already only changes behavior when the function
> > is called with either two or three universal prefix args.
>
> I was under the impression that the first variant was not what you were
> promoting.

Different strokes for different folks. Personally, I would end up using
the second variant, but I wouldn't begrudge anyone the first option and
they can co-exist peacefully in the code. Both are minor tweaks.

> > The second snippet is controlled by a boolean defcustom variable,
> > defaulting to the current long print-out behavior.
>
> That sounds sub-optimal to me: completely changing the behavior of a
> command given an option is not the best UI, IMO.  Two different
> commands are better.

You're over stating the behavior change of the second snippet; it
changes the detail level of the output. True, as written, it 'breaks'
the response to <RET> keybinding, but I consider that trivial, because
the same functionality is available with `C-h v` or `C-h f', and to the
benefit that the snippet is much leaner on memory. If you insist that
you absolutely need that <RET> key to display the symbol's complete
documentation, that can be done without rejecting the idea of the
snippet, but it's a minor coding hassle for no real reason; Everyone
knows `C-h v' and `C-h f' describe the symbol at point.

-- 
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1  7286 0036 9E45 1595 8BC0





  reply	other threads:[~2018-04-08 14:13 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-08  7:39 bug#31094: 25.2: Feature Reuqest: apropos-value: limit scope [CODE INCLUDED] Boruch Baum
2018-04-08 11:09 ` bug#31094: Code for second solution Boruch Baum
2018-04-08 13:06   ` Eli Zaretskii
2018-04-08 13:17     ` Boruch Baum
2018-04-08 13:54       ` Eli Zaretskii
2018-04-08 14:13         ` Boruch Baum [this message]
2018-04-08 16:32           ` Eli Zaretskii
2022-01-23 14:45 ` bug#31094: 25.2: Feature Reuqest: apropos-value: limit scope [CODE INCLUDED] Lars Ingebrigtsen
2022-01-23 18:02   ` Juri Linkov
2022-01-23 18:29     ` Lars Ingebrigtsen
2022-01-23 20:02       ` Juri Linkov
2022-01-24  9:26         ` Lars Ingebrigtsen
2022-01-24 17:58           ` Juri Linkov
2022-01-24 18:33             ` Lars Ingebrigtsen
2022-01-24 19:19               ` Juri Linkov
2022-01-25 12:03                 ` Lars Ingebrigtsen
2022-01-25  2:06 ` Michael Heerdegen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180408141330.qzrustisiaea7ozg@E15-2016.optimum.net \
    --to=boruch_baum@gmx.com \
    --cc=31094@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).