unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 31042@debbugs.gnu.org
Subject: bug#31042: Emacs 27. Inserting a character doesn't always "deactivate" the mark.
Date: Tue, 3 Apr 2018 14:39:12 +0000	[thread overview]
Message-ID: <20180403143911.GB5363@ACM> (raw)
In-Reply-To: <831sfw5qnz.fsf@gnu.org>

Hello, Eli.

On Tue, Apr 03, 2018 at 17:08:00 +0300, Eli Zaretskii wrote:
> > Date: Tue, 3 Apr 2018 13:42:46 +0000
> > From: Alan Mackenzie <acm@muc.de>

> > On a related note, it appears that in the same function, the file
> > locking is done for the first change in a buffer.  This locking would
> > appear not to be done if that first change to the buffer happens when
> > inhibit-modification-hooks is non-nil.  I haven't tested this, but it
> > would appear to be part of the same bug.

> This is a feature, see the doc string of inhibit-modification-hooks.

Yes, the whole thing is a feature.  :-(

I now see that inhibit-modification-hooks is a special purpose facility,
only suited for applying text properties to the buffer.  Perhaps it has
other uses, too.

It is most definitely not suitable for when "real" buffer modifications
are done.  For that, presumably, one needs to bind
before/after-change-functions to nil, as used to be done before i-m-h
was invented.

I will need to modify the new combine-change-calls, which is no great
hardship.

How about me modifying the documentation and the doc string to point out
the disadvantages of inhibit-modification-hooks when used for actual
textual buffer changes?

I will close this bug.

-- 
Alan Mackenzie (Nuremberg, Germany).





  reply	other threads:[~2018-04-03 14:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-03 13:42 bug#31042: Emacs 27. Inserting a character doesn't always "deactivate" the mark Alan Mackenzie
2018-04-03 14:08 ` Eli Zaretskii
2018-04-03 14:39   ` Alan Mackenzie [this message]
2018-04-03 15:12     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180403143911.GB5363@ACM \
    --to=acm@muc.de \
    --cc=31042@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).