unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Third <alan@idiocy.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 30800@debbugs.gnu.org, aaronjensen@gmail.com
Subject: bug#30800: 26.0.91; unknown crash on macos
Date: Wed, 21 Mar 2018 20:12:34 +0000	[thread overview]
Message-ID: <20180321201234.GA39094@breton.holly.idiocy.org> (raw)
In-Reply-To: <83d0zxjk5p.fsf@gnu.org>

On Wed, Mar 21, 2018 at 09:36:18PM +0200, Eli Zaretskii wrote:
> > Date: Wed, 21 Mar 2018 19:19:03 +0000
> > From: Alan Third <alan@idiocy.org>
> > Cc: Aaron Jensen <aaronjensen@gmail.com>, 30800@debbugs.gnu.org
> > 
> > The commit that introduced represented_frame was fixing some
> > flickering. What it seems to have done is move the updating of the
> > represented filename from being set synchronously to asynchronously.
> > The represented filename tells the WM which file is being edited so it
> > can show a matching icon in the titlebar and maybe some other stuff.
<snip>
> > (I can’t help thinking it should be possible to update several frames
> > in quick succession but only have the last actually updated since
> > represented_filename and represented_frame are simply over‐written.)
> 
> Yes, this machinery looks quite fragile to me.
> 
> Is there any reason not to use selected_frame instead?

I think we could end up in a similar situation if the selected frame
changed soon after ns_set_represented_filename was called (i.e. it
will set it for the wrong frame).

It might be best to try setting the represented filename synchronously
again and come up with some other way of avoiding the flicker.

(Original bug report was 18757 and the commit was
d9d383147219f8e6a90d4c177e1b454e19acfac9.)
-- 
Alan Third





  reply	other threads:[~2018-03-21 20:12 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-13 16:18 bug#30800: 26.0.91; unknown crash on macos Aaron Jensen
2018-03-13 16:36 ` Aaron Jensen
2018-03-20 23:39   ` Aaron Jensen
2018-03-21  6:37     ` Eli Zaretskii
2018-03-21 16:25       ` Aaron Jensen
2018-03-21 17:00         ` Eli Zaretskii
2018-03-21 17:09           ` Eli Zaretskii
2018-03-21 17:31             ` Aaron Jensen
2018-03-21 18:22               ` Eli Zaretskii
2018-03-21 18:31                 ` Aaron Jensen
2018-03-21 18:48                   ` Eli Zaretskii
2018-03-21 19:19                     ` Alan Third
2018-03-21 19:36                       ` Eli Zaretskii
2018-03-21 20:12                         ` Alan Third [this message]
2018-03-22  5:40                           ` Aaron Jensen
2018-03-22  7:26                             ` Eli Zaretskii
2018-03-22 15:39                               ` Aaron Jensen
2018-03-22 15:57                                 ` Eli Zaretskii
2018-03-23  1:49                                   ` Aaron Jensen
2018-03-23  8:16                                     ` Eli Zaretskii
2018-03-23 19:52                                   ` Alan Third
2018-03-23 20:57                                     ` Aaron Jensen
2018-03-24  7:20                                     ` Aaron Jensen
2018-03-24 10:29                                       ` Alan Third
2018-03-24 14:54                                         ` Eli Zaretskii
2018-03-24 16:18                                           ` Alan Third
2018-03-24 17:48                                             ` Eli Zaretskii
2018-03-25 19:17                                               ` Alan Third
2018-03-24 10:49                                     ` Charles A. Roelli
2018-03-24 14:12                                       ` Alan Third
2018-03-25 20:14                                         ` Charles A. Roelli
2018-03-26 18:37                                           ` Alan Third
2018-03-26 23:03                                             ` Aaron Jensen
2018-03-30 11:37                                               ` Alan Third
2018-03-30 11:57                                                 ` Aaron Jensen
2018-03-22  5:35                         ` Aaron Jensen
2018-03-22  7:16                           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180321201234.GA39094@breton.holly.idiocy.org \
    --to=alan@idiocy.org \
    --cc=30800@debbugs.gnu.org \
    --cc=aaronjensen@gmail.com \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).