unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: dgutov@yandex.ru, 30393@debbugs.gnu.org,
	monnier@IRO.UMontreal.CA, npostavs@users.sourceforge.net
Subject: bug#30393: 24.4; cperl-mode: indentation failure
Date: Tue, 6 Mar 2018 18:09:17 +0000	[thread overview]
Message-ID: <20180306180917.GA7774@ACM> (raw)
In-Reply-To: <83zi3msdms.fsf@gnu.org>

Hello, Eli.

On Mon, Mar 05, 2018 at 18:14:51 +0200, Eli Zaretskii wrote:
> > Date: Mon, 5 Mar 2018 08:42:55 +0000
> > From: Alan Mackenzie <acm@muc.de>
> > Cc: 30393@debbugs.gnu.org, Dmitry Gutov <dgutov@yandex.ru>,
> > 	Noam Postavsky <npostavs@users.sourceforge.net>

> > Existing C functions have been modified as follows:
> >   o - signal_after_change.
> >     * - Regardless of the settings of the change hooks,
> >       syntax-ppss-flush-cache will be called for an actual textual
> >       change.
> >   o - Fset_syntax_table.
> >     * - If the new table is literally different from the old,
> >       syntax-ppss-flush-cache will be called with an argument of -1.
> >   o - Fmodify_syntax_entry.
> >     * - If the new entry is literally different from the old one,
> >       syntax-ppss-flush-cache will be called with an argument of -1.
> >   o - init_syntax_once and syms_of_syntax.
> >     * - Administrative amendments.
> >   o - set_properties, add_properties, remove_properties.  If a
> >     syntax-table property set or removed, whether directly or via a
> >     category property, potentially alters the parsing of literals,
> >     syntax-ppss-flush-cache will be called.

> Any reason why you introduce 2 new primitives that no Lisp code uses?

least-literal-difference-between-syntax-tables and
syntax-tables-literally-different-p?  They're for helping with
debugging.  Syntax tables, like char tables in general, are awkward
unwieldy beasts.  Sooner or later, somebody debugging is going to want
to compare two syntax tables which aren't behaving as she expects they
should.  Those primitives (which, yes, will need documenting) were cheap
and easy to write, but would be awkward and unwieldy to write as
one-offs in Lisp.

> In any case, this needs documentation changes if and when it's agreed
> upon.

Yes, but less documentation that would be needed without it.
Introducing the syntax-ppss mechanism into syntax primitives broke them,
since its cache invalidation is imperfect.  With my patch, aside from
any bugs in it, those primitives are less broken, hence less
documentation of the breakage is needed.

> Thanks.

-- 
Alan Mackenzie (Nuremberg, Germany).





  reply	other threads:[~2018-03-06 18:09 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-08 15:25 bug#30393: 24.4; cperl-mode: indentation failure paulusm
2018-02-09  1:44 ` Noam Postavsky
     [not found] ` <mailman.8766.1518140709.27995.bug-gnu-emacs@gnu.org>
2018-02-09 17:50   ` Alan Mackenzie
2018-02-10  3:55     ` Noam Postavsky
2018-02-10  8:53     ` Dmitry Gutov
2018-02-10 11:26       ` Alan Mackenzie
2018-02-10 12:08         ` Eli Zaretskii
2018-02-11 12:49           ` Alan Mackenzie
2018-02-11 16:16             ` Eli Zaretskii
2018-02-14 21:00               ` Alan Mackenzie
2018-02-15 17:39                 ` Eli Zaretskii
2018-02-16 11:52                 ` Dmitry Gutov
2018-02-16 17:43                   ` Alan Mackenzie
2018-02-17  2:16                     ` Dmitry Gutov
2018-02-17 10:54                       ` Alan Mackenzie
2018-02-10 14:58         ` Stefan Monnier
2018-02-11 10:36           ` Alan Mackenzie
2018-02-11 22:53             ` Stefan Monnier
2018-02-12 18:38               ` Alan Mackenzie
2018-02-12 20:45                 ` Stefan Monnier
2018-03-05  8:42                   ` Alan Mackenzie
2018-03-05 16:14                     ` Eli Zaretskii
2018-03-06 18:09                       ` Alan Mackenzie [this message]
2018-04-08 10:52                       ` Alan Mackenzie
2018-04-09 18:41                         ` Eli Zaretskii
2018-04-10 17:31                           ` Alan Mackenzie
2018-04-16 19:21                           ` bug#30393: 24.4; cperl-mode: indentation failure - Documentation enhancements Alan Mackenzie
2018-04-19  7:52                             ` Eli Zaretskii
2020-08-22 16:07                               ` Lars Ingebrigtsen
2020-11-03 13:45 ` bug#30393: [PATCH] Add a test to verify that the bug is gone (and a fix for Emacs 26) Harald Jörg
2020-11-03 14:29   ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180306180917.GA7774@ACM \
    --to=acm@muc.de \
    --cc=30393@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    --cc=eliz@gnu.org \
    --cc=monnier@IRO.UMontreal.CA \
    --cc=npostavs@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).