unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Bastian Beischer <bastian.beischer@gmail.com>
Cc: 30367@debbugs.gnu.org
Subject: bug#30367: 26.0.91; CC-Mode: Major slowdown when isearching big C++ file.
Date: Thu, 8 Feb 2018 17:25:58 +0000	[thread overview]
Message-ID: <20180208172558.GA4335__26357.2043077604$1518112391$gmane$org@ACM> (raw)
In-Reply-To: <CAK9AuB_oyuXRyxHRqBOYerfZjHGvOkiK2Xx3WGmBtuCmgTtBRw@mail.gmail.com>

Hello, Bastian.

On Wed, Feb 07, 2018 at 23:45:03 +0100, Bastian Beischer wrote:
> On Wed, Feb 7, 2018 at 11:26 PM, Alan Mackenzie <acm@muc.de> wrote:
> > Hello, Bastian.

[ .... ]

> >> then search for 'isinsha'.

> > Yes, searching for "isinsha", I see the slowdown.  Thanks!  I also see
> > c-looking-at-or-maybe-in-bracelist as taking an excessive amount of
> > processing.

> > So I can reproduce it!

> Great, so our results are consistent.

I think I understand what's happening, now.

c-looking-at-or-maybe-in-bracelist attempts to go back over the innards
of a brace list to the enclosing "{".  At L+122, in new handling for a
comma, I rather rashly inserted a `c-go-up-list-backward' to test whether
the comma is inside a brace.  This was in a loop, once for each sexp.

In your sample file there is, at L10,653 a construct at top level with
_lots_ of commas.  My loop is trying to go to the non-existent containing
brace for each of these commas, so ends up scanning to BOB for each of
them.  This entire activity will be being done several times.

I timed a single `c-go-up-list-backward' from one of these commas at
0.033 seconds.  30 of these take about a second, and my machine is
anything but slow.

So, I just need to work out a way of fixing this, which may take some
while (sorry).

Thanks again for reporting the bug.

[ .... ]

> Cheers
> Bastian

-- 
Alan Mackenzie (Nuremberg, Germany).





  reply	other threads:[~2018-02-08 17:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-06 10:34 bug#30367: 26.0.91; CC-Mode: Major slowdown when isearching big C++ file Bastian Beischer
2018-02-06 10:40 ` Bastian Beischer
     [not found] ` <mailman.8662.1517913372.27995.bug-gnu-emacs@gnu.org>
2018-02-07 15:24   ` Alan Mackenzie
     [not found]   ` <20180207152435.72040.qmail@mail.muc.de>
2018-02-07 15:27     ` Bastian Beischer
2018-02-07 21:21       ` Alan Mackenzie
     [not found]       ` <20180207212145.GA3963@ACM>
2018-02-07 21:53         ` Bastian Beischer
2018-02-07 22:26           ` Alan Mackenzie
2018-02-07 22:45             ` Bastian Beischer
2018-02-08 17:25               ` Alan Mackenzie [this message]
     [not found]               ` <20180208172558.GA4335@ACM>
2018-02-08 18:42                 ` Alan Mackenzie
     [not found]                 ` <20180208184232.GB4335@ACM>
2018-02-09  9:16                   ` Bastian Beischer
2018-03-20 18:49                     ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='20180208172558.GA4335__26357.2043077604$1518112391$gmane$org@ACM' \
    --to=acm@muc.de \
    --cc=30367@debbugs.gnu.org \
    --cc=bastian.beischer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).