From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#30186: 27.0.50; Password is not hidden in read-passwd Date: Sat, 27 Jan 2018 13:38:02 +0000 Message-ID: <20180127133802.GA4594@ACM> References: <87y3kp8thj.fsf@mail.linkov.net> <87372w8ddp.fsf@mail.linkov.net> <20180125173937.GA3857@ACM> <87vafp7i82.fsf@mail.linkov.net> <20180126183702.GA5056@ACM> <831sicl9p3.fsf@gnu.org> <20180126200027.GB5056@ACM> <83r2qbk5bf.fsf@gnu.org> <20180127113713.GB4049@ACM> <83d11vjxrw.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1517060734 1053 195.159.176.226 (27 Jan 2018 13:45:34 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 27 Jan 2018 13:45:34 +0000 (UTC) User-Agent: Mutt/1.7.2 (2016-11-26) Cc: 30186@debbugs.gnu.org To: Eli Zaretskii , juri@linkov.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 27 14:45:29 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efQn6-00079Q-Py for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Jan 2018 14:45:08 +0100 Original-Received: from localhost ([::1]:49420 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1efQp7-0000Sg-F2 for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Jan 2018 08:47:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51041) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1efQp1-0000Rt-EJ for bug-gnu-emacs@gnu.org; Sat, 27 Jan 2018 08:47:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1efQow-0000PZ-KN for bug-gnu-emacs@gnu.org; Sat, 27 Jan 2018 08:47:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36580) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1efQow-0000PT-Fw for bug-gnu-emacs@gnu.org; Sat, 27 Jan 2018 08:47:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1efQow-0002f5-9E for bug-gnu-emacs@gnu.org; Sat, 27 Jan 2018 08:47:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Jan 2018 13:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30186 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30186-submit@debbugs.gnu.org id=B30186.151706077210166 (code B ref 30186); Sat, 27 Jan 2018 13:47:02 +0000 Original-Received: (at 30186) by debbugs.gnu.org; 27 Jan 2018 13:46:12 +0000 Original-Received: from localhost ([127.0.0.1]:44477 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efQo8-0002dt-3P for submit@debbugs.gnu.org; Sat, 27 Jan 2018 08:46:12 -0500 Original-Received: from colin.muc.de ([193.149.48.1]:30295 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1efQo6-0002dk-E4 for 30186@debbugs.gnu.org; Sat, 27 Jan 2018 08:46:11 -0500 Original-Received: (qmail 75782 invoked by uid 3782); 27 Jan 2018 13:46:08 -0000 Original-Received: from acm.muc.de (p548C7E39.dip0.t-ipconnect.de [84.140.126.57]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sat, 27 Jan 2018 14:46:07 +0100 Original-Received: (qmail 4642 invoked by uid 1000); 27 Jan 2018 13:38:02 -0000 Content-Disposition: inline In-Reply-To: <83d11vjxrw.fsf@gnu.org> X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142582 Archived-At: Hello, Eli and Juri. On Sat, Jan 27, 2018 at 14:23:31 +0200, Eli Zaretskii wrote: > > Date: Sat, 27 Jan 2018 11:37:13 +0000 > > Cc: juri@linkov.net, 30186@debbugs.gnu.org > > From: Alan Mackenzie [ .... ] > > So, I'm changing my mind, after looking into it a bit more. > > Removing the with-silent-modifications from > > remove-yank-excluded-properties would not slow down undo in CC Mode > > buffers noticeably. > So let's do that now. I think the problem with read-passwd is a > security issue, so it should go to emacs-26, do you agree? Yes, i think it should go into emacs-26. Juri, do you see any problem with just removing that with-silent-modifications altogether? I.e. this: Allow read-passwd to hide characters inserted by C-y. (Security fix.) This fixes bug #30186. The with-silent-modifications was there to prevent records of text property manipulations being put into buffer-undo-list. These had been causing a significant slowdown in CC Mode with C-_ after a large C-y. This CC Mode problem has since been solved by a different workaround. * lisp/subr.el (remove-yank-excluded-properties): Remove the invocation of with-silent-modifications around the text property manipulations. diff --git a/lisp/subr.el b/lisp/subr.el index 052d9cd821..64cbbd52ab 100644 --- a/lisp/subr.el +++ b/lisp/subr.el @@ -3019,10 +3019,9 @@ remove-yank-excluded-properties run-start prop nil end))) (funcall fun value run-start run-end) (setq run-start run-end))))) - (with-silent-modifications - (if (eq yank-excluded-properties t) - (set-text-properties start end nil) - (remove-list-of-text-properties start end yank-excluded-properties))))) + (if (eq yank-excluded-properties t) + (set-text-properties start end nil) + (remove-list-of-text-properties start end yank-excluded-properties)))) (defvar yank-undo-function) [ .... ] -- Alan Mackenzie (Nuremberg, Germany).