unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Eli Zaretskii <eliz@gnu.org>, juri@linkov.net
Cc: 30186@debbugs.gnu.org
Subject: bug#30186: 27.0.50; Password is not hidden in read-passwd
Date: Sat, 27 Jan 2018 13:38:02 +0000	[thread overview]
Message-ID: <20180127133802.GA4594@ACM> (raw)
In-Reply-To: <83d11vjxrw.fsf@gnu.org>

Hello, Eli and Juri.

On Sat, Jan 27, 2018 at 14:23:31 +0200, Eli Zaretskii wrote:
> > Date: Sat, 27 Jan 2018 11:37:13 +0000
> > Cc: juri@linkov.net, 30186@debbugs.gnu.org
> > From: Alan Mackenzie <acm@muc.de>

[ .... ]

> > So, I'm changing my mind, after looking into it a bit more.
> > Removing the with-silent-modifications from
> > remove-yank-excluded-properties would not slow down undo in CC Mode
> > buffers noticeably.

> So let's do that now.  I think the problem with read-passwd is a
> security issue, so it should go to emacs-26, do you agree?

Yes, i think it should go into emacs-26.

Juri, do you see any problem with just removing that
with-silent-modifications altogether?  I.e. this:



Allow read-passwd to hide characters inserted by C-y.  (Security fix.)

This fixes bug #30186.  The with-silent-modifications was there to prevent
records of text property manipulations being put into buffer-undo-list.  These
had been causing a significant slowdown in CC Mode with C-_ after a large
C-y.  This CC Mode problem has since been solved by a different workaround.

* lisp/subr.el (remove-yank-excluded-properties): Remove the invocation of
with-silent-modifications around the text property manipulations.



diff --git a/lisp/subr.el b/lisp/subr.el
index 052d9cd821..64cbbd52ab 100644
--- a/lisp/subr.el
+++ b/lisp/subr.el
@@ -3019,10 +3019,9 @@ remove-yank-excluded-properties
                           run-start prop nil end)))
             (funcall fun value run-start run-end)
             (setq run-start run-end)))))
-    (with-silent-modifications
-      (if (eq yank-excluded-properties t)
-          (set-text-properties start end nil)
-        (remove-list-of-text-properties start end yank-excluded-properties)))))
+    (if (eq yank-excluded-properties t)
+        (set-text-properties start end nil)
+      (remove-list-of-text-properties start end yank-excluded-properties))))
 
 (defvar yank-undo-function)
 

[ .... ]


-- 
Alan Mackenzie (Nuremberg, Germany).





  reply	other threads:[~2018-01-27 13:38 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-20 21:29 bug#30186: 27.0.50; Password is not hidden in read-passwd Juri Linkov
2018-01-21 15:59 ` Eli Zaretskii
2018-01-21 21:19   ` Juri Linkov
2018-01-22 18:27     ` Glenn Morris
2018-01-22 18:45       ` Glenn Morris
2018-01-22 21:38         ` Juri Linkov
2018-01-23 21:38           ` Juri Linkov
2018-01-25 17:39             ` Alan Mackenzie
2018-01-25 21:15               ` Juri Linkov
2018-01-26 18:37                 ` Alan Mackenzie
2018-01-26 19:08                   ` Eli Zaretskii
2018-01-26 20:00                     ` Alan Mackenzie
2018-01-27  9:40                       ` Eli Zaretskii
2018-01-27 11:37                         ` Alan Mackenzie
2018-01-27 12:23                           ` Eli Zaretskii
2018-01-27 13:38                             ` Alan Mackenzie [this message]
2018-01-27 21:43                               ` Juri Linkov
2018-01-27 22:10                                 ` Alan Mackenzie
2018-01-27  8:27                   ` martin rudalics
2018-01-27  9:21                     ` Alan Mackenzie
2018-01-30  8:30                       ` martin rudalics
2018-01-22  1:53 ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180127133802.GA4594@ACM \
    --to=acm@muc.de \
    --cc=30186@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).