From: Alan Third <alan@idiocy.org>
To: Keith David Bershatsky <esq@lawlist.com>
Cc: 29233@debbugs.gnu.org, 16856@debbugs.gnu.org,
david.reitter@gmail.com, andlind@gmail.com
Subject: bug#29233: Enable fringe cursor when *almost* exact_window_width_line_p
Date: Thu, 9 Nov 2017 22:11:42 +0000 [thread overview]
Message-ID: <20171109221142.GA680@breton.holly.idiocy.org> (raw)
In-Reply-To: <m2wp2z70ce.wl%esq@lawlist.com>
[-- Attachment #1: Type: text/plain, Size: 1273 bytes --]
On Thu, Nov 09, 2017 at 10:50:41AM -0800, Keith David Bershatsky wrote:
> For those users who wish to customize the frame width pixelwise to a
> size such that exact_window_width_line_p will _never_ be true, those
> users miss out on the joy of seeing the fringe cursor bitmap. While
> the patch that was applied pursuant to Bug#16856 fixed the problem
> with the cursor being drawn on top of the fringe
> (e5015c5d9632a0bf685c093249ae4a7d3e825b13), it does not permit a
> fringe bitmap to be placed there instead.
>
> If I had it to do all over again, I would have made the following
> two modifications. [I have not yet experimented with xterm.c and
> w32term.c to see if the new condition should be added there as well
> for Emacs platform builds on Windows and X11.]
This needs a bit more work I’m afraid. If you’re using a bar cursor it
can seem like it’s putting the cursor into the fringe somewhat
prematurely. I think it should be using the width of the cursor rather
than the glyph width.
Additionally I’ve attached a screenshot of the cursor in the fringe
when it shouldn’t be. It should appear over the last x on the line
(point is before the last x on the line).
David, I can’t replicate junk in the fringe. Do you have a recipe?
--
Alan Third
[-- Attachment #2: fringe-cursor.png --]
[-- Type: image/png, Size: 5035 bytes --]
next prev parent reply other threads:[~2017-11-09 22:11 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-23 21:39 bug#16856: 24.3.50; Cursor leaves garbage in fringe (and a request: width of fringes + scroll bar should be full characters) Anders Lindgren
2014-02-24 3:44 ` Eli Zaretskii
2014-02-24 7:41 ` martin rudalics
2014-02-24 10:12 ` Anders Lindgren
2014-02-24 10:53 ` martin rudalics
2014-02-24 15:12 ` Anders Lindgren
2014-02-26 10:15 ` martin rudalics
2014-02-26 12:51 ` Anders Lindgren
2016-05-17 18:30 ` Alan Third
2016-05-17 19:06 ` Anders Lindgren
2016-05-17 21:14 ` bug#16856: [PATCH] Prevent cursor from over-drawing the fringe Alan Third
2016-05-20 19:33 ` Anders Lindgren
2016-05-21 7:35 ` Alan Third
2016-05-21 19:07 ` Anders Lindgren
2016-07-17 6:57 ` bug#16856: 24.3.50; Cursor leaves garbage in fringe David Reitter
2017-11-09 18:50 ` bug#16856: Enable fringe cursor when *almost* exact_window_width_line_p Keith David Bershatsky
2017-11-09 18:58 ` bug#29233: " Keith David Bershatsky
2017-11-09 22:11 ` Alan Third [this message]
2017-11-10 7:53 ` bug#16856: " Eli Zaretskii
2017-11-11 16:34 ` Anders Lindgren
2017-11-11 17:25 ` Eli Zaretskii
2017-11-11 17:49 ` Anders Lindgren
2017-11-11 18:46 ` Alan Third
2017-11-11 20:36 ` Anders Lindgren
2017-11-10 0:31 ` bug#29233: " Keith David Bershatsky
2017-11-11 22:33 ` Keith David Bershatsky
2017-11-12 4:10 ` Eli Zaretskii
2017-12-12 23:24 ` Noam Postavsky
2017-11-09 19:00 ` bug#16856: Cursor leaves garbage in fringe Keith David Bershatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171109221142.GA680@breton.holly.idiocy.org \
--to=alan@idiocy.org \
--cc=16856@debbugs.gnu.org \
--cc=29233@debbugs.gnu.org \
--cc=andlind@gmail.com \
--cc=david.reitter@gmail.com \
--cc=esq@lawlist.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).