From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Max Newsgroups: gmane.emacs.bugs Subject: bug#29094: dired-do-compress creates empty archives Date: Wed, 1 Nov 2017 02:33:59 +0300 Message-ID: <20171031233359.GA44370@magi.net.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Trace: blaine.gmane.org 1509494535 5044 195.159.176.226 (1 Nov 2017 00:02:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 1 Nov 2017 00:02:15 +0000 (UTC) To: 29094@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 01 01:02:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9gTv-0000X3-8h for geb-bug-gnu-emacs@m.gmane.org; Wed, 01 Nov 2017 01:02:07 +0100 Original-Received: from localhost ([::1]:47768 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e9gU2-0000Hl-Oo for geb-bug-gnu-emacs@m.gmane.org; Tue, 31 Oct 2017 20:02:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39089) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e9gTu-0000Hd-D2 for bug-gnu-emacs@gnu.org; Tue, 31 Oct 2017 20:02:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e9gTr-0005XD-9U for bug-gnu-emacs@gnu.org; Tue, 31 Oct 2017 20:02:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36089) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e9gTr-0005X1-31 for bug-gnu-emacs@gnu.org; Tue, 31 Oct 2017 20:02:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e9gTq-0002w5-LP for bug-gnu-emacs@gnu.org; Tue, 31 Oct 2017 20:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Max Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 01 Nov 2017 00:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 29094 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.150949446411206 (code B ref -1); Wed, 01 Nov 2017 00:02:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 1 Nov 2017 00:01:04 +0000 Original-Received: from localhost ([127.0.0.1]:44770 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9gSu-0002ug-0r for submit@debbugs.gnu.org; Tue, 31 Oct 2017 20:01:04 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:43560) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9g2w-0002Gz-Ik for submit@debbugs.gnu.org; Tue, 31 Oct 2017 19:34:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e9g2q-0005jF-Ep for submit@debbugs.gnu.org; Tue, 31 Oct 2017 19:34:09 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:57147) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e9g2q-0005j9-B2 for submit@debbugs.gnu.org; Tue, 31 Oct 2017 19:34:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34529) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e9g2o-00051n-UP for bug-gnu-emacs@gnu.org; Tue, 31 Oct 2017 19:34:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e9g2l-0005hx-QN for bug-gnu-emacs@gnu.org; Tue, 31 Oct 2017 19:34:06 -0400 Original-Received: from magi.net.ru ([188.134.66.188]:44734) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e9g2l-0005gq-Fd for bug-gnu-emacs@gnu.org; Tue, 31 Oct 2017 19:34:03 -0400 Original-Received: from magi.net.ru (localhost [127.0.0.1]) by magi.net.ru (OpenSMTPD) with ESMTP id d3483de0 for ; Wed, 1 Nov 2017 02:33:59 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=magi.net.ru; h=date:from :to:subject:message-id:mime-version:content-type; s=mail; bh=N+U FdCmEzqb82TXfdxm+6w6cFhU=; b=JRsltgl4wovY+Man0/mNcrSgOkyMNooiS6V GHXCMhgEKeTgQXN0kqRgqufKfd5L340S9joXf+SSF8rpE1Gfcgmw6c+BXQjQU6NC A9Qymf0wj3ujmRb4cPwfZseMwVBtDt5Rfb4xHuoLg7C//aPR5bcJL+/RwPu5TIIK soHY3bOM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=magi.net.ru; h=date:from:to :subject:message-id:mime-version:content-type; q=dns; s=mail; b= P1kn7NRUX18XlocwIN2YKnPdfoi4IA4T18nrIneCQtwohtSO4hjS2BITaP3mIVyJ VamDU5qyW4f0bvUF/xjD0wF7Uv5ttlGqWf2MKiOkD+PsMsTlIkU7hArUUHNDzgio z+3WFYfMkECmbCH6OA0nRWDil6ahovk7Z2Eeei0eGkQ= Original-Received: from localhost (magi.net.ru [local]) by magi.net.ru (OpenSMTPD) with ESMTPA id 2fdc6c0e for ; Wed, 1 Nov 2017 02:33:59 +0300 (MSK) Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Mailman-Approved-At: Tue, 31 Oct 2017 20:01:02 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139297 Archived-At: Hi, When Z is pressed on a directory, dired (according to dired-compress-file-suffixes variable) runs the following command: tar -c directory | gzip -c9 > directory.tar.gz On my system running this command results in an error: tar: Failed open to write on /dev/rst0: Permission denied as tar(1) defaults -f to /dev/rst0. Argument '-f-' should be used to write to stdout. Also '-v' is probably not needed here, since the output is not used anywhere. Here is a patch to correct this behaviour: diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el index 94938cf679..14f4be07be 100644 --- a/lisp/dired-aux.el +++ b/lisp/dired-aux.el @@ -974,8 +974,8 @@ command with a prefix argument (the value does not matter)." ;; "tar -zxf" isn't used because it's not available on the ;; Solaris10 version of tar. Solaris10 becomes obsolete in 2021. ;; Same thing on AIX 7.1. - ("\\.tar\\.gz\\'" "" "gzip -dc %i | tar -xv") - ("\\.tgz\\'" "" "gzip -dc %i | tar -xv") + ("\\.tar\\.gz\\'" "" "gzip -dc %i | tar -xf -") + ("\\.tgz\\'" "" "gzip -dc %i | tar -xf -") ("\\.gz\\'" "" "gunzip") ("\\.Z\\'" "" "uncompress") ;; For .z, try gunzip. It might be an old gzip file, @@ -990,7 +990,7 @@ command with a prefix argument (the value does not matter)." ;; This item controls naming for compression. ("\\.tar\\'" ".tgz" nil) ;; This item controls the compression of directories - (":" ".tar.gz" "tar -c %i | gzip -c9 > %o")) + (":" ".tar.gz" "tar -cf - %i | gzip -c9 > %o")) "Control changes in file name suffixes for compression and uncompression. Each element specifies one transformation rule, and has the form: (REGEXP NEW-SUFFIX PROGRAM) @@ -1007,9 +1007,9 @@ Otherwise, the rule is a compression rule, and compression is done with gzip. ARGS are command switches passed to PROGRAM.") (defvar dired-compress-files-alist - '(("\\.tar\\.gz\\'" . "tar -c %i | gzip -c9 > %o") - ("\\.tar\\.bz2\\'" . "tar -c %i | bzip2 -c9 > %o") - ("\\.tar\\.xz\\'" . "tar -c %i | xz -c9 > %o") + '(("\\.tar\\.gz\\'" . "tar -cf - %i | gzip -c9 > %o") + ("\\.tar\\.bz2\\'" . "tar -cf - %i | bzip2 -c9 > %o") + ("\\.tar\\.xz\\'" . "tar -cf - %i | xz -c9 > %o") ("\\.zip\\'" . "zip %o -r --filesync %i")) "Control the compression shell command for `dired-do-compress-to'.