unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Richard Copley <rcopley@gmail.com>, 29024@debbugs.gnu.org
Subject: bug#29024: CC-mode infinite loop on typing < in template spec
Date: Fri, 27 Oct 2017 13:40:36 +0000	[thread overview]
Message-ID: <20171027134035.GA3933@ACM> (raw)
In-Reply-To: <83o9ot6lkw.fsf@gnu.org>

Hello, Eli.

On Fri, Oct 27, 2017 at 11:28:47 +0300, Eli Zaretskii wrote:
> > From: Richard Copley <rcopley@gmail.com>
> > Date: Fri, 27 Oct 2017 08:40:45 +0100

> > #29024 appears to be the same bug as #28926.

> Strangely enough, with today's emacs-26 branch, I cannot reproduce
> either of those two recipes.  I can reproduce them with stock 26.0.90
> pretest, though.  Maybe this only happens in optimized builds?

> Alan, are you looking into this?

I think I fixed it last Sunday (though I haven't checked properly yet),
with the following commit to the emacs-26 branch:

  commit b7c4aa951c8b12629742df9d20d6374c3d2a8ba8
  Date:   Sun Oct 22 14:18:20 2017 +0000

  Refactor c-forward-token-2 with new function c-forward-over-token-and-ws.

  Use the new function directly in several places where c-forward-token-2
  wouldn't move over the last token in the buffer.  This caused an infinite loop
  in c-restore-<>-properties.

Though, with the benefit of hindsight, the top line of the commit message
wasn't as helpful as it might have been.

Again, regrets that the bug happened at all.

-- 
Alan Mackenzie (Nuremberg, Germany).





      parent reply	other threads:[~2017-10-27 13:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-27  7:28 bug#29024: CC-mode infinite loop on typing < in template spec Richard Copley
2017-10-27  7:40 ` Richard Copley
2017-10-27  8:28   ` Eli Zaretskii
2017-10-27  8:33     ` Eli Zaretskii
2017-10-27 12:01       ` Richard Copley
2017-10-27 12:06         ` Richard Copley
2017-10-27 12:21           ` Noam Postavsky
2017-10-27 13:40     ` Alan Mackenzie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171027134035.GA3933@ACM \
    --to=acm@muc.de \
    --cc=29024@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=rcopley@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).