From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.bugs Subject: bug#28921: [PROPOSED] Fix xdg timestamp error on 32-bit Emacs Date: Sat, 21 Oct 2017 10:26:30 -0400 Message-ID: <20171021142630.4asr6z7qjfdxonzh@logos.localdomain> References: <20171021030455.16035-1-eggert@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1508596042 24790 195.159.176.226 (21 Oct 2017 14:27:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 21 Oct 2017 14:27:22 +0000 (UTC) User-Agent: NeoMutt/20171013 Cc: 28921@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 21 16:27:17 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e5ujx-00046a-If for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Oct 2017 16:27:05 +0200 Original-Received: from localhost ([::1]:57990 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e5uk3-0005Hh-Ep for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Oct 2017 10:27:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36570) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e5ujx-0005Hc-R5 for bug-gnu-emacs@gnu.org; Sat, 21 Oct 2017 10:27:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e5uju-0007ti-Ev for bug-gnu-emacs@gnu.org; Sat, 21 Oct 2017 10:27:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45759) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e5uju-0007td-Ax for bug-gnu-emacs@gnu.org; Sat, 21 Oct 2017 10:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e5uju-0000At-2W for bug-gnu-emacs@gnu.org; Sat, 21 Oct 2017 10:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mark Oteiza Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Oct 2017 14:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28921 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.1508596008650 (code B ref -1); Sat, 21 Oct 2017 14:27:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 21 Oct 2017 14:26:48 +0000 Original-Received: from localhost ([127.0.0.1]:54439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e5ujf-0000AQ-Om for submit@debbugs.gnu.org; Sat, 21 Oct 2017 10:26:47 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:45553) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e5ujd-0000AC-Ce for submit@debbugs.gnu.org; Sat, 21 Oct 2017 10:26:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e5ujX-0007mg-6O for submit@debbugs.gnu.org; Sat, 21 Oct 2017 10:26:40 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:33194) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e5ujX-0007mX-2l for submit@debbugs.gnu.org; Sat, 21 Oct 2017 10:26:39 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36518) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e5ujW-0005Fx-3F for bug-gnu-emacs@gnu.org; Sat, 21 Oct 2017 10:26:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e5ujS-0007lH-Uv for bug-gnu-emacs@gnu.org; Sat, 21 Oct 2017 10:26:38 -0400 Original-Received: from mail-qk0-x236.google.com ([2607:f8b0:400d:c09::236]:44793) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e5ujS-0007ke-ND for bug-gnu-emacs@gnu.org; Sat, 21 Oct 2017 10:26:34 -0400 Original-Received: by mail-qk0-x236.google.com with SMTP id r64so17428475qkc.1 for ; Sat, 21 Oct 2017 07:26:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=IfethB1WHr5ULwG/6skTc7WL8Nuvaur2EK0/AYiS0A8=; b=bSq8XQoME8q8P9uy2Qal70X9gJVLWYrJ1kiiFHJ+OIVZPNTx1oV97GmUgHhfhThVKb FtJtFcoQhOUbKj3safUV1Dka4rDMhfyrSWo/kXsZUP96b1rqPLUFReXzaLGtBHlHS/sM i3cdHQYFO3c2aHTeyvUAqSZq8xX5nuiBIkzP0ALV+5x8A9auDjf3/jfOv7Ct+AHudvi4 UUNWK70Ti4wxdVLwLTGh0sz4WylxzOfxPmTfLby9xuo8wXhagZZxwwgmQVVTkTul4Jwq v1QAe3jzbs+JJ8hgTh8nFaWsXozXJKRJXSSXehMzn1tcxWOcZzyhGn2YLYfySdJ+nkyg rslw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=IfethB1WHr5ULwG/6skTc7WL8Nuvaur2EK0/AYiS0A8=; b=Wbt2HDco5Gc1eHAHDGxoPMx3KCUEIXwDhZFe6g3RzM7+rQQB0OGexQT35kt9rikgyK CSTEFScH2v6qRAcHBUcD/PVSPtaNoH/Oy5N+gbUjxE0DeOnK9YW0MwC/GFpUTPe7rZ4/ Bx7nlfJPCZV0sAzOPw7Rb0L9LvhLEGww4SKzJvWj/dft2RLRm5nw9iEQCw0itL4Xqkl+ uucAMYCNGkNeIWqfUjStgd8Nhy37Em6SdPlvzj58taiZ+8sJFPZhbQjQ1C77SpazMyk3 JjN8ikQ6afzEhl3W1PlfqpZCR3jt4TP5R19rjLIFbG9AAqiBcb32PO2U9r435kOzw3YQ SfPA== X-Gm-Message-State: AMCzsaUB0/QAa2CKOez4Qmf2C2JqPVBmnJ0GQQoOJV1BA/K4Q4l8iXoI pKcvAD1rf5KvfwYsMPcKZGoisA== X-Google-Smtp-Source: ABhQp+Tr+QF+5nmFoIP/d7GGnn1ePfky+ZIW1pYW2Wbv1SlWR9nvkpyDxy45Fg9w/IqaKeCf5Nsn9A== X-Received: by 10.55.175.132 with SMTP id y126mr12056960qke.45.1508595992227; Sat, 21 Oct 2017 07:26:32 -0700 (PDT) Original-Received: from logos.localdomain (pool-173-67-36-61.bltmmd.fios.verizon.net. [173.67.36.61]) by smtp.gmail.com with ESMTPSA id n24sm2208207qta.94.2017.10.21.07.26.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 21 Oct 2017 07:26:31 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20171021030455.16035-1-eggert@cs.ucla.edu> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138815 Archived-At: On 20/10/17 at 08:04pm, Paul Eggert wrote: > * lisp/xdg.el (xdg-thumb-mtime): Return an Emacs timestamp, > not an integer. This avoids signaling an error on 32-bit > Emacs, where timestamps typically do not fit into fixnums. I had the following sitting in my tree, but I don't feel strongly either way. diff --git a/lisp/xdg.el b/lisp/xdg.el index 76106f4258..f57ed5e683 100644 --- a/lisp/xdg.el +++ b/lisp/xdg.el @@ -93,8 +93,8 @@ xdg-thumb-name (concat (md5 (xdg-thumb-uri filename)) ".png")) (defun xdg-thumb-mtime (filename) - "Return modification time of FILENAME as integral seconds from the epoch." - (floor (float-time (nth 5 (file-attributes filename))))) + "Return modification time of FILENAME as seconds from the epoch." + (ffloor (float-time (nth 5 (file-attributes filename))))) ;; XDG User Directories