From: Mark Oteiza <mvoteiza@udel.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Davor Rotim <rotim.davor@gmail.com>, 28809@debbugs.gnu.org
Subject: bug#28809: 26.0.90; Error running timer ‘image-dired-thumb-queue-run’
Date: Sat, 14 Oct 2017 17:24:59 -0400 [thread overview]
Message-ID: <20171014212459.zzzjveby4g32a35i@logos.localdomain> (raw)
In-Reply-To: <83mv4vjewg.fsf@gnu.org>
On 13/10/17 at 05:33pm, Eli Zaretskii wrote:
> > From: Davor Rotim <rotim.davor@gmail.com>
> > Date: Fri, 13 Oct 2017 15:33:24 +0200
> >
> > Started with emacs -Q, opened a dired buffer, navigated to an image and pressed C-t .
> > on it (image-dired-display-thumb) to generate a thumbnail. That leaves me with only an error message:
> >
> > Error running timer ‘image-dired-thumb-queue-run’: (range-error "floor" 1505334534.0059688)
>
> Mark, could you please look at this? You changed the code to use
> floor instead of rounding via format "%.0f", but floor returns an
> Emacs integer which can overflow on 32-bit hosts for large time
> values, as happens here. I think we should use ffloor instead, and if
> that produces a decimal point, eliminate it with "%.0f" format.
What you propose sounds fine to me.
next prev parent reply other threads:[~2017-10-14 21:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 13:33 bug#28809: 26.0.90; Error running timer ‘image-dired-thumb-queue-run’ Davor Rotim
2017-10-13 14:33 ` Eli Zaretskii
2017-10-14 21:24 ` Mark Oteiza [this message]
2017-10-16 16:28 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171014212459.zzzjveby4g32a35i@logos.localdomain \
--to=mvoteiza@udel.edu \
--cc=28809@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=rotim.davor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).