From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Vasilij Schneidermann Newsgroups: gmane.emacs.bugs Subject: bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions Date: Thu, 5 Oct 2017 22:08:07 +0200 Message-ID: <20171005200807.ysmclhv5cxuwsnap@odonien.localdomain> References: <83lglio36q.fsf@gnu.org> <20170924131050.6erv6sshvz23dlbu@odonien.localdomain> <838tgy9d18.fsf@gnu.org> <877ew9vqwv.fsf@mouse.gnus.org> <83vajtx3hu.fsf@gnu.org> <87wp49u9ki.fsf@mouse.gnus.org> <83shexwxce.fsf@gnu.org> <87lgkpu3tl.fsf@mouse.gnus.org> <83poa1wvxi.fsf@gnu.org> <87d161u2g8.fsf@mouse.gnus.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Trace: blaine.gmane.org 1507234163 17279 195.159.176.226 (5 Oct 2017 20:09:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 5 Oct 2017 20:09:23 +0000 (UTC) User-Agent: NeoMutt/20170714-155-820ab5 (1.8.3) Cc: 28402@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 05 22:09:19 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0CSJ-0003XO-F0 for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Oct 2017 22:09:15 +0200 Original-Received: from localhost ([::1]:41874 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0CSQ-00053d-TV for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Oct 2017 16:09:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41400) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0CSB-0004yJ-Tp for bug-gnu-emacs@gnu.org; Thu, 05 Oct 2017 16:09:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e0CS6-0000Uf-SR for bug-gnu-emacs@gnu.org; Thu, 05 Oct 2017 16:09:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43132) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e0CS6-0000UU-Od for bug-gnu-emacs@gnu.org; Thu, 05 Oct 2017 16:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e0CS6-00040A-E5 for bug-gnu-emacs@gnu.org; Thu, 05 Oct 2017 16:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Vasilij Schneidermann Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Oct 2017 20:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28402 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28402-submit@debbugs.gnu.org id=B28402.150723409815309 (code B ref 28402); Thu, 05 Oct 2017 20:09:02 +0000 Original-Received: (at 28402) by debbugs.gnu.org; 5 Oct 2017 20:08:18 +0000 Original-Received: from localhost ([127.0.0.1]:51813 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0CRO-0003yq-0i for submit@debbugs.gnu.org; Thu, 05 Oct 2017 16:08:18 -0400 Original-Received: from mail-wm0-f67.google.com ([74.125.82.67]:37244) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0CRM-0003yc-4V for 28402@debbugs.gnu.org; Thu, 05 Oct 2017 16:08:16 -0400 Original-Received: by mail-wm0-f67.google.com with SMTP id k66so5647821wmd.4 for <28402@debbugs.gnu.org>; Thu, 05 Oct 2017 13:08:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Kap/BqSbNfgp+UnODvzjy9qOSmcYkjCGhK39LcmqCuM=; b=R0v2CxWsMfrTJzMR3Jm7qT05TC5KXr6r1ILAZkBjAsxWNEPTMs9e7sWJYm4ljVrLqa 5oGdtEaJPkjfuZ1CVA4XkK80TqbvwfNph+eAD4FJtd8jCE8D5v7A6U891KsIut7RYIJm htVkrDDo3YHYVBja+Pw251CkL2ZWk5p2JlaUXtyJ6G8D9TB7n9WM5IwydITEFCdxoBsp d54ThHpSENp8D0ewYP6uLSNa9fe+Ei+PDh2BJqw3R9HWXQ7PcfuWuf0+V4qKsKjAqfXC 87PuXtXGKlxVP3G1ip4fKFTv/LDMuclCg52jFBz/JJhnY3F17OAp40u94i5sKmYNYSa+ Wxdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Kap/BqSbNfgp+UnODvzjy9qOSmcYkjCGhK39LcmqCuM=; b=aIYHM99LStPNn2IGFE18gFNJeEJvPPepEQ5ue/sH+8Wejt2eSogQLl8bN9QQTAwjo3 UTCFXCVa4wjzoFjTUl7V92WT6/Yuzrv0gfalJTIMz8BxCcSC1d8xpWKTe3elodQXLJE+ 831KXYHXDcyUI09Zqy3dVrPaDBD/y+EFQpys3JKESskhXHfMKVm//pdscj/reNPS8kh4 ZnXeTlkMomCxoJWM/YYpkiBTUdtAjmO9RWzig1qyODAhNtVRnceSIXmRiY8BzMc4lQ3z Dr123GmuVZjbQqNy3h73Fp0nUOiecmTS2yOighLHpjHKotwpwRsN0Fljti5xfDVDfmYZ h0qQ== X-Gm-Message-State: AMCzsaVG/pPFWrqU6pg/TZ6SqbZUQehnyJ2U1zPObblMzo611gy8FVCE bjLCnNDDRP2WZLOd6MK1vRU= X-Google-Smtp-Source: AOwi7QClazlCYauNCaeH++G+fWQm+bfqdkyw978GdrqkZnipIeoXtw6GRsGgjKj7EGyA+MUl95V08w== X-Received: by 10.80.224.193 with SMTP id j1mr306665edl.216.1507234090280; Thu, 05 Oct 2017 13:08:10 -0700 (PDT) Original-Received: from localhost (dslb-092-072-005-245.092.072.pools.vodafone-ip.de. [92.72.5.245]) by smtp.gmail.com with ESMTPSA id q6sm93391edk.55.2017.10.05.13.08.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 05 Oct 2017 13:08:09 -0700 (PDT) Content-Disposition: inline In-Reply-To: <87d161u2g8.fsf@mouse.gnus.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:137985 Archived-At: > In a thing like shr, it's really the case of a death by a thousand cuts: > Each single improvement adds a slight performance hit, and then after a > couple of years you end up with something that's pretty, but completely > unusable. (It's already too slow as it is.) So I protect `shr-descend' > fiercely. :-) How deeply nested does typical HTML get anyways? I recall an exemplary comment from an article on browser rendering that pointed out that they bail out on degenerate cases, so perhaps it's better to add that to shr rather than hoping you never hit the stack limit by following a conservative coding style. Regarding speed, I only notice it being an issue for documents with tables, everything else is fine. > (But late, as always... Sorry for not saying this before you applied > the patch; it would have been less work for all of us.) I can imagine other variations of defsubst (such as defmacro and define-inline), but it would indeed be the easiest to roll back that part of the code. What I'd additionally do is adding a comment explaining why there's two very similar snippets of code doing the same thing, otherwise the next person proposing a patch will change only one of them and be left head-scratching why it doesn't quite work.