unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Third <alan@idiocy.org>
To: "Charles A. Roelli" <charles@aurox.ch>
Cc: 27706@debbugs.gnu.org
Subject: bug#27706: MacOS: decode-time hang
Date: Sat, 30 Sep 2017 21:21:02 +0100	[thread overview]
Message-ID: <20170930202102.GA885@breton.holly.idiocy.org> (raw)
In-Reply-To: <m2zi9cknqj.fsf@aurox.ch>

On Sat, Sep 30, 2017 at 09:09:08PM +0200, Charles A. Roelli wrote:
> +                     (if (and (featurep 'ns)
> +                              (string-match-p
> +                               "10\\.6\\.[[:digit:]]"
> +                               (shell-command-to-string
> +                                "sw_vers -productVersion")))

I can’t speak for the issue generally as I don’t know what this code
does, but this particular check looks incorrect to me.

sw_vers doesn’t exist on GNU/Linux, and probably other platforms that
GNUstep runs on, so you can’t just use a check for NS. Probably you
need to check for Darwin, which should work on terminal only versions
of Emacs too.

    (string-equal system-type "darwin")

(There may be other ways to check, this is the only one I know.)
-- 
Alan Third





  reply	other threads:[~2017-09-30 20:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-15 14:19 bug#27706: MacOS: decode-time hang Charles A. Roelli
2017-07-15 21:32 ` Alan Third
2017-07-16 16:11   ` Charles A. Roelli
2017-09-30 19:09 ` Charles A. Roelli
2017-09-30 20:21   ` Alan Third [this message]
2017-09-30 21:21     ` Noam Postavsky
2017-10-01  9:27       ` Charles A. Roelli
2017-10-01 17:11         ` Charles A. Roelli
2017-10-07 15:33           ` Charles A. Roelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170930202102.GA885@breton.holly.idiocy.org \
    --to=alan@idiocy.org \
    --cc=27706@debbugs.gnu.org \
    --cc=charles@aurox.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).