From: Mark Oteiza <mvoteiza@udel.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 22689@debbugs.gnu.org
Subject: bug#22689: [PATCH] Add logcount
Date: Sat, 30 Sep 2017 12:03:31 -0400 [thread overview]
Message-ID: <20170930160331.ibxxjh626jrlm4ef@logos.localdomain> (raw)
In-Reply-To: <838tgw42ol.fsf@gnu.org>
On 30/09/17 at 06:38pm, Eli Zaretskii wrote:
> > Date: Sat, 30 Sep 2017 10:55:25 -0400
> > From: Mark Oteiza <mvoteiza@udel.edu>
> > Cc: 22689@debbugs.gnu.org
> >
> > > Btw, on Windows, a long is a 32-bit type, so I think we need
> > > to check against ULONG_LONG_MAX as well.
> >
> > I tried implementing your comments (and added a test). I don't know
> > what to do in the #else for ULONG_LONG_MAX.
>
> Same as you do for ULONG_MAX, I think.
so the following?
else if (v <= ULONG_MAX || v <= ULONG_LONG_MAX)
XSETINT (res, logcount64 (v));
next prev parent reply other threads:[~2017-09-30 16:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 23:18 bug#22689: 25.1.50; implement logcount Mark Oteiza
2017-09-29 17:41 ` bug#22689: [PATCH] Add logcount Mark Oteiza
2017-09-30 11:42 ` Eli Zaretskii
2017-09-30 13:16 ` Mark Oteiza
2017-09-30 13:59 ` Eli Zaretskii
2017-09-30 14:55 ` Mark Oteiza
2017-09-30 15:38 ` Eli Zaretskii
2017-09-30 16:03 ` Mark Oteiza [this message]
2017-09-30 16:17 ` Eli Zaretskii
2017-09-30 17:07 ` Mark Oteiza
2017-09-30 17:53 ` Eli Zaretskii
2017-09-30 18:18 ` Mark Oteiza
2017-09-30 16:50 ` Benjamin Riefenstahl
2017-09-30 16:59 ` Mark Oteiza
2017-09-30 22:48 ` Paul Eggert
2017-09-30 23:22 ` Mark Oteiza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170930160331.ibxxjh626jrlm4ef@logos.localdomain \
--to=mvoteiza@udel.edu \
--cc=22689@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).