From: Alan Mackenzie <acm@muc.de>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: John Wiegley <jwiegley@gmail.com>,
Philipp Stephani <p.stephani2@gmail.com>,
22983@debbugs.gnu.org
Subject: bug#22983: [ Patch ] Re: bug#22983: syntax-ppss returns wrong result.
Date: Sun, 24 Sep 2017 11:26:37 +0000 [thread overview]
Message-ID: <20170924112637.GA5725@ACM> (raw)
In-Reply-To: <8819156d-b58f-f87f-14b1-5e347202c752@yandex.ru>
Hello, Dmitry.
On Fri, Sep 22, 2017 at 17:09:03 +0300, Dmitry Gutov wrote:
> Hi Alan,
> On 9/19/17 11:47 PM, Alan Mackenzie wrote:
> > I have done now, without the slightest cause for concern (see below).
> Thank you. Should you commit the patch (with any documentation tweaks
> you deem necessary), or should I?
Could I ask you to do it, please? I'm somewhat exhausted from debating
another basic Emacs change.
Ah yes, the documentation. I checked the doc in the elisp manual, and
twice the phrase "from the beginning of the buffer" was used. I've
clarified that with "from the beginning of the visible portion of the
buffer". I've also amended "a cache" to "caches", though this doesn't
seem too important. What do you think:
diff --git a/doc/lispref/syntax.texi b/doc/lispref/syntax.texi
index e3ae53536f..b37f2b22b8 100644
--- a/doc/lispref/syntax.texi
+++ b/doc/lispref/syntax.texi
@@ -751,7 +751,8 @@ Position Parse
@defun syntax-ppss &optional pos
This function returns the parser state that the parser would reach at
-position @var{pos} starting from the beginning of the buffer.
+position @var{pos} starting from the beginning of the visible portion
+of the buffer.
@iftex
See the next section for
@end iftex
@@ -762,11 +763,11 @@ Position Parse
The return value is the same as if you call the low-level parsing
function @code{parse-partial-sexp} to parse from the beginning of the
-buffer to @var{pos} (@pxref{Low-Level Parsing}). However,
-@code{syntax-ppss} uses a cache to speed up the computation. Due to
-this optimization, the second value (previous complete subexpression)
-and sixth value (minimum parenthesis depth) in the returned parser
-state are not meaningful.
+visible portion of the buffer to @var{pos} (@pxref{Low-Level
+Parsing}). However, @code{syntax-ppss} uses caches to speed up the
+computation. Due to this optimization, the second value (previous
+complete subexpression) and sixth value (minimum parenthesis depth) in
+the returned parser state are not meaningful.
This function has a side effect: it adds a buffer-local entry to
@code{before-change-functions} (@pxref{Change Hooks}) for
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2017-09-24 11:26 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 15:15 bug#22983: syntax-ppss returns wrong result Alan Mackenzie
2016-03-11 20:31 ` Dmitry Gutov
2016-03-11 21:24 ` Alan Mackenzie
2016-03-11 21:35 ` Dmitry Gutov
2016-03-11 22:15 ` Alan Mackenzie
2016-03-11 22:38 ` Dmitry Gutov
2016-03-13 17:37 ` Stefan Monnier
2016-03-13 18:57 ` Alan Mackenzie
2016-03-14 0:47 ` Dmitry Gutov
2016-03-14 1:04 ` Drew Adams
2016-04-03 22:55 ` John Wiegley
2016-03-14 1:49 ` Stefan Monnier
2016-03-13 17:32 ` Stefan Monnier
2016-03-13 18:52 ` Andreas Röhler
2016-03-13 18:56 ` Dmitry Gutov
2016-03-18 0:49 ` Dmitry Gutov
2016-03-19 12:27 ` Alan Mackenzie
2016-03-19 18:47 ` Dmitry Gutov
2016-03-27 0:51 ` John Wiegley
2016-03-27 1:14 ` Dmitry Gutov
2016-04-03 22:58 ` John Wiegley
2016-04-03 23:15 ` Dmitry Gutov
2017-09-02 13:12 ` Eli Zaretskii
2017-09-02 17:40 ` Alan Mackenzie
2017-09-02 17:53 ` Eli Zaretskii
2017-09-03 20:44 ` John Wiegley
2017-09-04 23:34 ` Dmitry Gutov
2017-09-05 6:57 ` Andreas Röhler
2017-09-05 12:28 ` John Wiegley
2017-09-07 20:45 ` Alan Mackenzie
2017-09-08 16:04 ` Andreas Röhler
2017-09-10 18:26 ` Alan Mackenzie
2017-09-09 9:44 ` Dmitry Gutov
2017-09-09 10:20 ` Alan Mackenzie
2017-09-09 12:18 ` Dmitry Gutov
2017-09-10 11:42 ` Alan Mackenzie
2017-09-10 11:36 ` bug#22983: [ Patch ] " Alan Mackenzie
2017-09-10 22:53 ` Stefan Monnier
2017-09-10 23:36 ` Dmitry Gutov
2017-09-11 11:10 ` Stefan Monnier
2017-09-12 0:11 ` Dmitry Gutov
2017-09-12 22:12 ` Richard Stallman
2017-09-11 19:42 ` Alan Mackenzie
2017-09-11 20:20 ` Stefan Monnier
2017-09-11 0:11 ` Dmitry Gutov
2017-09-11 20:12 ` Alan Mackenzie
2017-09-12 0:24 ` Dmitry Gutov
2017-09-17 10:29 ` Alan Mackenzie
2017-09-17 23:43 ` Dmitry Gutov
2017-09-18 19:08 ` Alan Mackenzie
2017-09-19 0:02 ` Dmitry Gutov
2017-09-19 20:47 ` Alan Mackenzie
2017-09-22 14:09 ` Dmitry Gutov
2017-09-24 11:26 ` Alan Mackenzie [this message]
2017-09-25 23:53 ` Dmitry Gutov
2017-10-01 16:36 ` Alan Mackenzie
2017-10-04 20:07 ` Johan Bockgård
2017-09-17 11:12 ` Philipp Stephani
2017-09-19 20:50 ` Alan Mackenzie
2017-09-07 17:56 ` Alan Mackenzie
2017-09-07 20:36 ` Dmitry Gutov
2016-03-19 23:16 ` Vitalie Spinu
2016-03-19 23:00 ` Vitalie Spinu
2016-03-19 23:20 ` Dmitry Gutov
[not found] ` <mailman.7307.1457709188.843.bug-gnu-emacs@gnu.org>
2017-10-01 16:31 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170924112637.GA5725@ACM \
--to=acm@muc.de \
--cc=22983@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=jwiegley@gmail.com \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).