From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.bugs Subject: bug#22983: [ Patch ] Re: bug#22983: syntax-ppss returns wrong result. Date: Sun, 17 Sep 2017 10:29:56 +0000 Message-ID: <20170917102956.GA4519@ACM> References: <83h8wlz1kf.fsf@gnu.org> <20170902174027.GB4267@ACM> <20170907204502.GC4488@ACM> <69e034d3-7a52-cc81-dc56-e5308ad5dce0@yandex.ru> <20170910113626.GB3588@ACM> <20170911201204.GC3605@ACM> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1505644629 11839 195.159.176.226 (17 Sep 2017 10:37:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 17 Sep 2017 10:37:09 +0000 (UTC) User-Agent: Mutt/1.7.2 (2016-11-26) Cc: John Wiegley , Philipp Stephani , 22983@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 17 12:37:04 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtWwi-0002wg-PJ for geb-bug-gnu-emacs@m.gmane.org; Sun, 17 Sep 2017 12:37:04 +0200 Original-Received: from localhost ([::1]:60016 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dtWwq-0004Ad-2c for geb-bug-gnu-emacs@m.gmane.org; Sun, 17 Sep 2017 06:37:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44649) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dtWwk-0004A6-1t for bug-gnu-emacs@gnu.org; Sun, 17 Sep 2017 06:37:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dtWwg-0001Lx-3Z for bug-gnu-emacs@gnu.org; Sun, 17 Sep 2017 06:37:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35789) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dtWwf-0001Lq-Ve for bug-gnu-emacs@gnu.org; Sun, 17 Sep 2017 06:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dtWwf-0008NT-Jz for bug-gnu-emacs@gnu.org; Sun, 17 Sep 2017 06:37:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Mackenzie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Sep 2017 10:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22983 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22983-submit@debbugs.gnu.org id=B22983.150564457632146 (code B ref 22983); Sun, 17 Sep 2017 10:37:01 +0000 Original-Received: (at 22983) by debbugs.gnu.org; 17 Sep 2017 10:36:16 +0000 Original-Received: from localhost ([127.0.0.1]:44470 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtWvw-0008MQ-Kt for submit@debbugs.gnu.org; Sun, 17 Sep 2017 06:36:16 -0400 Original-Received: from ocolin.muc.de ([193.149.48.4]:26603 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1dtWvt-0008MH-Li for 22983@debbugs.gnu.org; Sun, 17 Sep 2017 06:36:14 -0400 Original-Received: (qmail 11088 invoked by uid 3782); 17 Sep 2017 10:36:11 -0000 Original-Received: from acm.muc.de (p548C6BCB.dip0.t-ipconnect.de [84.140.107.203]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 17 Sep 2017 12:36:09 +0200 Original-Received: (qmail 4542 invoked by uid 1000); 17 Sep 2017 10:29:56 -0000 Content-Disposition: inline In-Reply-To: X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:137024 Archived-At: Hello, Dmitry. On Tue, Sep 12, 2017 at 03:24:08 +0300, Dmitry Gutov wrote: > On 9/11/17 11:12 PM, Alan Mackenzie wrote: [ .... ] > > I wouldn't be keen on seeing lots of (car compound-variable) and (cdr > > compound-variable) throughout the syntax-ppss function. I think it > > would make it significantly more difficult to understand. > Hopefully there will be only several such places. But again, we can use > structs. I don't know anything about these things. But seeing as how syntax.el is preloaded, the definition of structs would need to be preloaded earlier. > >> Would you like to see the code? > > Yes, why not? > Please give me until the end of the week. The end of the week has arrived. Are you still intending to propose an alternative formulation of the new cache manipulation for syntax-ppss? > > But just to make my position clear, I'm not particularly fixed on my > > patch as submitted. It was optimised for simplicity and correctness > > rather than elegance, though I don't think it's too bad. I'm fairly > > open on whether we use your suggestions or Stefan's suggestion of having > > an alist of caches. > Cool. -- Alan Mackenzie (Nuremberg, Germany).