bug#28443: 26.0.50; Pause when fullscreening when ns-use-native-fullscreen is nil on macOS

[Alan Third <alan@idiocy.org>]

On Wed, Sep 13, 2017 at 05:15:49AM -0700, Aaron Jensen wrote:
> 
> When ns-use-native-fullscreen is nil and a frame is set to fullscreen,
> there is a slight pause before the frame goes fullscreen. I believe the
> pause is about the same length as the animation when native fullscreen
> is used, so I'm wondering if there's some timing code in there that can
> be disabled when non-native fullscreen is being used.

Found it. In ns_fullscreen_hook in nsterm.m there is a timer:

      /* Old style fs don't initiate correctly if created from
         init/default-frame alist, so use a timer (not nice...).
      */
      [NSTimer scheduledTimerWithTimeInterval: 0.5 target: view
                                     selector: @selector (handleFS)
                                     userInfo: nil repeats: NO];

if I replace the timer with

    [view handleFS]

it works absolutely fine, but I have to assume there are situations
where it doesn’t.
-- 
Alan Third