unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Vasilij Schneidermann <v.schneidermann@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: larsi@gnus.org, 28402@debbugs.gnu.org
Subject: bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions
Date: Wed, 13 Sep 2017 19:22:32 +0200	[thread overview]
Message-ID: <20170913172232.7jwwomyfmy567nrx@odonien.localdomain> (raw)
In-Reply-To: <83poaxrzl1.fsf@gnu.org>

> From a cursory look into shr.el, it looks like
> shr-external-rendering-functions were introduced to support some
> specific eww.el needs, not as a general lever for tweaking shr.el from
> outside it.  That's why only a handful of functions honor that
> variable.

I suspected as much.

> Would you like to submit a patch that would make all shr-tag-*
> functions consult that variable first?

Before doing that I'd like to get a confirmation from the author whether
it's intended for shr-external-rendering-functions to become public API
and whether it should work globally, hence why I included them in the
CC.





  reply	other threads:[~2017-09-13 17:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-09 19:39 bug#28402: 25.2; shr.el uses shr-tag-img despite set shr-external-rendering-functions Vasilij Schneidermann
2017-09-11 16:04 ` Eli Zaretskii
2017-09-13 17:22   ` Vasilij Schneidermann [this message]
2017-09-13 18:37     ` Eli Zaretskii
2017-09-24 13:10       ` Vasilij Schneidermann
2017-09-29  7:31         ` Eli Zaretskii
2017-10-05 10:02           ` Eli Zaretskii
2017-10-05 10:18           ` Lars Ingebrigtsen
2017-10-05 11:01             ` Eli Zaretskii
2017-10-05 11:18               ` Lars Ingebrigtsen
2017-10-05 13:14                 ` Eli Zaretskii
2017-10-05 13:22                   ` Lars Ingebrigtsen
2017-10-05 13:44                     ` Eli Zaretskii
2017-10-05 13:52                       ` Lars Ingebrigtsen
2017-10-05 20:08                         ` Vasilij Schneidermann
2017-10-05 20:10                           ` Lars Ingebrigtsen
2017-10-06 12:43                           ` Eli Zaretskii
2017-09-13 17:27 ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170913172232.7jwwomyfmy567nrx@odonien.localdomain \
    --to=v.schneidermann@gmail.com \
    --cc=28402@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).