From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Winston Newsgroups: gmane.emacs.bugs Subject: bug#28403: 25.2; find-tag works, but xref-find-definitions Date: Sun, 10 Sep 2017 16:12 EDT Message-ID: <201709102012.v8AKC49v019100@psr.com> References: <201709092240.v89MeFUo014854@psr.com> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1505074416 15395 195.159.176.226 (10 Sep 2017 20:13:36 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 10 Sep 2017 20:13:36 +0000 (UTC) Cc: 28403@debbugs.gnu.org, dgutov@yandex.ru To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 10 22:13:32 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dr8bN-0002g6-8Z for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 Sep 2017 22:13:09 +0200 Original-Received: from localhost ([::1]:54146 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dr8bS-0005HF-Px for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 Sep 2017 16:13:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37768) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dr8bK-0005Fb-Ti for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2017 16:13:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dr8bF-00035C-Vu for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2017 16:13:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51071) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dr8bF-00034p-Rx for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2017 16:13:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dr8bF-0008V4-IW for bug-gnu-emacs@gnu.org; Sun, 10 Sep 2017 16:13:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <201709092240.v89MeFUo014854@psr.com> Resent-From: Winston Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Sep 2017 20:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28403 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28403-submit@debbugs.gnu.org id=B28403.150507432832613 (code B ref 28403); Sun, 10 Sep 2017 20:13:01 +0000 Original-Received: (at 28403) by debbugs.gnu.org; 10 Sep 2017 20:12:08 +0000 Original-Received: from localhost ([127.0.0.1]:59752 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dr8aO-0008Tx-IX for submit@debbugs.gnu.org; Sun, 10 Sep 2017 16:12:08 -0400 Original-Received: from mail.psr.com ([67.212.42.216]:23422 helo=psr.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dr8aM-0008TS-BD for 28403@debbugs.gnu.org; Sun, 10 Sep 2017 16:12:06 -0400 Original-Received: from psr.com (localhost [127.0.0.1]) by psr.com (8.15.2/8.15.2) with ESMTPS id v8AKC5Y1019101 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 10 Sep 2017 16:12:05 -0400 (EDT) (envelope-from wbe@psr.com) Original-Received: (from wbe@localhost) by psr.com (8.15.2/8.15.2/Submit) id v8AKC49v019100; Sun, 10 Sep 2017 16:12:04 -0400 (EDT) (envelope-from wbe) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:136744 Archived-At: Eli suggested: > ... here's how I suggest you invoke etags to solve the > problems with the _ARGS# macros: > > etags --regex="/[ \t]*\([^ \t]+\)[ \t]+_ARGS/\1/" ... I don't think that quite works because it doesn't flush the number. Probably more like: etags --regex="/[ \t]*\([^ \t]+\)[ \t]+_ARGS[0-9]+/\1/" ... but since, in this particular case, there's never any leading space on the line before a function name and the code doesn't use tabs on those lines, maybe etags --regex="/\([^ ]+\) +_ARGS[0-9]+/\1/" ... would work as well? (Does regex have an implicit '^'? If not, I'll use an explicit one.) > This will tell etags to tag the symbols immediately preceding the > _ARGS# macro invocations _in_addition_ to what it already does. [Too bad etags doesn't have a way of doing "s/[ \t]+_ARGS[0-9]*//" on the lines it normally finds...] > Then you can use xref-find-definitions in its default configuration, > and it will find your functions. OK. I like that approach better than having to do the setq, especially since putting a suitable etags command in a makefile is easy. That also has the benefit of tying the fix to the code written in that style, rather than making a global change that would affect other code I work on. Thanks! -WBE