From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Winston Newsgroups: gmane.emacs.bugs Subject: bug#28403: 25.2; find-tag works, but xref-find-definitions doesn't; bug? Date: Sat, 9 Sep 2017 18:40 EDT Message-ID: <201709092240.v89MeFUo014854@psr.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=fixed X-Trace: blaine.gmane.org 1504996894 8335 195.159.176.226 (9 Sep 2017 22:41:34 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 9 Sep 2017 22:41:34 +0000 (UTC) To: 28403@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 10 00:41:26 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dqoR2-00012C-FU for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 Sep 2017 00:41:08 +0200 Original-Received: from localhost ([::1]:51076 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dqoR9-0001VH-Jq for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Sep 2017 18:41:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37207) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dqoR0-0001UE-U7 for bug-gnu-emacs@gnu.org; Sat, 09 Sep 2017 18:41:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dqoQx-0007oB-0q for bug-gnu-emacs@gnu.org; Sat, 09 Sep 2017 18:41:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49338) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dqoQw-0007o1-Tm for bug-gnu-emacs@gnu.org; Sat, 09 Sep 2017 18:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dqoQw-0001Nj-Jn for bug-gnu-emacs@gnu.org; Sat, 09 Sep 2017 18:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Winston Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Sep 2017 22:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 28403 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.15049968305264 (code B ref -1); Sat, 09 Sep 2017 22:41:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 9 Sep 2017 22:40:30 +0000 Original-Received: from localhost ([127.0.0.1]:58019 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dqoQP-0001Mq-Sk for submit@debbugs.gnu.org; Sat, 09 Sep 2017 18:40:30 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46120) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dqoQO-0001Md-GT for submit@debbugs.gnu.org; Sat, 09 Sep 2017 18:40:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dqoQI-0007ci-Hj for submit@debbugs.gnu.org; Sat, 09 Sep 2017 18:40:23 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:34056) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dqoQI-0007ce-EU for submit@debbugs.gnu.org; Sat, 09 Sep 2017 18:40:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37082) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dqoQH-00018H-38 for bug-gnu-emacs@gnu.org; Sat, 09 Sep 2017 18:40:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dqoQD-0007YW-5L for bug-gnu-emacs@gnu.org; Sat, 09 Sep 2017 18:40:21 -0400 Original-Received: from mail.psr.com ([67.212.42.216]:22149 helo=psr.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dqoQC-0007Vm-W1 for bug-gnu-emacs@gnu.org; Sat, 09 Sep 2017 18:40:17 -0400 Original-Received: from psr.com (localhost [127.0.0.1]) by psr.com (8.15.2/8.15.2) with ESMTPS id v89MeF4r014855 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 9 Sep 2017 18:40:15 -0400 (EDT) (envelope-from wbe@psr.com) Original-Received: (from wbe@localhost) by psr.com (8.15.2/8.15.2/Submit) id v89MeFUo014854; Sat, 9 Sep 2017 18:40:15 -0400 (EDT) (envelope-from wbe) X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:136718 Archived-At: [Emacs 25.2; it looks (to me) like a regexp match pattern issue in xref.el, not an O/S issue.] Today I noticed the message about find-tag being (supposedly) obsoleted by xref-find-definitions as of Emacs version 25.1, so I tried the new command. Unfortunately, the new one failed completely on an entire class of function definitions. After some experimenting, it appears that the problem may be that xref-find-definitions only works when the function definition is of the form: name spacing* '('. The C code in question uses macros around function arguments in its definitions. E.g., name _ARGS1(type,variable) find-tag (and etags) work just fine with that, and such function definition lines appear in the TAGS file (as they should), but xref-find-definitions fails to find such function tags, saying instead "No definitions found for: name". Changing the function definition line to name (type variable) as a test, re-running etags, and reloading TAGS, xref-find-definitions found the tag and went to it. So, xref-find-definitions is not yet a complete replacement for find-tag. Since etags puts such lines in TAGS and xref-find-definitions is unable to match up the name with the tag, it looks like a bug / deficiency in xref-find-definitions. -WBE