From: Alan Mackenzie <acm@muc.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: jwiegley@gmail.com, Dmitry Gutov <dgutov@yandex.ru>,
22983@debbugs.gnu.org
Subject: bug#22983: syntax-ppss returns wrong result.
Date: Sat, 2 Sep 2017 17:40:27 +0000 [thread overview]
Message-ID: <20170902174027.GB4267@ACM> (raw)
In-Reply-To: <83h8wlz1kf.fsf@gnu.org>
Hello, Eli.
On Sat, Sep 02, 2017 at 16:12:48 +0300, Eli Zaretskii wrote:
> unblock 24655 by 22983
> thanks
> > From: Dmitry Gutov <dgutov@yandex.ru>
> > Date: Mon, 4 Apr 2016 02:15:50 +0300
> > Cc: Alan Mackenzie <acm@muc.de>, 22983@debbugs.gnu.org
> > On 04/04/2016 01:58 AM, John Wiegley wrote:
> > > Have things reached a satisfactory conclusion now? It was hard for me to tell
> > > by the end of this thread.
> > It's a separate discussion, see
> > http://lists.gnu.org/archive/html/emacs-devel/2016-03/msg01576.html
> > > Sure, though it's experimental nature does get taken into account. If a thing
> > > is wrong, I'm not interested in accommodating existing workarounds to its
> > > wrongness.
> > What experimental nature?
> It doesn't sound like this discussion is leading anywhere, and since
> almost 1.5 years has passed with no comments, I guess this bug doesn't
> need to block the release of Emacs 26.1, at least.
I'm not happy about this. 22983 is a serious design flaw, which has had
deleterious effects deep within Emacs. One recorded example, resulting
in an infinite loop, is:
#########################################################################
From: Philipp Stephani <p.stephani2@gmail.com>
To: emacs-devel@gnu.org
Subject: [PATCH] Protect against an infloop in python-mode
Date: Tue, 28 Feb 2017 22:31:49 +0100
There appears to be an edge case caused by using `syntax-ppss' in a
narrowed buffer during JIT lock inside of Python triple-quote strings.
Unfortunately it is impossible to reproduce without manually
destroying the syntactic information in the Python buffer, but it has
been observed in practice. In that case it can happen that the syntax
caches get sufficiently out of whack so that there appear to be
overlapping strings in the buffer. As Python has no nested strings,
this situation is impossible and leads to an infloop in
`python-nav-end-of-statement'. Protect against this by checking
whether the search for the end of the current string makes progress.
#########################################################################
In this case, Philipp had to apply a workaround.
Seeing as how Stefan is not prepared to take responsibility for his own
bugs, I suggest that I fix it, something I really don't want to spend
time on. Before I do start spending time on it, I would like some
assurance that my fix will not be blocked or reverted (both have happened
to other things in the core I've worked on), and that I will have a
reasonable amount of time to get the job done (a few weeks) before any
freeze for Emacs 25.3 or 26 comes into force.
> Thanks.
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2017-09-02 17:40 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 15:15 bug#22983: syntax-ppss returns wrong result Alan Mackenzie
2016-03-11 20:31 ` Dmitry Gutov
2016-03-11 21:24 ` Alan Mackenzie
2016-03-11 21:35 ` Dmitry Gutov
2016-03-11 22:15 ` Alan Mackenzie
2016-03-11 22:38 ` Dmitry Gutov
2016-03-13 17:37 ` Stefan Monnier
2016-03-13 18:57 ` Alan Mackenzie
2016-03-14 0:47 ` Dmitry Gutov
2016-03-14 1:04 ` Drew Adams
2016-04-03 22:55 ` John Wiegley
2016-03-14 1:49 ` Stefan Monnier
2016-03-13 17:32 ` Stefan Monnier
2016-03-13 18:52 ` Andreas Röhler
2016-03-13 18:56 ` Dmitry Gutov
2016-03-18 0:49 ` Dmitry Gutov
2016-03-19 12:27 ` Alan Mackenzie
2016-03-19 18:47 ` Dmitry Gutov
2016-03-27 0:51 ` John Wiegley
2016-03-27 1:14 ` Dmitry Gutov
2016-04-03 22:58 ` John Wiegley
2016-04-03 23:15 ` Dmitry Gutov
2017-09-02 13:12 ` Eli Zaretskii
2017-09-02 17:40 ` Alan Mackenzie [this message]
2017-09-02 17:53 ` Eli Zaretskii
2017-09-03 20:44 ` John Wiegley
2017-09-04 23:34 ` Dmitry Gutov
2017-09-05 6:57 ` Andreas Röhler
2017-09-05 12:28 ` John Wiegley
2017-09-07 20:45 ` Alan Mackenzie
2017-09-08 16:04 ` Andreas Röhler
2017-09-10 18:26 ` Alan Mackenzie
2017-09-09 9:44 ` Dmitry Gutov
2017-09-09 10:20 ` Alan Mackenzie
2017-09-09 12:18 ` Dmitry Gutov
2017-09-10 11:42 ` Alan Mackenzie
2017-09-10 11:36 ` bug#22983: [ Patch ] " Alan Mackenzie
2017-09-10 22:53 ` Stefan Monnier
2017-09-10 23:36 ` Dmitry Gutov
2017-09-11 11:10 ` Stefan Monnier
2017-09-12 0:11 ` Dmitry Gutov
2017-09-12 22:12 ` Richard Stallman
2017-09-11 19:42 ` Alan Mackenzie
2017-09-11 20:20 ` Stefan Monnier
2017-09-11 0:11 ` Dmitry Gutov
2017-09-11 20:12 ` Alan Mackenzie
2017-09-12 0:24 ` Dmitry Gutov
2017-09-17 10:29 ` Alan Mackenzie
2017-09-17 23:43 ` Dmitry Gutov
2017-09-18 19:08 ` Alan Mackenzie
2017-09-19 0:02 ` Dmitry Gutov
2017-09-19 20:47 ` Alan Mackenzie
2017-09-22 14:09 ` Dmitry Gutov
2017-09-24 11:26 ` Alan Mackenzie
2017-09-25 23:53 ` Dmitry Gutov
2017-10-01 16:36 ` Alan Mackenzie
2017-10-04 20:07 ` Johan Bockgård
2017-09-17 11:12 ` Philipp Stephani
2017-09-19 20:50 ` Alan Mackenzie
2017-09-07 17:56 ` Alan Mackenzie
2017-09-07 20:36 ` Dmitry Gutov
2016-03-19 23:16 ` Vitalie Spinu
2016-03-19 23:00 ` Vitalie Spinu
2016-03-19 23:20 ` Dmitry Gutov
[not found] ` <mailman.7307.1457709188.843.bug-gnu-emacs@gnu.org>
2017-10-01 16:31 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170902174027.GB4267@ACM \
--to=acm@muc.de \
--cc=22983@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=eliz@gnu.org \
--cc=jwiegley@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).