* bug#28222: [Emacs-diffs] master fdde981 2/3: Fix cross macOS version building (bug#28222) [not found] ` <20170829162331.5C2602092B@vcs0.savannah.gnu.org> @ 2017-08-31 18:40 ` Charles A. Roelli 2017-08-31 18:47 ` Alan Third 0 siblings, 1 reply; 4+ messages in thread From: Charles A. Roelli @ 2017-08-31 18:40 UTC (permalink / raw) To: Alan Third; +Cc: 28222 > Date: Tue, 29 Aug 2017 12:23:31 -0400 (EDT) > From: alan@idiocy.org (Alan Third) > > branch: master > commit fdde98113c5d1c2d4eb5c25fa750c976d90f8555 > Author: Alan Third <alan@idiocy.org> > Commit: Alan Third <alan@idiocy.org> > > Fix cross macOS version building (bug#28222) > > * src/macfont.h (CGContextSetFontSmoothingStyle): Function > declaration. > * src/macfont.m (macfont_draw): Limit new code to macOS 10.8 and up. I should have mentioned this before: I tried the patch that implements ns_use_thin_smoothing on 10.6, and it worked well. So it seems that the function is available after all on 10.6+. ^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#28222: [Emacs-diffs] master fdde981 2/3: Fix cross macOS version building (bug#28222) 2017-08-31 18:40 ` bug#28222: [Emacs-diffs] master fdde981 2/3: Fix cross macOS version building (bug#28222) Charles A. Roelli @ 2017-08-31 18:47 ` Alan Third 2017-08-31 19:09 ` Charles A. Roelli 0 siblings, 1 reply; 4+ messages in thread From: Alan Third @ 2017-08-31 18:47 UTC (permalink / raw) To: Charles A. Roelli; +Cc: 28222 On Thu, Aug 31, 2017 at 08:40:47PM +0200, Charles A. Roelli wrote: > > Date: Tue, 29 Aug 2017 12:23:31 -0400 (EDT) > > From: alan@idiocy.org (Alan Third) > > > > branch: master > > commit fdde98113c5d1c2d4eb5c25fa750c976d90f8555 > > Author: Alan Third <alan@idiocy.org> > > Commit: Alan Third <alan@idiocy.org> > > > > Fix cross macOS version building (bug#28222) > > > > * src/macfont.h (CGContextSetFontSmoothingStyle): Function > > declaration. > > * src/macfont.m (macfont_draw): Limit new code to macOS 10.8 and up. > > I should have mentioned this before: I tried the patch that implements > ns_use_thin_smoothing on 10.6, and it worked well. So it seems that > the function is available after all on 10.6+. Oh, excellent! I’ll remove the 10.8 stuff, then. I take it the function declaration in macfont.h is required, though? It’s needed on 10.12 or else we get a warning. Thanks! -- Alan Third ^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#28222: [Emacs-diffs] master fdde981 2/3: Fix cross macOS version building (bug#28222) 2017-08-31 18:47 ` Alan Third @ 2017-08-31 19:09 ` Charles A. Roelli 2017-08-31 19:47 ` Alan Third 0 siblings, 1 reply; 4+ messages in thread From: Charles A. Roelli @ 2017-08-31 19:09 UTC (permalink / raw) To: Alan Third; +Cc: 28222 > Date: Thu, 31 Aug 2017 19:47:09 +0100 > From: Alan Third <alan@idiocy.org> > > On Thu, Aug 31, 2017 at 08:40:47PM +0200, Charles A. Roelli wrote: > > > Date: Tue, 29 Aug 2017 12:23:31 -0400 (EDT) > > > From: alan@idiocy.org (Alan Third) > > > > > > branch: master > > > commit fdde98113c5d1c2d4eb5c25fa750c976d90f8555 > > > Author: Alan Third <alan@idiocy.org> > > > Commit: Alan Third <alan@idiocy.org> > > > > > > Fix cross macOS version building (bug#28222) > > > > > > * src/macfont.h (CGContextSetFontSmoothingStyle): Function > > > declaration. > > > * src/macfont.m (macfont_draw): Limit new code to macOS 10.8 and up. > > > > I should have mentioned this before: I tried the patch that implements > > ns_use_thin_smoothing on 10.6, and it worked well. So it seems that > > the function is available after all on 10.6+. > > Oh, excellent! I’ll remove the 10.8 stuff, then. > > I take it the function declaration in macfont.h is required, though? > It’s needed on 10.12 or else we get a warning. That's right, the declaration should stay. Thanks for taking care of this. ^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#28222: [Emacs-diffs] master fdde981 2/3: Fix cross macOS version building (bug#28222) 2017-08-31 19:09 ` Charles A. Roelli @ 2017-08-31 19:47 ` Alan Third 0 siblings, 0 replies; 4+ messages in thread From: Alan Third @ 2017-08-31 19:47 UTC (permalink / raw) To: Charles A. Roelli; +Cc: 28222 > > > I should have mentioned this before: I tried the patch that implements > > > ns_use_thin_smoothing on 10.6, and it worked well. So it seems that > > > the function is available after all on 10.6+. > > > > Oh, excellent! I’ll remove the 10.8 stuff, then. > > > > I take it the function declaration in macfont.h is required, though? > > It’s needed on 10.12 or else we get a warning. > > That's right, the declaration should stay. Thanks for taking care of > this. Change pushed to master. Thanks, Charles. -- Alan Third ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-08-31 19:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20170829162330.12288.81050@vcs0.savannah.gnu.org>
[not found] ` <20170829162331.5C2602092B@vcs0.savannah.gnu.org>
2017-08-31 18:40 ` bug#28222: [Emacs-diffs] master fdde981 2/3: Fix cross macOS version building (bug#28222) Charles A. Roelli
2017-08-31 18:47 ` Alan Third
2017-08-31 19:09 ` Charles A. Roelli
2017-08-31 19:47 ` Alan Third
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).