unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Mark Oteiza <mvoteiza@udel.edu>
To: npostavs@users.sourceforge.net
Cc: 28257@debbugs.gnu.org
Subject: bug#28257: 26.0.50; [PATCH] expose eldoc functions in a hook
Date: Tue, 29 Aug 2017 21:50:17 -0400	[thread overview]
Message-ID: <20170830015017.GA28668@holos.localdomain> (raw)
In-Reply-To: <87shgb89q1.fsf@users.sourceforge.net>

On 28/08/17 at 09:05pm, npostavs@users.sourceforge.net wrote:
>Mark Oteiza <mvoteiza@udel.edu> writes:
>
>> If both the buffer mode's documentation function and the function in the
>> default-value return non-nil at a point, execution stops at the
>> :before-until function, analogous to run-hook-with-args-until-success.
>>
>> I want to see both results.  See what eldoc-documentation-compose does.
>>
>> To do what is described above, not only does one have to write some
>> wrapper function to advise eldoc-documentation-function buffer-locally,
>> but also one has to hook into any/every mode that might add its own doc
>> function.
>
>Ah, I think I understand now.  The patch makes it easier to customize
>the composition of all eldoc-documentation-functions at the cost of
>making it more difficult for the individual mode to decide how its own
>doc function will compose.

Correct.

> Could be a worthwhile tradeoff (especially
>since there currently aren't any individual mode eldoc functions using
>anything apart from :before-until, afaik); I'm on the fence about this.

Not in emacs, at least.  In elpa, ggtags uses :after-until.  The only
3rd party packages--that I can think of right now--that implement eldoc
functions just use setq-local (elpy and geiser).





  reply	other threads:[~2017-08-30  1:50 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-28  2:10 bug#28257: 26.0.50; [PATCH] expose eldoc functions in a hook Mark Oteiza
2017-08-28  2:49 ` npostavs
2017-08-28  3:11   ` Mark Oteiza
2017-08-29  1:05     ` npostavs
2017-08-30  1:50       ` Mark Oteiza [this message]
2019-06-24 16:16         ` Lars Ingebrigtsen
2019-06-24 22:51           ` Noam Postavsky
2019-06-26 14:03             ` Mark Oteiza
2020-01-26 23:47               ` Mark Oteiza
2020-01-31 14:05                 ` Eli Zaretskii
2020-02-08 10:03                   ` Eli Zaretskii
2020-02-11 21:57                     ` Noam Postavsky
2020-02-14  9:58                       ` Eli Zaretskii
2020-02-14 14:51                         ` Stefan Monnier
2020-02-14 14:50                 ` Stefan Monnier
2020-02-14 22:54                   ` Mark Oteiza
2020-02-21  8:47                     ` Eli Zaretskii
2020-02-25 23:18                       ` Mark Oteiza
2020-08-10 14:42                         ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170830015017.GA28668@holos.localdomain \
    --to=mvoteiza@udel.edu \
    --cc=28257@debbugs.gnu.org \
    --cc=npostavs@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).