From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Third Newsgroups: gmane.emacs.bugs Subject: bug#21714: [PATCH] Add multiframe image support to NS port (bug#21714) Date: Sun, 13 Aug 2017 15:56:12 +0100 Message-ID: <20170813145612.GA47351@breton.holly.idiocy.org> References: <20170813005818.GA27146@breton.holly.idiocy.org> <87bmnj1u3b.fsf@users.sourceforge.net> <20170813133745.GA45884@breton.holly.idiocy.org> <878tin1skg.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1502636236 14701 195.159.176.226 (13 Aug 2017 14:57:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 13 Aug 2017 14:57:16 +0000 (UTC) User-Agent: Mutt/1.7.2 (2016-11-26) Cc: Keith David Bershatsky , 21714@debbugs.gnu.org To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 13 16:57:13 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dguKB-0003J6-LF for geb-bug-gnu-emacs@m.gmane.org; Sun, 13 Aug 2017 16:57:07 +0200 Original-Received: from localhost ([::1]:58288 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dguKI-0007Te-2s for geb-bug-gnu-emacs@m.gmane.org; Sun, 13 Aug 2017 10:57:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48045) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dguKB-0007TA-0S for bug-gnu-emacs@gnu.org; Sun, 13 Aug 2017 10:57:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dguK6-0001a4-Pf for bug-gnu-emacs@gnu.org; Sun, 13 Aug 2017 10:57:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50901) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dguK6-0001ZO-LH for bug-gnu-emacs@gnu.org; Sun, 13 Aug 2017 10:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dguK6-0004AH-8l for bug-gnu-emacs@gnu.org; Sun, 13 Aug 2017 10:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alan Third Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Aug 2017 14:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21714 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 21714-submit@debbugs.gnu.org id=B21714.150263618316001 (code B ref 21714); Sun, 13 Aug 2017 14:57:02 +0000 Original-Received: (at 21714) by debbugs.gnu.org; 13 Aug 2017 14:56:23 +0000 Original-Received: from localhost ([127.0.0.1]:59579 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dguJT-0004A1-5h for submit@debbugs.gnu.org; Sun, 13 Aug 2017 10:56:23 -0400 Original-Received: from mail-wm0-f43.google.com ([74.125.82.43]:36994) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dguJS-00049v-24 for 21714@debbugs.gnu.org; Sun, 13 Aug 2017 10:56:22 -0400 Original-Received: by mail-wm0-f43.google.com with SMTP id i66so26007610wmg.0 for <21714@debbugs.gnu.org>; Sun, 13 Aug 2017 07:56:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=txwgTi4jhYFtUuTq2MVbriaY0fGBeUWMFsaKc0zHjRU=; b=PzGsvrzy7Ki0+LW7mtcg1oLNYmc8FLXm+4fVecUglvY8Zbu9ZQw80mkaHq6RC5V32Q Y+91ikG56m1SW3ILIrC0sDz+ht3YLLrij2KTYFyCnSAgYqvU0dg4omkv6tzfzVSrfZh5 HAfMgTF8FnkFjEv5Bu+OOumjY/IBmc9NICu3qd2v5vjATMo99VpCuLKRxxI946v3DSuQ Med6lrcEoRNn+uQgCYd4zLHey357/UMJbDardx1YE85baMI10F/QUScbBv/z64Mhe2Rv 1fQHhYE4SSkATfmK0K+sTBxv2pYnopJB7zXLs1cxA8gXZtY33li6NNGoPceptmsRW0xu zziw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=txwgTi4jhYFtUuTq2MVbriaY0fGBeUWMFsaKc0zHjRU=; b=GgUjG7odJTE+4HuGnxh31DTUqVkhfZYqW/S+LqtMWo3p8f5rlLUiW1LUKUST58GJIE bkDeH00Ca63kYem/FopkaYSSreZ+MM43udP72L69aURNZOKwp9YXkbOiGrg/TqeC8dld ty4JgfjiSwiSrwje92S+N3r+mTzsdU4CrSxRSeC+gY+OwZCIn7VG5N0emU/xGSxutc79 WLNQtorEPeUM2oMOo/B9ZwUiEI6DaJPoLzoYVbeaZeTh+DCvgq8ia3vIEmVTUsn1UeG0 6wGJRkMBDEnU818NKoT1L13npNPESy0V4D4smlr/y3WzPfGUizJ9mT/zC/j/tmMfpfeO LZIA== X-Gm-Message-State: AHYfb5iAOgzc8wkcIOUAmW8K+5G6ejrwWEVetmcJHEDop0nOwVDOHP0F OKbMsqLHQTgERQ== X-Received: by 10.28.26.5 with SMTP id a5mr2954056wma.80.1502636176057; Sun, 13 Aug 2017 07:56:16 -0700 (PDT) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-8ddc-b80d-a658-c5ed.holly.idiocy.org. [2001:8b0:3f8:8129:8ddc:b80d:a658:c5ed]) by smtp.gmail.com with ESMTPSA id 69sm1339105wrk.2.2017.08.13.07.56.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 13 Aug 2017 07:56:15 -0700 (PDT) Content-Disposition: inline In-Reply-To: <878tin1skg.fsf@users.sourceforge.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135726 Archived-At: On Sun, Aug 13, 2017 at 09:54:39AM -0400, npostavs@users.sourceforge.net wrote: > Alan Third writes: > > > On Sun, Aug 13, 2017 at 09:21:44AM -0400, npostavs@users.sourceforge.net wrote: > >> Alan Third writes: > >> > >> > +static Lisp_Object > >> > +image_spec_value (Lisp_Object spec, Lisp_Object key, bool *found) > >> > +{ > >> > + Lisp_Object tail; > >> > + > >> > + eassert (valid_image_p (spec)); > >> > + > >> > + for (tail = XCDR (spec); > >> > + CONSP (tail) && CONSP (XCDR (tail)); > >> > + tail = XCDR (XCDR (tail))) > >> > + { > >> > + if (EQ (XCAR (tail), key)) > >> > + { > >> > + if (found) > >> > + *found = 1; > >> > + return XCAR (XCDR (tail)); > >> > + } > >> > + } > >> > >> Wouldn't it be clearer to call Fplist_get here? > > Actually we would need Fplist_member to set the 'found' parameter > correctly in case the value is Qnil. Hmm, that one can signal an error, > so potentially it's not the right thing. In this particular case I’m not using the found parameter anyway so Fplist_get will work fine. -- Alan Third